Forum > Designer
"TestAll" project issues
Aruna:
--- Quote from: JuhaManninen on February 04, 2023, 12:46:01 pm ---
--- Quote from: Aruna on February 01, 2023, 10:51:52 am ---Hello @Juha I have attached a testall.zip. Please see if you can get this back into the main trunk when you have time. Thank you.
--- End quote ---
I placed it in lcl/tests/testall/ and tried to compile. I got :
Error: Can't open resource file "/home/juha/SW/lazarus/lcl/tests/testall/../images/components_images.res"
--- End quote ---
This error is due to a path issue because we moved the files into a new location lcl/tests/testall. Instead of one level we have to now go up three levels so Lazarus can find the *.res files. Fix is shown below. The file is testallform.pp and line numbers are 171 and 172.
Original code below that causes error.
--- Code: Pascal [+][-]window.onload = function(){var x1 = document.getElementById("main_content_section"); if (x1) { var x = document.getElementsByClassName("geshi");for (var i = 0; i < x.length; i++) { x[i].style.maxHeight='none'; x[i].style.height = Math.min(x[i].clientHeight+15,306)+'px'; x[i].style.resize = "vertical";}};} ---{$R ../images/laz_images.res}{$R ../images/components_images.res}
The fix is below.
--- Code: Pascal [+][-]window.onload = function(){var x1 = document.getElementById("main_content_section"); if (x1) { var x = document.getElementsByClassName("geshi");for (var i = 0; i < x.length; i++) { x[i].style.maxHeight='none'; x[i].style.height = Math.min(x[i].clientHeight+15,306)+'px'; x[i].style.resize = "vertical";}};} ---{$R ../../../images/laz_images.res}{$R ../../../images/components_images.res}
--- Quote from: JuhaManninen on February 04, 2023, 12:46:01 pm ---
--- Quote from: Aruna on February 01, 2023, 11:00:16 am ---I have sent in a testall.zip and once you get it added back to the Lazarus sources I will start improving it. The testall.zip has all the original files with no changes. I think what you have said will be much easier than trying to get things working with Gitlab. So I will do what you asked me to and try to send in patches
--- End quote ---
I thought you fixed some issues for Linux, but adding the original files is perfectly OK, too.
--- End quote ---
Yes I did but then I thought let us just start from scratch the way it was. I did a git shortlog examples/testallform.pp in branch fixes_2_2 and I think attribution is important and I have no idea once we add the files I sent to lcl/tests/testall if the git history of who did what and when will remain intact? See below..
--- Code: Bash [+][-]window.onload = function(){var x1 = document.getElementById("main_content_section"); if (x1) { var x = document.getElementsByClassName("geshi");for (var i = 0; i < x.length; i++) { x[i].style.maxHeight='none'; x[i].style.height = Math.min(x[i].clientHeight+15,306)+'px'; x[i].style.resize = "vertical";}};} ---aruna@debian:/media/aruna/linux-next/lazarus$ git shortlog examples/testallform.ppbart (6): Examples: Fix resource loading in TestAll project. Examples: Start completely rewrting the TestAll apllication. Examples: TestAll: add a test (work in progress). Examples: TestAll: - make dummy procedures for all tests and call them in the menu's onclick event - fix typo - refactor - cleanup Examples: TestAll: more component tests. Examples: TestAll: don't write an extra '$' in front of Key when logging Key events. joost (1): general: Updated address of the Free Software Foundation in copyright messages juha (3): LCL (mostly), Replace Assert(False... with //DebugLn(... Now Assert can be used for its original purpose again. IDE etc.: unify 3 dots in GUI string to have a space ( ...). Examples: Fix compilation when function wrappers in FileUtil are disabled (define NoLazUTF8Wrappers). Clean uses sections. laurent (1): IDE: rename the images to avoid overload lazarus (11): + added "testall" demo provided by <christer.t.johansson@se.abb.com> stoppok +Rebuilt from beginning to V0.2 +Prepared for non existent components (total 60 components). (Changes by Christer, commited by stoppok) * Fixed crash caused by missing pixmaps * using resources now instead of xpm file * enhanced testdialog for TBevel * basic test for TPaintBox stoppok MG: minor fixes TPanel implemented. Basic graphic primitives split into GraphType package, so that we can reference it from interface (GTK, Win32) units. New Frame3d canvas method that uses native (themed) drawing (GTK only). New overloaded Canvas.TextRect method. LCLLinux and Graphics was split, so a bunch of files had to be modified. + Enhanced testall-app with demo for TPanel, stoppok MG: updated licenses MG: TNoteBook now starts with no Page and TPage has no auto names MG: fixed compiling examples MG: added interfaces unit marc (1): * Fixed compilation and some memleaks martin (1): Examples: Fix testallform for fpc2.3.1 (issue #14184) mattias (7): fixed testall example renamed LCLLinux to LCLIntf fixed testallbart (6): Examples: Fix resource loading in TestAll project. Examples: Start completely rewrting the TestAll apllication. Examples: TestAll: add a test (work in progress). Examples: TestAll: - make dummy procedures for all tests and call them in the menu's onclick event - fix typo - refactor - cleanup Examples: TestAll: more component tests. Examples: TestAll: don't write an extra '$' in front of Key when logging Key events. joost (1): general: Updated address of the Free Software Foundation in copyright messages juha (3): LCL (mostly), Replace Assert(False... with //DebugLn(... Now Assert can be used for its original purpose again. IDE etc.: unify 3 dots in GUI string to have a space ( ...). Examples: Fix compilation when function wrappers in FileUtil are disabled (define NoLazUTF8Wrappers). Clean uses sections. laurent (1): IDE: rename the images to avoid overload lazarus (11): + added "testall" demo provided by <christer.t.johansson@se.abb.com> stoppok +Rebuilt from beginning to V0.2 +Prepared for non existent components (total 60 components). (Changes by Christer, commited by stoppok) * Fixed crash caused by missing pixmaps * using resources now instead of xpm file * enhanced testdialog for TBevel * basic test for TPaintBox stoppok MG: minor fixes TPanel implemented. Basic graphic primitives split into GraphType package, so that we can reference it from interface (GTK, Win32) units. New Frame3d canvas method that uses native (themed) drawing (GTK only). New overloaded Canvas.TextRect method. LCLLinux and Graphics was split, so a bunch of files had to bbart (6): Examples: Fix resource loading in TestAll project. Examples: Start completely rewrting the TestAll apllication. Examples: TestAll: add a test (work in progress). Examples: TestAll: - make dummy procedures for all tests and call them in the menu's onclick event - fix typo - refactor - cleanup Examples: TestAll: more component tests. Examples: TestAll: don't write an extra '$' in front of Key when logging Key events. joost (1): general: Updated address of the Free Software Foundation in copyright messages juha (3): LCL (mostly), Replace Assert(False... with //DebugLn(... Now Assert can be used for its original purpose again. IDE etc.: unify 3 dots in GUI string to have a space ( ...). Examples: Fix compilation when function wrappers in FileUtil are disabled (define NoLazUTF8Wrappers). Clean uses sections. laurent (1): IDE: rename the images to avoid overload lazarus (11): + added "testall" demo provided by <christer.t.johansson@se.abb.com> stoppok +Rebuilt from beginning to V0.2 +Prepared for non existent components (total 60 components). (Changes by Christer, commited by stoppok) * Fixed crash caused by missing pixmaps * using resources now instead of xpm file * enhanced testdialog for TBevel * basic test for TPaintBox stoppokaruna@debian:/media/aruna/linux-next/lazarus$ I feel it is important to keep this info but I do not know how we are going to do this if we just plug the files into lcl/tests/testall? Or as usual I am not seeing the obvious?
--- Quote from: JuhaManninen on February 04, 2023, 12:46:01 pm ---Yes, when you work with local feature branches and patches, you don't need to create a fork in GitLab. Just clone the official repo like everybody else and then work locally.
I do the same thing basically. I happen to have commit rights and thus I do "git push" instead of uploading a patch somewhere.
I have many feature branches here. Most of them are experimental and will never be used for the official repository.
--- End quote ---
I stopped trying to get Gitlab to work it is simply too time-consuming and frustrating. Your way is very much simpler and hopefully will work for me. Thank you.
JuhaManninen:
--- Quote from: Aruna on February 04, 2023, 02:37:24 pm ---This error is due to a path issue because we moved the files into a new location lcl/tests/testall. Instead of one level we have to now go up three levels so Lazarus can find the *.res files.
--- End quote ---
Yes, it was easy to fix.
--- Quote ---Yes I did but then I thought let us just start from scratch the way it was. I did a git shortlog examples/testallform.pp in branch fixes_2_2 and I think attribution is important and I have no idea once we add the files I sent to lcl/tests/testall if the git history of who did what and when will remain intact?
--- End quote ---
It will remain intact in "main" and in "fixes_2_2". Nothing will change the existing history.
Anyway the TestAll project should be copied from "main" branch before its deletion from examples directory, thus including all changes. Is this version from there?
--- Quote ---I feel it is important to keep this info but I do not know how we are going to do this if we just plug the files into lcl/tests/testall? Or as usual I am not seeing the obvious?
--- End quote ---
The version in lcl/tests/ will have its own commit history once we start committing code.
Aruna:
--- Quote from: JuhaManninen on February 04, 2023, 06:11:35 pm ---Anyway the TestAll project should be copied from "main" branch before its deletion from the examples directory, thus including all changes. Is this version from there?
--- End quote ---
As it is right now in "main" branch if you check for testall by running ls -alh examples/test* there is nothing. Testall was removed at some point from "main" but it is still there under branch "fixes_2_2" and I copied it from branch "fixes_2_2". I vaguely remember asking where is "testall" and @dbannon pointed me in the right direction by saying I can find it under branch "fixes_2_2" but it is most definitely no longer in branch "main".
JuhaManninen:
--- Quote from: Aruna on February 04, 2023, 06:43:37 pm ---As it is right now in "main" branch if you check for testall by running ls -alh examples/test* there is nothing. Testall was removed at some point from "main" but it is still there under branch "fixes_2_2" and I copied it from branch "fixes_2_2". I vaguely remember asking where is "testall" and @dbannon pointed me in the right direction by saying I can find it under branch "fixes_2_2" but it is most definitely no longer in branch "main".
--- End quote ---
It got bugfixes in "main" branch before it was removed. Thus you must go to the last commit before the removal and copy it. I even explained it in some earlier post in detail.
Aruna:
--- Quote from: JuhaManninen on February 05, 2023, 12:39:26 am ---It got bugfixes in "main" branch before it was removed. Thus you must go to the last commit before the removal and copy it. I even explained it in some earlier post in detail.
--- End quote ---
I ran git log -S TestAllForm and got what is below..
--- Code: Bash [+][-]window.onload = function(){var x1 = document.getElementById("main_content_section"); if (x1) { var x = document.getElementsByClassName("geshi");for (var i = 0; i < x.length; i++) { x[i].style.maxHeight='none'; x[i].style.height = Math.min(x[i].clientHeight+15,306)+'px'; x[i].style.resize = "vertical";}};} ---commit 31328882fb8d3acace2ea1e906073c7c429fb146Author: Juha <juha@lazarus-ide.org>Date: Sat Mar 5 16:51:45 2022 +0200 Example projects tested, categorised, metadata added, restructured by David Bannon. commit 95ca76e85edc433d7d03f14daf28aafbcd92fa36Author: mattias <nc-gaertnma@netcologne.de>Date: Sat Oct 1 00:38:04 2005 +0000 added .lpi for examples git-svn-id: trunk@7869 - commit 09138261ffe900180e59df2d3c0ab21345d2c926Author: lazarus <lazarus@lazarus-ide.org>Date: Tue Oct 29 08:22:33 2002 +0000 MG: added interfaces unit git-svn-id: trunk@3578 - commit 6c9464c470122f2f48889e91d031da545fbd9b4cAuthor: lazarus <lazarus@lazarus-ide.org>Date: Fri May 10 06:57:51 2002 +0000 MG: updated licenses git-svn-id: trunk@1668 -aruna@debian:/media/aruna/linux-next/lazarus$
So I am guessing the commit I must go back to is commit 95ca76e85edc433d7d03f14daf28aafbcd92fa36 Author: mattias <nc-gaertnma@netcologne.de> Date: Sat Oct 1 00:38:04 2005 +0000 ?
Navigation
[0] Message Index
[#] Next page
[*] Previous page