Forum > Debugger
FpDebug, small x86 disassembler bug
Bogen85:
--- Quote from: Martin_fr on December 02, 2022, 03:19:58 am ---Fixed
--- End quote ---
Fixed, as in, fixed in the source code? If so, what is the issue tracker number for this?
I did not know this existed for FPC (disassembly functions), though due to this Topic I now see that it is the Lazarus sources.
Martin_fr:
--- Quote from: Bogen85 on December 02, 2022, 09:49:51 pm ---
--- Quote from: Martin_fr on December 02, 2022, 03:19:58 am ---Fixed
--- End quote ---
Fixed, as in, fixed in the source code? If so, what is the issue tracker number for this?
--- End quote ---
The commit is 4c879cc73cc403526099b3eadde64c03c9a82f31
There is no bug tracker id, since - as you may have read - the reporter did not want to create an account to the tracker.
Which means, it is lucky I got time now. Otherwise it might easily have been forgotten.
- "Time" just doesn't mean the 30 seconds to change one word, and commit it.
- "Time" means everything from checking that this is currently wrong, and that the suggest disassemble is the correct one. We are all humans, the reporter could have mis-reported too. Then checking that the changed line returns the new desired value. Checking desired, current, and fixed results for other op-sizes (which would be expected to exist). So "Time" amounts. And had I been in the middle of something else, I might not have interrupted that (even if that be a project taking a few month).
--- Quote ---I did not know this existed for FPC (disassembly functions), though due to this Topic I now see that it is the Lazarus sources.
--- End quote ---
They exist in Lazarus => FpDebug. Since the debugger should be able to display disassembly.
Bogen85:
--- Quote from: Martin_fr on December 02, 2022, 10:07:12 pm ---The commit is 4c879cc73cc403526099b3eadde64c03c9a82f31
There is no bug tracker id, since - as you may have read - the reporter did not want to create an account to the tracker.
Which means, it is lucky I got time now. Otherwise it might easily have been forgotten.
--- End quote ---
Got it!
I understand.
--- Quote from: Martin_fr on December 02, 2022, 10:07:12 pm ---They exist in Lazarus => FpDebug. Since the debugger should be able to display disassembly.
--- End quote ---
Thanks!
Per the code in the reporter's example this will be useful to me in non-gui programs.
Martin_fr:
Btw, if anyone has spare time....
--- Quote from: mika on November 30, 2022, 11:47:14 pm ---But if some one is going to investigate this, then look at lds,les,.. instructions with operand and address size modifiers.
--- End quote ---
This indicates that there may or may not be other similar cases.
But I don't have time to verify this currently.
Navigation
[0] Message Index
[*] Previous page