EZDatabaseError with postgres

[Root2]

I am trying to save data to postgres from tedit the code I am using is this:

Code: Pascal  [Select][+][-]

1. procedure TForm1.Button3Click(Sender: TObject);
2. begin
3.   ZQuery1.Close;
4.   ZQuery1.SQL.Clear;
5.   ZQuery1.SQL.Add('insert into tdatostag (dirtag,valortagint,valortagnum,nombretag,tipodato)');
6.   ZQuery1.SQL.Add('values (:dirtag,:valortagint,:valortagnum,:nombretag,:tipodato)');
7.   ZQuery1.Params.ParamByName('dirtag').AsString:=Edit1.Text;
8.   ZQuery1.Params.ParamByName('valortagint').AsString:=Edit2.Text;
9.   ZQuery1.Params.ParamByName('valortagnum').AsString:=Edit3.Text;
10.   ZQuery1.Params.ParamByName('nombretag').AsString:=Edit4.Text;
11.   ZQuery1.Params.ParamByName('tipodato').AsString:=Edit5.Text;
12.   ZQuery1.ExecSQL;
13.   ZQuery1.Open;
14. end;  
15.  

When compiling it does not give me any error, but when I press on the save button it gives me error:

The project has thrown an exception 'EZDatabaseError' with the message: Can not open a Resulset.

Structure of table.
dirtag      int4      not null
valortagint   int4      not null
valortagnum   numeric   not null
nombretag   bpchar   not null
tipodato           bpchar   not null

Thank you very much for your kind attention.

Regards.

[marcov]

It seems to be a bug but you can work around it by using a returning statement. See

https://sourceforge.net/p/zeoslib/tickets/492/

[dseligo]

Just comment out line 13:

Code: Pascal  [Select][+][-]

1. // ZQuery1.Open;

[Zvoni]

You're trying to Open a ZQuery, which underlyings SQL-Command is an Insert.....
Now what's wrong with that?

[gucao]

I guess you need to return the generated data, do like this:

Code: Pascal  [Select][+][-]

1. procedure TForm1.Button3Click(Sender: TObject);
2. begin
3.   ZQuery1.Close;
4.   ZQuery1.SQL.Clear;
5.   ZQuery1.SQL.Add('insert into tdatostag (dirtag,valortagint,valortagnum,nombretag,tipodato)');
6.   ZQuery1.SQL.Add('values (:dirtag,:valortagint,:valortagnum,:nombretag,:tipodato)');
7.   ZQuery1.SQL.Add('RETURNING *'); //<<----add this line
8.   ZQuery1.Params.ParamByName('dirtag').AsString:=Edit1.Text;
9.   ZQuery1.Params.ParamByName('valortagint').AsString:=Edit2.Text;
10.   ZQuery1.Params.ParamByName('valortagnum').AsString:=Edit3.Text;
11.   ZQuery1.Params.ParamByName('nombretag').AsString:=Edit4.Text;
12.   ZQuery1.Params.ParamByName('tipodato').AsString:=Edit5.Text;
13.   //ZQuery1.ExecSQL; //<<----delete this line
14.   ZQuery1.Open;
15. end;
16.  

Please do not forget commit.

[Root2]

Thank you very much for the help, Gucao your solution works perfectly, I was also testing removing only "ZQuery1.Open;" and saved without problems, now in this part I have the following question this affects somehow to the transaction? or is it necessary to include this line, I ask this because I will have to save a lot of data in this way approximately 200 data at once which leads me to the following question this method of saving data is the most optimal to save large amounts of data? or can somehow improve this procedure.

Please excuse me if I am abusing your kindness.

Regards.

[gucao]

I was also testing removing only "ZQuery1.Open;" and saved without problems,

This means that you don't need the postgresql to return the generated data,Just do it, like dseligo's said.

this affects somehow to the transaction?

no

or is it necessary to include this line,

if you only save data to postgresql,Please delete the  "ZQuery1.Open;" and keep the  "ZQuery1.ExecSQL;" and you don't need "RETURNING *".

"RETURNING *" Is used to tell postgresql to return the generated data to you application.