Recent

Author Topic: 2.2.2 Win x64: Listview in virtual mode: 3 good fixes are not in there  (Read 354 times)

d7_2_laz

  • Sr. Member
  • ****
  • Posts: 271
If I ever had a problem with Lazarus in the last few months. then exclusively with listview in virtual mode. But here heavily.  Fortunately all had been sorted out meanwhile.
The last remaining three issues imo had been fixed perfectly within LazMain (great thanks again wp for you attention!).

Unfortunately those valuable fixes didn't find their way into the 2.2.2   :'(

LCL/TListView: More complete fix of issue #39708, based on patch by d7_2_laz...
https://gitlab.com/freepascal.org/lazarus/lazarus/-/commit/c0c30424debbd95c58fc9e8b98293dba55292d12

LCL/Listview: Fix listview jumping to first item when a key is pressed in virtual mode, issue #39715..
https://gitlab.com/freepascal.org/lazarus/lazarus/-/commit/d3396e9fa0a410cbebf9406812979b64ec1c430a

LCL/ListView: implement incremental search in virtual mode for Windows. Issue #39748.
https://gitlab.com/freepascal.org/lazarus/lazarus/-/commit/0883c8c5249a41a01a388275327225ef012c2e3e

What went wrong, or do I misunderstand something?

wp

  • Hero Member
  • *****
  • Posts: 9736
TListView has seen a lot of changes and reverts, in particular #39708, over a long time and done by several developers. Simply merging the last fix would not have worked, and therefore, I had planned to wait for the next new feature release, v2.4.

The other two would have worked in 2.2.2, but I simply added the commits to the mergelist too late, and therefore they were postponed to v2.2.4 (they are included in the current fixes branch now). Sorry.
Mainly Lazarus trunk / fpc 3.2.0 / all 32-bit on Win-10, but many more...

d7_2_laz

  • Sr. Member
  • ****
  • Posts: 271
Ok wp, thank you for this information!

I just went back to check for others:
Virtual listview, MultiSelect: early reference to Selected object may cause performace problems
https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/39324
--resp:
Listview selected items in virtualmode
https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/39693
and did see that for the latter one the Milestone had been set to 2.4.1

But i noticed that this guy did reappear:
Virtual listview, MultiSelect: problem: only one item in the list: after click on empty space this single item keeps to stay selected
https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/39325

So, for a better understanding, would it be the best for persons (like me) that are interested in those patches to wait for 2.2.4  (maybe 2.4?) and to keep using the LazMain extract meanwhile?
(Wouldn't be a problem, because this version got rid of the listview issues ... it's only for to know).


wp

  • Hero Member
  • *****
  • Posts: 9736
Listview selected items in virtualmode
https://gitlab.com/freepascal.org/lazarus/lazarus/-/issues/39693
and did see that for the latter one the Milestone had been set to 2.4.1
I only see milestone 2.4 ...

So, for a better understanding, would it be the best for persons (like me) that are interested in those patches to wait for 2.2.4  (maybe 2.4?) and to keep using the LazMain extract meanwhile?
I have no idea when v2.4 will be released, but I guess you'll have to wait for it for a while.

You'll also have to wait for v2.2.4 (I even don't know if it ever will be released because the team may decide to go to v2.4 immediately). But that what once will be v2.2.4 is evolving every day in the fixes branch. So, when you install the fixes branch you'll get a live preview of v2.2.4. (see below)

Of course you can continue to work with your manually patched LazMain extract for yourself. However, when you report bugs, it will be quite difficult for us to follow because your exact version only exists on your computer, and there is some chance that we don't reckognize your committed code, or the bug even may already have been fixed and you did not notice it.

It is really not difficult to install the main or fixes branch: Install TortoiseGit, get the Lazarus/main or fixes git url and clone it to your disk using TortoiseGit. Then go to the download directory, add a file Lazarus.cfg containing the line "--primary-config-path=<path to your config directory>" (the config dir must not be used by any other installation). Then execute "make bigide" from a batch file in which you first set the system path to the fpc binary folder of your Laz 2.2.0 or 2.2.2 installation). When the IDE is ready and has started you are asked where to find the compiler and debugger (use those from your Laz 2.2.0 or 2.2.2). Install the components that you use. Ready. Due to the primary-config-path this installation is completely independent of any other Lazarus installation.
Mainly Lazarus trunk / fpc 3.2.0 / all 32-bit on Win-10, but many more...

d7_2_laz

  • Sr. Member
  • ****
  • Posts: 271
Yes, basically that are  the steps i did follow for to create the separate laz-git installation. No manual patches, but i do the clone refresh only when necessary.
Because actually i'm mainly working on that, as it perfectly fullfills the needs. So far everything is fine.
The important thing is that the fixes will be integrated in an official release at a later time, may it be 2.2.4 or even 2.4.

Thank you a lot for having clarified wp!

 

TinyPortal © 2005-2018