Recent

Author Topic: Code Typhoon's pl_TitanSound - is it legal?  (Read 2661 times)

domasz

  • Sr. Member
  • ****
  • Posts: 434
Code Typhoon's pl_TitanSound - is it legal?
« on: March 08, 2022, 12:38:52 pm »
There is a package pl_TitanSound in Code Typhoon which contains file tsd_mpeg.pas. This looks exactly like Delphi MPEG:
https://sourceforge.net/projects/delphimpeg/
Even the comments are the same but TitanSound is MPL and delphi MPEG is GNU/GPL. I tried asking about it on their forum but they claim they wrote TitanSound.

Can anyone clarify this situation? Because right now it seems Code Typhoon is risky to use.

domasz

  • Sr. Member
  • ****
  • Posts: 434
Re: Code Typhoon's pl_TitanSound - is it legal?
« Reply #1 on: March 08, 2022, 12:41:15 pm »
Files so you can compare yourself.
Layer3.pas is one of many files from Delphi MPEG.
tsd_mpeg.pas seems to be concatenation of all Delphi MPEG files; from Code Typhoon.

https://github.com/Dingo64/Delphi-MPEG/blob/main/Layer3.pas
« Last Edit: March 08, 2022, 02:13:28 pm by domasz »

PascalDragon

  • Hero Member
  • *****
  • Posts: 5462
  • Compiler Developer
Re: Code Typhoon's pl_TitanSound - is it legal?
« Reply #2 on: March 08, 2022, 01:20:48 pm »
Can anyone clarify this situation? Because right now it seems Code Typhoon is risky to use.

Wouldn't be the first time. They like to replace license headers. I personally wouldn't use Code Typhoon no matter the advantages and won't suggest it to anyone else either.

Martin_fr

  • Administrator
  • Hero Member
  • *
  • Posts: 9856
  • Debugger - SynEdit - and more
    • wiki
Re: Code Typhoon's pl_TitanSound - is it legal?
« Reply #3 on: March 08, 2022, 01:40:14 pm »
I removed the attachments. If there is a suspicion that they may be copyrighted, then we should err or the save side. That is => We should not host them ourself in any form or way.

EDIT: Argh, I wast to fast. I did not read that Delphi's file are open-source too.
« Last Edit: March 08, 2022, 01:50:55 pm by Martin_fr »

domasz

  • Sr. Member
  • ****
  • Posts: 434
Re: Code Typhoon's pl_TitanSound - is it legal?
« Reply #4 on: March 08, 2022, 01:51:54 pm »
Delphi MPEG is GNU/GPL. Worst case scenario TitanSound needs to be re-licensed as GNU/GPL. So I think it's safe to host the files.

Martin_fr

  • Administrator
  • Hero Member
  • *
  • Posts: 9856
  • Debugger - SynEdit - and more
    • wiki
Re: Code Typhoon's pl_TitanSound - is it legal?
« Reply #5 on: March 08, 2022, 02:11:21 pm »
Delphi MPEG is GNU/GPL. Worst case scenario TitanSound needs to be re-licensed as GNU/GPL. So I think it's safe to host the files.
Yes, I realized it to late. Hence the "edit" of my previous post.

440bx

  • Hero Member
  • *****
  • Posts: 4014
Re: Code Typhoon's pl_TitanSound - is it legal?
« Reply #6 on: March 08, 2022, 03:38:56 pm »
They like to replace license headers.
People/organizations that do that just cannot be trusted.

It's not that hard to give credit to those who earned it.

(FPC v3.0.4 and Lazarus 1.8.2) or (FPC v3.2.2 and Lazarus v3.2) on Windows 7 SP1 64bit.

domasz

  • Sr. Member
  • ****
  • Posts: 434
Re: Code Typhoon's pl_TitanSound - is it legal?
« Reply #7 on: March 08, 2022, 05:43:56 pm »
I asked about this on Code Typhoon's forum and now I am banned there.
I really hoped they will give an explanation for the TitanSound but seems they are not going to.

Warfley

  • Hero Member
  • *****
  • Posts: 1499
Re: Code Typhoon's pl_TitanSound - is it legal?
« Reply #8 on: March 08, 2022, 06:05:37 pm »
I did a quick check using the diff util:
Code: Bash  [Select][+][-]
  1. $> diff Layer3.pas tsd_mpeg.pas | grep -e '^<' | wc -l
  2. 591
  3.  
So out of the 1301 lines of the Layer3.pas, 710 where taken verbatim and in order.
When removing spaces (to find similar lines with different spacing or indentation):
Code: Bash  [Select][+][-]
  1. $> diff Layer3_nospace.pas tsd_mpeg_nospace.pas | grep -e '^<' | wc -l
  2. 503
  3.  
It is 798 out of 1301, so around 61%

As diff considers order, I also sorted the lines, to check just for lines occuring in both:
Code: Bash  [Select][+][-]
  1. $> diff Layer3_nospace_sorted.pas tsd_mpeg_nospace_sorted | grep -e '^<' | wc -l
  2. 490
  3.  
It increases to 811. But this is a little bit unfair as it includes empty lines, so after removing them with sort -u:
Code: Bash  [Select][+][-]
  1. $> diff Layer3_nospace_sorted.pas tsd_mpeg_nospace_sorted | grep -e '^<' | wc -l
  2. 374
  3. $> wc -l Layer3_nospace_sorted.pas
  4. 768 Layer3_nospace_sorted.pas
  5.  
It is 394 out of 768 lines, which is 51%

So it is either around half or nearly 2/3 of the Delphi code, which is also present in the pilot logic code.

To answer the question about legality, well, there is this neat saying: "No plaintiff, no judge". So unless someone is actually going to try legal action, does it really matter?

PS: about how to read the diff | grep | wc results, the number in the end is the number of lines that where in the Layer3 but not in the tsd file, so the number of lines in both is the total minus that number
« Last Edit: March 08, 2022, 06:09:34 pm by Warfley »

JuhaManninen

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 4467
  • I like bugs.
Re: Code Typhoon's pl_TitanSound - is it legal?
« Reply #9 on: March 08, 2022, 06:11:45 pm »
Wouldn't be the first time. They like to replace license headers.
AFAIK they did not replace license headers despite such false claims. At least they didn't then few years ago when there was a big attack against them here in Lazarus forum.
They had removed author/ copyright information from some 3rd party component packages which was a stupid move of course in a situation where many people wanted to bash them.
Anyway, back then I went through their copy of Lazarus IDE and packages and found nothing to complain.

They have changed most 3rd party package and unit names which shows lack of cooperation but it is not against license rules.

Did they now change the license for pl_TitanSound? It sounds bad of course.
« Last Edit: March 08, 2022, 06:15:55 pm by JuhaManninen »
Mostly Lazarus trunk and FPC 3.2 on Manjaro Linux 64-bit.

domasz

  • Sr. Member
  • ****
  • Posts: 434
Re: Code Typhoon's pl_TitanSound - is it legal?
« Reply #10 on: March 08, 2022, 06:57:04 pm »
So it is either around half or nearly 2/3 of the Delphi code, which is also present in the pilot logic code.
"Delphi MPEG" is in Delphi, which a bit different dialect.

af0815

  • Hero Member
  • *****
  • Posts: 1291
Re: Code Typhoon's pl_TitanSound - is it legal?
« Reply #11 on: March 08, 2022, 07:04:04 pm »
It depends on the used compilermode. If you use mode delphi it is compatible. You find the mode normaly defined in first lines
regards
Andreas

korba812

  • Sr. Member
  • ****
  • Posts: 394
Re: Code Typhoon's pl_TitanSound - is it legal?
« Reply #12 on: March 28, 2022, 08:04:13 pm »
To me, both sources look like a port of some c code to pascal. On the delphimpeg SF site it says that this is Delphi port of "maplay"
See example results on github:
https://github.com/search?p=1&q=prvblk&type=Code
There are tons of similar code in different languages with identical variable names and comments.

domasz

  • Sr. Member
  • ****
  • Posts: 434
Re: Code Typhoon's pl_TitanSound - is it legal?
« Reply #13 on: March 28, 2022, 09:46:04 pm »
But maplay is GNU/GPL so everything based on maplay (that includes translations) is GNU/GPL.

korba812

  • Sr. Member
  • ****
  • Posts: 394
Re: Code Typhoon's pl_TitanSound - is it legal?
« Reply #14 on: March 28, 2022, 10:43:41 pm »
You're right. I found maplayer source and it is GPL licensed.
https://hwiegman.home.xs4all.nl/fileformats/mp3/mp1A_src/

 

TinyPortal © 2005-2018