Lazarus
Home
Help
TinyPortal
Search
Login
Register
Lazarus
»
Forum
»
Free Pascal
»
General
(Moderators:
FPK
,
Tomas Hajny
) »
optimization will generate wrong result
Free Pascal
Website
Downloads
Wiki
Documentation
Bugtracker
Mailing List
Lazarus
Website
Downloads (Laz+FPC)
Packages (OPM)
FAQ
Wiki
Documentation (RTL/FCL/LCL)
Bugtracker
CCR Bugs
IRC channel
GIT
Mailing List
Other languages
Foundation
Website
Useful Wiki Links
Project Roadmap
Getting the Source
Screenshots
How to use the forum
About donations (wiki)
Bookstore
Computer Math and Games in Pascal
(preview)
Lazarus Handbook
Search
Advanced search
Recent
Forum slow
by
Curt Carpenter
[
Today
at 03:41:07 am]
Arabic text, problem on L...
by
Zaher
[
Today
at 03:29:16 am]
InstallAware Using Lazaru...
by
TRon
[
Today
at 02:55:41 am]
Generics - correct syntax
by
Blaazen
[
Today
at 01:57:40 am]
Demoscene The Champs Crac...
by
Gigatron
[
Today
at 01:05:16 am]
How to use the Event Log?
by
n7800
[
Today
at 12:47:25 am]
v3.99 code completion que...
by
440bx
[
Today
at 12:45:55 am]
FpDebug breakpoint on "be...
by
440bx
[
Today
at 12:36:23 am]
Access violation when re-...
by
TRon
[April 19, 2024, 11:44:51 pm]
[solved] how to get class...
by
jamie
[April 19, 2024, 11:34:44 pm]
Lazarus for Windows on aa...
by
Wallaby
[April 19, 2024, 10:52:25 pm]
Poll: Watches and Display...
by
440bx
[April 19, 2024, 07:13:51 pm]
Who is Indy mattias?
by
paweld
[April 19, 2024, 04:17:53 pm]
I just released a commerc...
by
BrassGear
[April 19, 2024, 03:17:28 pm]
Does anyone know why thes...
by
Laksen
[April 19, 2024, 03:04:14 pm]
Database standards OR Am ...
by
gidesa
[April 19, 2024, 02:37:56 pm]
How to: create DLL file f...
by
TRon
[April 19, 2024, 02:26:53 pm]
A fairly simple sound sol...
by
paweld
[April 19, 2024, 01:46:11 pm]
Access violation when ope...
by
Чебурашка
[April 19, 2024, 12:27:34 pm]
Step-into the field sette...
by
Martin_fr
[April 19, 2024, 11:31:48 am]
AI, NLP and CAI: Text Gen...
by
Dzandaa
[April 19, 2024, 11:03:26 am]
dwindows for Android
by
PierceNg
[April 19, 2024, 10:54:44 am]
create system unit from s...
by
Laksen
[April 19, 2024, 10:53:57 am]
[Solved] Find child contr...
by
Joanna
[April 19, 2024, 09:53:43 am]
FpDebug unexpected Assemb...
by
Marc
[April 19, 2024, 08:46:38 am]
« previous
next »
Print
Pages: [
1
]
Author
Topic: optimization will generate wrong result (Read 1154 times)
powerpcer
Full Member
Posts: 100
optimization will generate wrong result
«
on:
May 11, 2021, 06:26:08 pm »
for function below, if i change the optimization to -O2, the result will be wrong 11, the correct one is 18.
i test this code on win10 x64
Code: Pascal
[Select]
[+]
[-]
function
edit_distance_bit
(
str1
,
str2
:
string
)
:
integer
;
var
Peq
:
array
[
0
..
255
]
of
Uint64
;
Pv
,
Eq
,
Xv
,
Xh
,
Ph
,
Mh
,
Mv
,
ONE
:
Uint64
;
i
,
j
,
m
,
n
,
Score
:
integer
;
p1
,
p2
:
pbyte
;
s
:
string
;
begin
if
(
length
(
str1
)
< length
(
str2
)
)
then
begin
p1
:
=
@
str2
[
1
]
;
p2
:
=
@
str1
[
1
]
;
m
:
=
length
(
str2
)
;
n
:
=
length
(
str1
)
;
end
else
begin
p1
:
=
@
str1
[
1
]
;
p2
:
=
@
str2
[
1
]
;
m
:
=
length
(
str1
)
;
n
:
=
length
(
str2
)
;
end
;
ONE
:
=
1
;
fillbyte
(
Peq
,
0
,
sizeof
(
Peq
)
)
;
Mv
:
=
0
;
Score
:
=
m
;
for
i
:
=
0
to
m
do
begin
Peq
[
p1
[
i
]
]
:
=
Peq
[
p1
[
i
]
]
or
ONE
shl
i
;
Pv
:
=
Pv
or
(
ONE
shl
i
)
;
end
;
for
j
:
=
0
to
n
do
begin
Eq
:
=
Peq
[
p2
[
j
]
]
;
Xv
:
=
Eq
or
Mv
;
Xh
:
=
(
(
(
Eq
and
Pv
)
+
Pv
)
xor
Pv
)
or
Eq
;
Ph
:
=
Mv
or
(
not
(
Xh
or
Pv
)
)
;
Mh
:
=
Pv
and
Xh
;
if
(
Ph
and
(
ONE
shl
(
m
-
1
)
)
)
<>
0
then
inc
(
Score
)
else
if
(
Mh
and
(
ONE
shl
(
m
-
1
)
)
)
<>
0
then
dec
(
Score
)
;
Ph
:
=
Ph
shl
ONE
;
Pv
:
=
(
Mh
shl
ONE
)
or
(
not
(
Xv
or
Ph
)
)
;
Mv
:
=
Ph
and
Xv
;
end
;
result
:
=
Score
;
end
;
with testing code
Code: Pascal
[Select]
[+]
[-]
j
:
=
edit_distance_bit
(
'agtcaaaagtcagtcagtcagtcagtcacagtcagaaggcatccaaccga'
,
'ccgttagtcagaaacagtcagtcagtcagtcagtccagtcttaggcccgga'
)
;
Logged
AlexTP
Hero Member
Posts: 2402
Re: optimization will generate wrong result
«
Reply #1 on:
May 11, 2021, 06:31:05 pm »
FPC 3.2 fixes; Linux x64.
-O0: 14
-O1: 14
-O2: 16
Logged
CudaText editor
-
ATSynEdit
-
More from me
bytebites
Hero Member
Posts: 640
Re: optimization will generate wrong result
«
Reply #2 on:
May 11, 2021, 06:42:33 pm »
Code: Pascal
[Select]
[+]
[-]
fillbyte
(
Peq
,
0
,
sizeof
(
Peq
)
)
;
Your code is wrong. The second argument of fillchar is count, the last is value.
Code: Pascal
[Select]
[+]
[-]
Pv
:
=
Pv
or
(
ONE
shl
i
)
;
Pv is not initialised.
Logged
powerpcer
Full Member
Posts: 100
Re: optimization will generate wrong result
«
Reply #3 on:
May 12, 2021, 03:13:23 am »
thanks,
after fixed, -O3 optimize faster little, from 40ms to 30ms
«
Last Edit: May 12, 2021, 03:18:01 am by powerpcer
»
Logged
Print
Pages: [
1
]
« previous
next »
Lazarus
»
Forum
»
Free Pascal
»
General
(Moderators:
FPK
,
Tomas Hajny
) »
optimization will generate wrong result
TinyPortal
© 2005-2018