Lazarus
Home
Help
TinyPortal
Search
Login
Register
Lazarus
»
Forum
»
Free Pascal
»
General
(Moderators:
FPK
,
Tomas Hajny
) »
optimization will generate wrong result
Free Pascal
Website
Downloads
Wiki
Documentation
Bugtracker
Mailing List
Lazarus
Website
Downloads (Laz+FPC)
Packages (OPM)
FAQ
Wiki
Documentation (RTL/FCL/LCL)
Bugtracker
CCR Bugs
IRC channel
GIT
Mailing List
Other languages
Foundation
Website
Useful Wiki Links
Project Roadmap
Getting the Source
Screenshots
How to use the forum
About donations (wiki)
Bookstore
Computer Math and Games in Pascal
(preview)
Lazarus Handbook
Search
Advanced search
Recent
what to do if my target M...
by
Key-Real
[
Today
at 02:02:29 pm]
create system unit from s...
by
KodeZwerg
[
Today
at 02:02:25 pm]
[Solved] Find child contr...
by
Joanna
[
Today
at 01:57:59 pm]
How to get along with the...
by
marcov
[
Today
at 01:57:34 pm]
lazarus-project_3.2.0-0_a...
by
dbannon
[
Today
at 01:46:43 pm]
Spiral of Theodorus: Reve...
by
Roland57
[
Today
at 01:24:14 pm]
I just released a commerc...
by
BrassGear
[
Today
at 01:20:51 pm]
InstallAware Using Lazaru...
by
dbannon
[
Today
at 01:05:38 pm]
Improvement of TFPTimerTh...
by
lagprogramming
[
Today
at 12:53:29 pm]
Assign (textfile) not com...
by
Thaddy
[
Today
at 12:18:09 pm]
Question for people who h...
by
marcov
[
Today
at 12:04:56 pm]
[SOLVED] assembler name i...
by
Laksen
[
Today
at 11:40:43 am]
Warning: Source OS Redefi...
by
Laksen
[
Today
at 11:32:46 am]
[SOLVED] how to see what ...
by
Laksen
[
Today
at 11:30:25 am]
Slow copying of small str...
by
alpine
[
Today
at 11:25:10 am]
How to: create DLL file f...
by
KodeZwerg
[
Today
at 10:53:20 am]
Text orientation in TMemo...
by
wp
[
Today
at 10:27:54 am]
Linux Workspaces -- StayO...
by
AmatCoder
[
Today
at 08:21:27 am]
Demoscene The Champs Crac...
by
Lulu
[
Today
at 08:15:12 am]
Azure sql database will n...
by
paweld
[
Today
at 07:24:47 am]
location of non visual co...
by
VisualLab
[April 17, 2024, 11:58:55 pm]
For-in loop over constant...
by
Joanna
[April 17, 2024, 11:57:15 pm]
Lazarus editor feature re...
by
440bx
[April 17, 2024, 11:49:08 pm]
How would you define a fi...
by
wp
[April 17, 2024, 11:04:00 pm]
Directx9 with mylogo insi...
by
KodeZwerg
[April 17, 2024, 11:03:54 pm]
« previous
next »
Print
Pages: [
1
]
Author
Topic: optimization will generate wrong result (Read 1148 times)
powerpcer
Full Member
Posts: 100
optimization will generate wrong result
«
on:
May 11, 2021, 06:26:08 pm »
for function below, if i change the optimization to -O2, the result will be wrong 11, the correct one is 18.
i test this code on win10 x64
Code: Pascal
[Select]
[+]
[-]
function
edit_distance_bit
(
str1
,
str2
:
string
)
:
integer
;
var
Peq
:
array
[
0
..
255
]
of
Uint64
;
Pv
,
Eq
,
Xv
,
Xh
,
Ph
,
Mh
,
Mv
,
ONE
:
Uint64
;
i
,
j
,
m
,
n
,
Score
:
integer
;
p1
,
p2
:
pbyte
;
s
:
string
;
begin
if
(
length
(
str1
)
< length
(
str2
)
)
then
begin
p1
:
=
@
str2
[
1
]
;
p2
:
=
@
str1
[
1
]
;
m
:
=
length
(
str2
)
;
n
:
=
length
(
str1
)
;
end
else
begin
p1
:
=
@
str1
[
1
]
;
p2
:
=
@
str2
[
1
]
;
m
:
=
length
(
str1
)
;
n
:
=
length
(
str2
)
;
end
;
ONE
:
=
1
;
fillbyte
(
Peq
,
0
,
sizeof
(
Peq
)
)
;
Mv
:
=
0
;
Score
:
=
m
;
for
i
:
=
0
to
m
do
begin
Peq
[
p1
[
i
]
]
:
=
Peq
[
p1
[
i
]
]
or
ONE
shl
i
;
Pv
:
=
Pv
or
(
ONE
shl
i
)
;
end
;
for
j
:
=
0
to
n
do
begin
Eq
:
=
Peq
[
p2
[
j
]
]
;
Xv
:
=
Eq
or
Mv
;
Xh
:
=
(
(
(
Eq
and
Pv
)
+
Pv
)
xor
Pv
)
or
Eq
;
Ph
:
=
Mv
or
(
not
(
Xh
or
Pv
)
)
;
Mh
:
=
Pv
and
Xh
;
if
(
Ph
and
(
ONE
shl
(
m
-
1
)
)
)
<>
0
then
inc
(
Score
)
else
if
(
Mh
and
(
ONE
shl
(
m
-
1
)
)
)
<>
0
then
dec
(
Score
)
;
Ph
:
=
Ph
shl
ONE
;
Pv
:
=
(
Mh
shl
ONE
)
or
(
not
(
Xv
or
Ph
)
)
;
Mv
:
=
Ph
and
Xv
;
end
;
result
:
=
Score
;
end
;
with testing code
Code: Pascal
[Select]
[+]
[-]
j
:
=
edit_distance_bit
(
'agtcaaaagtcagtcagtcagtcagtcacagtcagaaggcatccaaccga'
,
'ccgttagtcagaaacagtcagtcagtcagtcagtccagtcttaggcccgga'
)
;
Logged
AlexTP
Hero Member
Posts: 2401
Re: optimization will generate wrong result
«
Reply #1 on:
May 11, 2021, 06:31:05 pm »
FPC 3.2 fixes; Linux x64.
-O0: 14
-O1: 14
-O2: 16
Logged
CudaText editor
-
ATSynEdit
-
More from me
bytebites
Hero Member
Posts: 640
Re: optimization will generate wrong result
«
Reply #2 on:
May 11, 2021, 06:42:33 pm »
Code: Pascal
[Select]
[+]
[-]
fillbyte
(
Peq
,
0
,
sizeof
(
Peq
)
)
;
Your code is wrong. The second argument of fillchar is count, the last is value.
Code: Pascal
[Select]
[+]
[-]
Pv
:
=
Pv
or
(
ONE
shl
i
)
;
Pv is not initialised.
Logged
powerpcer
Full Member
Posts: 100
Re: optimization will generate wrong result
«
Reply #3 on:
May 12, 2021, 03:13:23 am »
thanks,
after fixed, -O3 optimize faster little, from 40ms to 30ms
«
Last Edit: May 12, 2021, 03:18:01 am by powerpcer
»
Logged
Print
Pages: [
1
]
« previous
next »
Lazarus
»
Forum
»
Free Pascal
»
General
(Moderators:
FPK
,
Tomas Hajny
) »
optimization will generate wrong result
TinyPortal
© 2005-2018