Lazarus
Home
Help
TinyPortal
Search
Login
Register
Lazarus
»
Forum
»
Free Pascal
»
General
(Moderators:
FPK
,
Tomas Hajny
) »
optimization will generate wrong result
Free Pascal
Website
Downloads
Wiki
Documentation
Bugtracker
Mailing List
Lazarus
Website
Downloads (Laz+FPC)
Packages (OPM)
FAQ
Wiki
Documentation (RTL/FCL/LCL)
Bugtracker
CCR Bugs
IRC channel
GIT
Mailing List
Other languages
Foundation
Website
Useful Wiki Links
Project Roadmap
Getting the Source
Screenshots
How to use the forum
About donations (wiki)
Bookstore
Computer Math and Games in Pascal
(preview)
Lazarus Handbook
Search
Advanced search
Recent
Find child controls by na...
by
Handoko
[
Today
at 04:17:05 am]
Demoscene The Champs Crac...
by
Gigatron
[
Today
at 02:26:07 am]
Linux Workspaces -- StayO...
by
dbannon
[
Today
at 02:13:13 am]
Assign (textfile) not com...
by
teresa
[
Today
at 01:56:13 am]
How to: create DLL file f...
by
KodeZwerg
[
Today
at 12:57:56 am]
Slow copying of small str...
by
jamie
[
Today
at 12:37:04 am]
location of non visual co...
by
VisualLab
[April 17, 2024, 11:58:55 pm]
For-in loop over constant...
by
Joanna
[April 17, 2024, 11:57:15 pm]
Lazarus editor feature re...
by
440bx
[April 17, 2024, 11:49:08 pm]
InstallAware Using Lazaru...
by
VisualLab
[April 17, 2024, 11:08:24 pm]
How would you define a fi...
by
wp
[April 17, 2024, 11:04:00 pm]
Directx9 with mylogo insi...
by
KodeZwerg
[April 17, 2024, 11:03:54 pm]
Lazarus for Windows on aa...
by
Wallaby
[April 17, 2024, 10:25:46 pm]
Azure sql database will n...
by
dseligo
[April 17, 2024, 10:15:27 pm]
[SOLVED] TDbf table, Leve...
by
1HuntnMan
[April 17, 2024, 10:03:16 pm]
Doomed name
by
Martin_fr
[April 17, 2024, 09:09:52 pm]
lazarus-project_3.2.0-0_a...
by
midigark
[April 17, 2024, 06:09:40 pm]
Text orientation in TMemo...
by
wp
[April 17, 2024, 05:51:25 pm]
TBGRABitmap.TextSize retu...
by
circular
[April 17, 2024, 05:24:04 pm]
BUG REPORT: Unable to gen...
by
gasensor
[April 17, 2024, 05:10:20 pm]
[solved]FP IDE(FP.exe) fa...
by
gasensor
[April 17, 2024, 04:45:40 pm]
Inherits forms and releas...
by
ASerge
[April 17, 2024, 03:37:45 pm]
The weird Rewrite bug
by
Kays
[April 17, 2024, 01:23:40 pm]
FpDebug unexpected Assemb...
by
440bx
[April 17, 2024, 12:54:43 pm]
Arabic text, problem on L...
by
Zaher
[April 17, 2024, 12:34:05 pm]
« previous
next »
Print
Pages: [
1
]
Author
Topic: optimization will generate wrong result (Read 1146 times)
powerpcer
Full Member
Posts: 100
optimization will generate wrong result
«
on:
May 11, 2021, 06:26:08 pm »
for function below, if i change the optimization to -O2, the result will be wrong 11, the correct one is 18.
i test this code on win10 x64
Code: Pascal
[Select]
[+]
[-]
function
edit_distance_bit
(
str1
,
str2
:
string
)
:
integer
;
var
Peq
:
array
[
0
..
255
]
of
Uint64
;
Pv
,
Eq
,
Xv
,
Xh
,
Ph
,
Mh
,
Mv
,
ONE
:
Uint64
;
i
,
j
,
m
,
n
,
Score
:
integer
;
p1
,
p2
:
pbyte
;
s
:
string
;
begin
if
(
length
(
str1
)
< length
(
str2
)
)
then
begin
p1
:
=
@
str2
[
1
]
;
p2
:
=
@
str1
[
1
]
;
m
:
=
length
(
str2
)
;
n
:
=
length
(
str1
)
;
end
else
begin
p1
:
=
@
str1
[
1
]
;
p2
:
=
@
str2
[
1
]
;
m
:
=
length
(
str1
)
;
n
:
=
length
(
str2
)
;
end
;
ONE
:
=
1
;
fillbyte
(
Peq
,
0
,
sizeof
(
Peq
)
)
;
Mv
:
=
0
;
Score
:
=
m
;
for
i
:
=
0
to
m
do
begin
Peq
[
p1
[
i
]
]
:
=
Peq
[
p1
[
i
]
]
or
ONE
shl
i
;
Pv
:
=
Pv
or
(
ONE
shl
i
)
;
end
;
for
j
:
=
0
to
n
do
begin
Eq
:
=
Peq
[
p2
[
j
]
]
;
Xv
:
=
Eq
or
Mv
;
Xh
:
=
(
(
(
Eq
and
Pv
)
+
Pv
)
xor
Pv
)
or
Eq
;
Ph
:
=
Mv
or
(
not
(
Xh
or
Pv
)
)
;
Mh
:
=
Pv
and
Xh
;
if
(
Ph
and
(
ONE
shl
(
m
-
1
)
)
)
<>
0
then
inc
(
Score
)
else
if
(
Mh
and
(
ONE
shl
(
m
-
1
)
)
)
<>
0
then
dec
(
Score
)
;
Ph
:
=
Ph
shl
ONE
;
Pv
:
=
(
Mh
shl
ONE
)
or
(
not
(
Xv
or
Ph
)
)
;
Mv
:
=
Ph
and
Xv
;
end
;
result
:
=
Score
;
end
;
with testing code
Code: Pascal
[Select]
[+]
[-]
j
:
=
edit_distance_bit
(
'agtcaaaagtcagtcagtcagtcagtcacagtcagaaggcatccaaccga'
,
'ccgttagtcagaaacagtcagtcagtcagtcagtccagtcttaggcccgga'
)
;
Logged
AlexTP
Hero Member
Posts: 2401
Re: optimization will generate wrong result
«
Reply #1 on:
May 11, 2021, 06:31:05 pm »
FPC 3.2 fixes; Linux x64.
-O0: 14
-O1: 14
-O2: 16
Logged
CudaText editor
-
ATSynEdit
-
More from me
bytebites
Hero Member
Posts: 639
Re: optimization will generate wrong result
«
Reply #2 on:
May 11, 2021, 06:42:33 pm »
Code: Pascal
[Select]
[+]
[-]
fillbyte
(
Peq
,
0
,
sizeof
(
Peq
)
)
;
Your code is wrong. The second argument of fillchar is count, the last is value.
Code: Pascal
[Select]
[+]
[-]
Pv
:
=
Pv
or
(
ONE
shl
i
)
;
Pv is not initialised.
Logged
powerpcer
Full Member
Posts: 100
Re: optimization will generate wrong result
«
Reply #3 on:
May 12, 2021, 03:13:23 am »
thanks,
after fixed, -O3 optimize faster little, from 40ms to 30ms
«
Last Edit: May 12, 2021, 03:18:01 am by powerpcer
»
Logged
Print
Pages: [
1
]
« previous
next »
Lazarus
»
Forum
»
Free Pascal
»
General
(Moderators:
FPK
,
Tomas Hajny
) »
optimization will generate wrong result
TinyPortal
© 2005-2018