Lazarus
Home
Help
TinyPortal
Search
Login
Register
Lazarus
»
Forum
»
Free Pascal
»
General
(Moderators:
FPK
,
Tomas Hajny
) »
optimization will generate wrong result
Free Pascal
Website
Downloads
Wiki
Documentation
Bugtracker
Mailing List
Lazarus
Website
Downloads (Laz+FPC)
Packages (OPM)
FAQ
Wiki
Documentation (RTL/FCL/LCL)
Bugtracker
CCR Bugs
IRC channel
GIT
Mailing List
Other languages
Foundation
Website
Useful Wiki Links
Project Roadmap
Getting the Source
Screenshots
How to use the forum
About donations (wiki)
Bookstore
Computer Math and Games in Pascal
(preview)
Lazarus Handbook
Search
Advanced search
Recent
Lazarus for Windows on aa...
by
Wallaby
[April 23, 2024, 11:46:56 pm]
Parameter passing odditie...
by
KodeZwerg
[April 23, 2024, 11:04:39 pm]
Can function be used for ...
by
jamie
[April 23, 2024, 10:53:10 pm]
(Solved) TIndexedAVLTree ...
by
lainz
[April 23, 2024, 10:49:03 pm]
Demo Scene Picture sinwav...
by
KodeZwerg
[April 23, 2024, 10:26:21 pm]
fkInternalCalc
by
zraja
[April 23, 2024, 09:31:07 pm]
A fairly simple sound sol...
by
KodeZwerg
[April 23, 2024, 09:23:37 pm]
add new targets to make
by
marcov
[April 23, 2024, 08:38:42 pm]
how to tweek fpmake to co...
by
marcov
[April 23, 2024, 08:29:16 pm]
Quirky windows
by
ASerge
[April 23, 2024, 07:07:16 pm]
[Request] Demo Scene Sub ...
by
Gigatron
[April 23, 2024, 06:29:39 pm]
Unlocking Files
by
KodeZwerg
[April 23, 2024, 06:03:08 pm]
[SOLVED] trunk bug for mi...
by
Key-Real
[April 23, 2024, 05:56:32 pm]
Demo Scene Bitmap Font Sc...
by
Gigatron
[April 23, 2024, 05:56:27 pm]
Compile/Convert Delphi pr...
by
Martin_fr
[April 23, 2024, 05:43:11 pm]
Generics - correct syntax
by
Thaddy
[April 23, 2024, 05:40:59 pm]
InstallAware Using Lazaru...
by
msintle
[April 23, 2024, 05:26:36 pm]
Xcode Command Line Tools ...
by
Joseph
[April 23, 2024, 05:16:39 pm]
Offical launch of the 1 B...
by
Hartmut
[April 23, 2024, 04:49:29 pm]
what to do if my target M...
by
nickysn
[April 23, 2024, 04:16:02 pm]
compiler error in unit
by
paule32
[April 23, 2024, 03:49:50 pm]
Multithreading - synchron...
by
mika
[April 23, 2024, 01:48:51 pm]
May be useful to somebody
by
KodeZwerg
[April 23, 2024, 12:38:22 pm]
match automatic highlight...
by
Чебурашка
[April 23, 2024, 11:35:14 am]
Tchart with dual numbers ...
by
wp
[April 23, 2024, 10:48:18 am]
« previous
next »
Print
Pages: [
1
]
Author
Topic: optimization will generate wrong result (Read 1164 times)
powerpcer
Full Member
Posts: 100
optimization will generate wrong result
«
on:
May 11, 2021, 06:26:08 pm »
for function below, if i change the optimization to -O2, the result will be wrong 11, the correct one is 18.
i test this code on win10 x64
Code: Pascal
[Select]
[+]
[-]
function
edit_distance_bit
(
str1
,
str2
:
string
)
:
integer
;
var
Peq
:
array
[
0
..
255
]
of
Uint64
;
Pv
,
Eq
,
Xv
,
Xh
,
Ph
,
Mh
,
Mv
,
ONE
:
Uint64
;
i
,
j
,
m
,
n
,
Score
:
integer
;
p1
,
p2
:
pbyte
;
s
:
string
;
begin
if
(
length
(
str1
)
< length
(
str2
)
)
then
begin
p1
:
=
@
str2
[
1
]
;
p2
:
=
@
str1
[
1
]
;
m
:
=
length
(
str2
)
;
n
:
=
length
(
str1
)
;
end
else
begin
p1
:
=
@
str1
[
1
]
;
p2
:
=
@
str2
[
1
]
;
m
:
=
length
(
str1
)
;
n
:
=
length
(
str2
)
;
end
;
ONE
:
=
1
;
fillbyte
(
Peq
,
0
,
sizeof
(
Peq
)
)
;
Mv
:
=
0
;
Score
:
=
m
;
for
i
:
=
0
to
m
do
begin
Peq
[
p1
[
i
]
]
:
=
Peq
[
p1
[
i
]
]
or
ONE
shl
i
;
Pv
:
=
Pv
or
(
ONE
shl
i
)
;
end
;
for
j
:
=
0
to
n
do
begin
Eq
:
=
Peq
[
p2
[
j
]
]
;
Xv
:
=
Eq
or
Mv
;
Xh
:
=
(
(
(
Eq
and
Pv
)
+
Pv
)
xor
Pv
)
or
Eq
;
Ph
:
=
Mv
or
(
not
(
Xh
or
Pv
)
)
;
Mh
:
=
Pv
and
Xh
;
if
(
Ph
and
(
ONE
shl
(
m
-
1
)
)
)
<>
0
then
inc
(
Score
)
else
if
(
Mh
and
(
ONE
shl
(
m
-
1
)
)
)
<>
0
then
dec
(
Score
)
;
Ph
:
=
Ph
shl
ONE
;
Pv
:
=
(
Mh
shl
ONE
)
or
(
not
(
Xv
or
Ph
)
)
;
Mv
:
=
Ph
and
Xv
;
end
;
result
:
=
Score
;
end
;
with testing code
Code: Pascal
[Select]
[+]
[-]
j
:
=
edit_distance_bit
(
'agtcaaaagtcagtcagtcagtcagtcacagtcagaaggcatccaaccga'
,
'ccgttagtcagaaacagtcagtcagtcagtcagtccagtcttaggcccgga'
)
;
Logged
AlexTP
Hero Member
Posts: 2406
Re: optimization will generate wrong result
«
Reply #1 on:
May 11, 2021, 06:31:05 pm »
FPC 3.2 fixes; Linux x64.
-O0: 14
-O1: 14
-O2: 16
Logged
CudaText editor
-
ATSynEdit
-
More from me
bytebites
Hero Member
Posts: 642
Re: optimization will generate wrong result
«
Reply #2 on:
May 11, 2021, 06:42:33 pm »
Code: Pascal
[Select]
[+]
[-]
fillbyte
(
Peq
,
0
,
sizeof
(
Peq
)
)
;
Your code is wrong. The second argument of fillchar is count, the last is value.
Code: Pascal
[Select]
[+]
[-]
Pv
:
=
Pv
or
(
ONE
shl
i
)
;
Pv is not initialised.
Logged
powerpcer
Full Member
Posts: 100
Re: optimization will generate wrong result
«
Reply #3 on:
May 12, 2021, 03:13:23 am »
thanks,
after fixed, -O3 optimize faster little, from 40ms to 30ms
«
Last Edit: May 12, 2021, 03:18:01 am by powerpcer
»
Logged
Print
Pages: [
1
]
« previous
next »
Lazarus
»
Forum
»
Free Pascal
»
General
(Moderators:
FPK
,
Tomas Hajny
) »
optimization will generate wrong result
TinyPortal
© 2005-2018