Lazarus
Home
Help
TinyPortal
Search
Login
Register
Lazarus
»
Forum
»
Free Pascal
»
General
(Moderators:
FPK
,
Tomas Hajny
) »
optimization will generate wrong result
Free Pascal
Website
Downloads
Wiki
Documentation
Bugtracker
Mailing List
Lazarus
Website
Downloads (Laz+FPC)
Packages (OPM)
FAQ
Wiki
Documentation (RTL/FCL/LCL)
Bugtracker
CCR Bugs
IRC channel
GIT
Mailing List
Other languages
Foundation
Website
Useful Wiki Links
Project Roadmap
Getting the Source
Screenshots
How to use the forum
About donations (wiki)
Bookstore
Computer Math and Games in Pascal
(preview)
Lazarus Handbook
Search
Advanced search
Recent
A "leisure" question on W...
by
VisualLab
[
Today
at 02:01:13 am]
Big Numbers Math
by
woodybrison
[
Today
at 01:30:21 am]
Project fails on run but ...
by
jamie
[
Today
at 12:54:49 am]
Curling Pythagoras Tree: ...
by
Boleeman
[
Today
at 12:00:37 am]
Offical launch of the 1 B...
by
Gustavo 'Gus' Carreno
[March 28, 2024, 11:51:31 pm]
Ribbon bar in Lazarus 3.2...
by
wp
[March 28, 2024, 11:29:17 pm]
Free AI to use in local
by
BSaidus
[March 28, 2024, 10:57:23 pm]
how to search in rxmemory...
by
rcmz
[March 28, 2024, 10:19:54 pm]
Configure JCF messages
by
GordonFindlay
[March 28, 2024, 10:16:19 pm]
Poll: Watches and Display...
by
Martin_fr
[March 28, 2024, 10:15:08 pm]
Dialog ShowModal and an i...
by
d7_2_laz
[March 28, 2024, 09:51:39 pm]
JEDI error but unit compi...
by
Thaddy
[March 28, 2024, 09:30:33 pm]
Understanding and adjusti...
by
circular
[March 28, 2024, 09:09:56 pm]
Controlling the behavior ...
by
wp
[March 28, 2024, 08:29:28 pm]
how to change the color f...
by
wp
[March 28, 2024, 07:23:58 pm]
Dynarray initialization p...
by
Thaddy
[March 28, 2024, 06:30:12 pm]
Zeos components. Had to c...
by
Fantablup
[March 28, 2024, 04:17:13 pm]
[SOLVED] Completion box s...
by
furious programming
[March 28, 2024, 04:12:26 pm]
[LAMW] How to create a ca...
by
af0815
[March 28, 2024, 03:48:16 pm]
Complex package installat...
by
wp
[March 28, 2024, 03:38:16 pm]
[SOLVED] Combined pointer...
by
CM630
[March 28, 2024, 02:48:41 pm]
Using KeyPress event, how...
by
Zvoni
[March 28, 2024, 02:24:42 pm]
a Unit problem?
by
Thaddy
[March 28, 2024, 01:56:12 pm]
Any upgrades to fpWeb pag...
by
marcov
[March 28, 2024, 12:50:25 pm]
Help needed with Cairo / ...
by
Roland57
[March 28, 2024, 12:25:16 pm]
« previous
next »
Print
Pages: [
1
]
Author
Topic: optimization will generate wrong result (Read 1131 times)
powerpcer
Full Member
Posts: 100
optimization will generate wrong result
«
on:
May 11, 2021, 06:26:08 pm »
for function below, if i change the optimization to -O2, the result will be wrong 11, the correct one is 18.
i test this code on win10 x64
Code: Pascal
[Select]
[+]
[-]
function
edit_distance_bit
(
str1
,
str2
:
string
)
:
integer
;
var
Peq
:
array
[
0
..
255
]
of
Uint64
;
Pv
,
Eq
,
Xv
,
Xh
,
Ph
,
Mh
,
Mv
,
ONE
:
Uint64
;
i
,
j
,
m
,
n
,
Score
:
integer
;
p1
,
p2
:
pbyte
;
s
:
string
;
begin
if
(
length
(
str1
)
< length
(
str2
)
)
then
begin
p1
:
=
@
str2
[
1
]
;
p2
:
=
@
str1
[
1
]
;
m
:
=
length
(
str2
)
;
n
:
=
length
(
str1
)
;
end
else
begin
p1
:
=
@
str1
[
1
]
;
p2
:
=
@
str2
[
1
]
;
m
:
=
length
(
str1
)
;
n
:
=
length
(
str2
)
;
end
;
ONE
:
=
1
;
fillbyte
(
Peq
,
0
,
sizeof
(
Peq
)
)
;
Mv
:
=
0
;
Score
:
=
m
;
for
i
:
=
0
to
m
do
begin
Peq
[
p1
[
i
]
]
:
=
Peq
[
p1
[
i
]
]
or
ONE
shl
i
;
Pv
:
=
Pv
or
(
ONE
shl
i
)
;
end
;
for
j
:
=
0
to
n
do
begin
Eq
:
=
Peq
[
p2
[
j
]
]
;
Xv
:
=
Eq
or
Mv
;
Xh
:
=
(
(
(
Eq
and
Pv
)
+
Pv
)
xor
Pv
)
or
Eq
;
Ph
:
=
Mv
or
(
not
(
Xh
or
Pv
)
)
;
Mh
:
=
Pv
and
Xh
;
if
(
Ph
and
(
ONE
shl
(
m
-
1
)
)
)
<>
0
then
inc
(
Score
)
else
if
(
Mh
and
(
ONE
shl
(
m
-
1
)
)
)
<>
0
then
dec
(
Score
)
;
Ph
:
=
Ph
shl
ONE
;
Pv
:
=
(
Mh
shl
ONE
)
or
(
not
(
Xv
or
Ph
)
)
;
Mv
:
=
Ph
and
Xv
;
end
;
result
:
=
Score
;
end
;
with testing code
Code: Pascal
[Select]
[+]
[-]
j
:
=
edit_distance_bit
(
'agtcaaaagtcagtcagtcagtcagtcacagtcagaaggcatccaaccga'
,
'ccgttagtcagaaacagtcagtcagtcagtcagtccagtcttaggcccgga'
)
;
Logged
AlexTP
Hero Member
Posts: 2386
Re: optimization will generate wrong result
«
Reply #1 on:
May 11, 2021, 06:31:05 pm »
FPC 3.2 fixes; Linux x64.
-O0: 14
-O1: 14
-O2: 16
Logged
CudaText editor
-
ATSynEdit
-
More from me
bytebites
Hero Member
Posts: 633
Re: optimization will generate wrong result
«
Reply #2 on:
May 11, 2021, 06:42:33 pm »
Code: Pascal
[Select]
[+]
[-]
fillbyte
(
Peq
,
0
,
sizeof
(
Peq
)
)
;
Your code is wrong. The second argument of fillchar is count, the last is value.
Code: Pascal
[Select]
[+]
[-]
Pv
:
=
Pv
or
(
ONE
shl
i
)
;
Pv is not initialised.
Logged
powerpcer
Full Member
Posts: 100
Re: optimization will generate wrong result
«
Reply #3 on:
May 12, 2021, 03:13:23 am »
thanks,
after fixed, -O3 optimize faster little, from 40ms to 30ms
«
Last Edit: May 12, 2021, 03:18:01 am by powerpcer
»
Logged
Print
Pages: [
1
]
« previous
next »
Lazarus
»
Forum
»
Free Pascal
»
General
(Moderators:
FPK
,
Tomas Hajny
) »
optimization will generate wrong result
TinyPortal
© 2005-2018