Lazarus OpenDocument broken with FPC 3.2.0 + trunk for macOS

[trev]

As a result of the odd decision by the FPC developers to stop treating UNIX directories as files -- unless its the renamefile() function -- the following Lazarus code in lazarus-src/lcl/include/sysenvapis_mac.inc is broken:

Code: Pascal  [Select][+][-]

1. // Open a document with the default application associated with it in the system
2. function OpenDocument(APath: String): Boolean;
3. var
4.   ResultingPath: string;
5.   lpath: string;
6. begin
7.   Result := True;
8.   if not FileExistsUTF8(APath) then begin
9.     // Windows OpenDocument handles URLs as well
10.     Result := OpenURL(Apath);
11.     Exit;
12.   end;
13.   // Paths with spaces need to be quoted, see bug 21651
14.   if (APath<>'') and (APath[1]<>'''') then
15.     ResultingPath:=QuotedStr(APath)
16.   else
17.     ResultingPath:=APath;
18.   RunCmdFromPath('open',ResultingPath);

The highlighted line now needs to be changed to:

Code: Pascal  [Select][+][-]

1. if not FileExistsUTF8(APath) and not DirectoryExistsUTF8(aPath) then begin

I lost many hours yesterday trying to work out why my carefully constructed Apple Help Book, a fragile construction at the best of times given Apple's outdated and now often incorrect documentation which petered out in 2013, did not work. For once, it wasn't my code and it wasn't my finely crafted property lists at fault.

Logged: https://bugs.freepascal.org/view.php?id=38670

[Bart]

Please file a bugreport.

Bart

[trev]

I did - see last line of my post

[Bart]

Thank you, I missed that.

Could you upload a patch (in the bugtracker) against trunk please.
See my comments in the bugreport.
I don't have access to a Mac, so I cannot even check if it compiles if I make the changes myself.
I'll apply it then.

Bart

[trev]

Working on it... done and thanks!

[Bart]

Applied in r64890.
Please test and close the bugreport if OK.

Bart

[trev]

Done and tested. Harmony has now been restored to the macOS universe in Lazarus trunk. Thanks!