Recent

Author Topic: Remake of lHelp  (Read 2274 times)

Andrey Sobol

  • New Member
  • *
  • Posts: 48
Remake of lHelp
« on: February 07, 2021, 12:13:16 pm »
I have placed next version of the lHelp changes as patch to a trunck.
https://bugs.freepascal.org/view.php?id=38250
Is anyone who can to test it also? I have a few time to fix a some mistakes.
I tested that on Windows only.

Before aplly this patch you should carefully read a description and applly related fixes also.
I will thank for feedbacks.
Andrey.

Alextp

  • Hero Member
  • *****
  • Posts: 1272
    • UVviewsoft
Re: Remake of lHelp
« Reply #1 on: February 07, 2021, 12:35:09 pm »
Thanks for this work. Does lHelp allow to read Russian text CHMs on Linux? you can find many CHMs in the forum ru-board. E.g. AutoHotkey help in CHM, Batch syntax help in CHM

marcov

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 9226
  • FPC developer.
Re: Remake of lHelp
« Reply #2 on: February 07, 2021, 01:50:01 pm »
I tried to apply the patch ( I don't know much about lhelp, so evaluating such huge patch is beyond me), but compiling fails.

My guess is that a new (?) dependency on lazmouseandkeyinput is missing ?

Quote
Free Pascal Compiler version 3.3.1 [2021/02/06] for i386
Copyright (c) 1993-2021 by Florian Klaempfl and others
Target OS: Win32 for i386
Compiling lhelp.lpr
lhelp.lpr(29,48) Fatal: Can't find unit lazmouseandkeyinput used by lhelp

Andrey Sobol

  • New Member
  • *
  • Posts: 48
Re: Remake of lHelp
« Reply #3 on: February 07, 2021, 01:59:36 pm »
My guess is that a new (?) dependency on lazmouseandkeyinput is missing ?

That is strange. The lazmouseandkeyinput is included to project.
Code: Pascal  [Select][+][-]
  1. -    <RequiredPackages Count="3">
  2. +    <RequiredPackages Count="4">
  3.        <Item1>
  4. +        <PackageName Value="lazmouseandkeyinput"/>
  5. +      </Item1>
  6. +      <Item2>
  7.  
Are you see it into a project tree?

marcov

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 9226
  • FPC developer.
Re: Remake of lHelp
« Reply #4 on: February 07, 2021, 02:07:18 pm »
I'm building it as part of bigide. Maybe then dependencies in components/ also need to be updated/

Andrey Sobol

  • New Member
  • *
  • Posts: 48
Re: Remake of lHelp
« Reply #5 on: February 07, 2021, 02:16:14 pm »
I am building a lhelp project only.  We need to change makefiles for building it as the bigide build.

Ps. Published also a makefile.fpc patch. But as far as I know you should to build it by a fpcmake utility for produce a makefile.
« Last Edit: February 07, 2021, 03:12:46 pm by Andrey Sobol »

marcov

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 9226
  • FPC developer.
Re: Remake of lHelp
« Reply #6 on: February 07, 2021, 05:35:42 pm »
I meanwhile compiled via make all and then manual compile (my lazarus on this machine was heavily outdated)

It seems to work, and is quite snappy, but I get a lot of external help vs chm help dialogs that IMHO are useless and slow help operation.


Andrey Sobol

  • New Member
  • *
  • Posts: 48
Re: Remake of lHelp
« Reply #7 on: February 07, 2021, 06:33:46 pm »
I get a lot of external help vs chm help dialogs that IMHO are useless and slow help operation.
I didn`t understand you. Could you write about this in detail?
« Last Edit: February 07, 2021, 06:42:05 pm by Andrey Sobol »

marcov

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 9226
  • FPC developer.
Re: Remake of lHelp
« Reply #8 on: February 07, 2021, 09:25:39 pm »
I get a lot of external help vs chm help dialogs that IMHO are useless and slow help operation.
I didn`t understand you. Could you write about this in detail?

One picture says more than a thousand words ;-)

JuhaManninen

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 4001
  • I like bugs.
Re: Remake of lHelp
« Reply #9 on: February 11, 2021, 03:05:38 pm »
Please test everybody. I don't know LHelp well but I applied the patch and then tweaked some things because nobody else did.
I can tell Andrey Sobol's work is an improvement.

Does lHelp allow to read Russian text CHMs on Linux?
To be more precise, is Unicode fully supported? Cyrillic text is a good test indeed.
There was already an issue with THTMLWordHighlighter.CheckTextNode. See the bug report.
FPC's XML lib uses UTF-16 DOMString (UnicodeString) which must be handled correctly with our UTF-8 solution.
Please report any problems with Unicode handling.
Mostly Lazarus trunk and FPC 3.2 on Manjaro Linux 64-bit.

 

TinyPortal © 2005-2018