trying to apply a patch from the bug site, shows blank in SVN

[jamie]

I tried to apply a patch purposed here
https://bugs.freepascal.org/view.php?id=37982

I downloaded it and then tried applying the patch and all that showed was two blank window panes

what I am doing wrong ?

[lucamar]

what I am doing wrong ?

That quite depends on what you're doing, meaning: how are you exactly doing what you're doing?

There are quite a lot of ways of applying a patch ...

[jamie]

I download the suggested patch from the link into a folder on my side..

I then use the TortoiseSVN:ApplyPatch, go over to the folder where I have it stored, select it and the dual pane window comes up to show the patch and the current file on your system..

 Both panes are empty when I do this.

 how else do you apply someone's patch without manually writing it in yourself ?

 Do I need to follow this process on my local copy of the file instead ?

 I did this from the root of the Trunk install ?

[Thaddy]

That patch, even the last -corrected - one in the discussion simply looks incorrect, especially the finalization parts.
Also look at the remarks from ASerge in the discussion in the bug report.
As it stands I would not even try to test it. The patch is still geared towards a very specific problem for the submitter, but breaks general use. It also does not contain sufficient tests.

Your patch procedure looks correct, but you have to apply it to the correct version.

[Thaddy]

If the patch is created correctly (from the root of the lazarus source directory)
put the patch there and simply do svn patch <patchname> and rebuild Lazarus. The way the patch is created looks correct. see path on top.

[jamie]

Thaddy, I was unlucky to see your post. I guess the ignore is not always working here..

If you can't offer a suggestion to make my quest work then please stay out of it or at least if you think you know how to fix the super classing issues without changing the names then please step up to the plate, I would love to hear how my 45 years, many of which with windows is failing me.

[Thaddy]

Matter of cross-post abd cache. Look at my last reply if you still want to test it. Icreate patches all the time, so I know what I am doing. They get also applied.

[Thaddy]

In a terminal window of course I love the commandline.

[jamie]

doing some more reading here at the site for Tors.. .

it appears I can't directly apply a patch like this unless it is able to reference the repository of the revision in use..

The revision number he has in the patch is 64142 and currently we are at 64179.

is it possible the repository is not supplying a reference back to that point?

[PascalDragon]

I downloaded it and then tried applying the patch and all that showed was two blank window panes

From your further posts I assume that you use TortoiseSVN. The way I do it is to do a right-click drag of the patch to the subversion checkout and use “Apply patch” in the resulting context menu. That will open a window with - yes - two empty panes, but also a small tool window with a list of files and two buttons “Patch Selected Item” and “Patch All”. I use “Patch All”, hope that everything goes well (if not the files with problems will be marked in red and by clicking them you can view them in the two panes) and close the main window.

[MarkMLl]

Thaddy, I was unlucky to see your post. I guess the ignore is not always working here..

If you can't offer a suggestion to make my quest work then please stay out of it or at least if you think you know how to fix the super classing issues without changing the names then please step up to the plate, I would love to hear how my 45 years, many of which with windows is failing me.

If you have Thaddy on a kill list then I suggest adding me to it as well. For somebody with "The only true wisdom is knowing you know nothing" as a signature, who is asking for help, and who has a history of making half-arsed and inaccurate suggestions you're being gratuitously unpleasant.

Apologies to the moderators and list owner for saying what I'm sure a lot of other people are thinking.

MarkMLl

p.s. If in doubt use the  patch  utility. Generally speaking it tells you why something is being rejected, which is often because the line numbers have moved grossly out of sync.

[Bart]

p.s. If in doubt use the  patch  utility. Generally speaking it tells you why something is being rejected, which is often because the line numbers have moved grossly out of sync.

The patch utility (patch.exe, comes with fpc install) for Windows is a nightmare to work with.
First of all, if EOL style in patch differs from your source files, it chokes.
Yoiu almost always have to set the -p parameter.
Even with that correctly set, it will reject patches that a simple "svn patch patchfile" has no trouble with at all.

The late bigchimp wrote a patchwrangler utility around patch.exe some years ago IIRC.

Bart

[MarkMLl]

I admit that I was thinking about the unix variant. I've used it quite a lot for e.g. installing kernel patches, rather less for adding functionality that hadn't made its way into the trunk of a project... and the problems were almost always caused by the same thing (line numbers out of sync).

Which is a pity, since back in the 80s there was an interesting algorithm published on synchronising text files. However it was studiously ignored by the mainstream because the author was an outspoken proponent of applying patents to software... the technique is IIRC used in Meld but I've not seen it acknowledged elsewhere.

The late bigchimp wrote a patchwrangler utility around patch.exe some years ago IIRC.

He is sorely missed. Not only did he know his stuff but he was courteous and good-humoured even when he disagreed with somebody.

MarkMLl

[jamie]

I downloaded it and then tried applying the patch and all that showed was two blank window panes

From your further posts I assume that you use TortoiseSVN. The way I do it is to do a right-click drag of the patch to the subversion checkout and use “Apply patch” in the resulting context menu. That will open a window with - yes - two empty panes, but also a small tool window with a list of files and two buttons “Patch Selected Item” and “Patch All”. I use “Patch All”, hope that everything goes well (if not the files with problems will be marked in red and by clicking them you can view them in the two panes) and close the main window.

Thank you very much for an comprehensive response.

 I do see the option on the left but didn't go any further. I just assumed at that point it was a wash out since I've used that utility before which came with content..

I'll give it try.
Thanks


EDIT:

 Thanks again..
 
 patch went in and it's working fine.

I just test run a host and dll app together and the problem seems to be correct. Also recompiled the trunk IDE with the changes and that works
I 'll will report this on the bug site for reference.

 For any one concerned with this, this only changes the class names if the controls are created in a DLL otherwise they still remain as they were in the host app. So nothing will change here for normal apps.

[PascalDragon]

Thanks again..
 
 patch went in and it's working fine.

You're welcome.