Recent

Author Topic: The fixes to pasdoc and lhelp how to speed up that?  (Read 1669 times)

Andrey Sobol

  • New Member
  • *
  • Posts: 48
The fixes to pasdoc and lhelp how to speed up that?
« on: November 26, 2020, 08:32:07 am »
Hi guys,
If I or somebody publishes the patch to issue, how to speed up that?
1. Another members can test it before...
2. How can I ask a question to developers about that?
3. How long can be a patch in the queue?
4. I write fixes to pasdoc and lhelp, who is responsible for this part of the project?

What can I do yet?

My patch have been hanged without of movement
https://bugs.freepascal.org/view.php?id=29747
and I make a big fix to the pasdoc for
https://bugs.freepascal.org/view.php?id=38028
« Last Edit: November 26, 2020, 08:38:58 am by seniorandre »

marcov

  • Administrator
  • Hero Member
  • *
  • Posts: 9534
  • FPC developer.
Re: The fixes to pasdoc and lhelp how to speed up that?
« Reply #1 on: November 26, 2020, 10:10:10 am »
I think the tobject link generation is a fpdoc issue, because tobject is not clickable in the windows help viewer too, please file a separate bug with the FPC project. (and keep the current one for the lhelp index related issues)

Just a two line description and a link to/number of  the lazarus bugreport for the screenshots.

It's not always the easiest kind of issues, so please be patient since it might need the christmas holiday for enough time.

serbod

  • Full Member
  • ***
  • Posts: 138
Re: The fixes to pasdoc and lhelp how to speed up that?
« Reply #2 on: November 26, 2020, 10:55:14 am »
I was fixed LHelp about 3 years ago.

https://github.com/serbod/lazhelp

Andrey Sobol

  • New Member
  • *
  • Posts: 48
Re: The fixes to pasdoc and lhelp how to speed up that?
« Reply #3 on: November 26, 2020, 01:48:20 pm »
I was fixed LHelp about 3 years ago.
But why yours code is not into repo?

serbod

  • Full Member
  • ***
  • Posts: 138
Re: The fixes to pasdoc and lhelp how to speed up that?
« Reply #4 on: November 26, 2020, 02:32:32 pm »
But why yours code is not into repo?

Too many changes at once, they must be divided to many small diffs.

marcov

  • Administrator
  • Hero Member
  • *
  • Posts: 9534
  • FPC developer.
Re: The fixes to pasdoc and lhelp how to speed up that?
« Reply #5 on: November 26, 2020, 06:02:31 pm »
I merged most of the packages/chm mutations because these files were mutated less. Still diffing and figuring out difference was a lot of work and took the better part of the my free time for a week.

The lazarus/lhelp parts were more heavily mutated and also source formatting tools were used which made diffing very hard. I tried and gave up, and apparently that went for the other devels too. It was just not clear what was what and what it was for.

And as he said, Serbod refused to break down the mutations into parts that belonged together into small patches to aid the process. I assume he had no recollection of what was what anymore either.

It is like science. If it is not understandable and reproducable it is worthless.
« Last Edit: November 26, 2020, 06:05:43 pm by marcov »

serbod

  • Full Member
  • ***
  • Posts: 138
Re: The fixes to pasdoc and lhelp how to speed up that?
« Reply #6 on: November 27, 2020, 05:03:45 pm »
I manually make comparsion for style differencies (private variables, fields and params names, spaces) and compile path and diff files (see attachment).

After applyng that diffs, all significiant changes become clearly visible.

Small changes:
- get default encoding from Locale ID and from HTML 'meta' tag.
- fixed RPC calls, when Lazarus open context help and LHelp already open
- prevented memory leaks on exceptions

Big changes:
- programmatically created controls for new tab moved to separate pre-designed TFrame
- open multiple CHM in single tab by default
- Index tab behavior as in MS Help

I can provide separate diffs for that changes. But not sure, that them will be correctly separated and will not break whole thing, especially for big changes.

D

Andrey Sobol

  • New Member
  • *
  • Posts: 48
Re: The fixes to pasdoc and lhelp how to speed up that?
« Reply #7 on: November 27, 2020, 05:08:44 pm »
After applyng that diffs, all significiant changes become clearly visible.
If you do not mind, then I will slowly use yours code and make changes by parts.

 

TinyPortal © 2005-2018