Recent

Author Topic: spkToolbar evolution  (Read 2305 times)

wp

  • Hero Member
  • *****
  • Posts: 7729
Re: spkToolbar evolution
« Reply #30 on: October 02, 2020, 11:43:48 pm »
Thanks.

I tried to apply the patch, but was not successful ("The patch does not apply cleanly ... Patching is not possible"). I split it into the individual file parts, and managed to patch spkt_Const, spkToolbar and spkt_Appearance as well as the demo. As for the AppearanceEditor, however, the patch file contains a note for the lfm file saying "Cannot display: file marked as a binary type.".

Could you please try to create the patch again for the appearance editor again? As an exception add also the full files, if there is such an issue again.
Mainly Lazarus trunk / fpc 3.2.0 / all 32-bit on Win-10, but many more...

husker

  • New Member
  • *
  • Posts: 20
Re: spkToolbar evolution
« Reply #31 on: October 03, 2020, 09:32:32 am »
Weird... I've created a new patch with only Appearance Editor unit and form, and I also got the "Cannot display: file marked as a binary type" when I check the patch in TortoiseUDiff. But seeing diffs with TortoiseMerge, the .lfm file is seen as a text file ?! I should do something wrong, but I don't know what  %)...

I attach the patch but also the original files (I had to change .lfm file extension to attach it).

Thanks for your time :).
Lazarus 2.0.10 / Windows 10 1903 hobbyist developer. Happy to learn every day !

wp

  • Hero Member
  • *****
  • Posts: 7729
Re: spkToolbar evolution
« Reply #32 on: October 03, 2020, 04:59:21 pm »
Still the same problem, no idea why TortoiseSVN considers a file with mime-type text/plain as binary... But with the full files I could complete the patch. Thanks. I fixed anchoring and TabOrder and reworked the autosizing for the AppearanceEditor.
Mainly Lazarus trunk / fpc 3.2.0 / all 32-bit on Win-10, but many more...

husker

  • New Member
  • *
  • Posts: 20
Re: spkToolbar evolution
« Reply #33 on: October 03, 2020, 08:13:18 pm »
OK.

Thanks wp for the corrections, and merging my changes. I must confess that I completely forgot to check tab order on the appearance editor  :-[...

I'll update my package to match the repository, and start working on the next step. I've 3 or 4 differents things that I still want to add, but I don't know yet which one I'll pick and work on :). I need to think about this for a while now.

Stay tuned  ;).
Lazarus 2.0.10 / Windows 10 1903 hobbyist developer. Happy to learn every day !

 

TinyPortal © 2005-2018