Please attach only images, and keep text readable in the forum. You can attach up to 4 images.
By the first patch here proposed, multiple result (same text and options) not allowed, that is clearer
showresult form now
1) That is not exactly what the patch does. It does not compare the directory, nor the file mask.
I do occasionally search the same search, but in 2 or more different directories. Then I need both results (though having them in one tab would in
some cases be convenient)
2) The patch does not make it optional.
I have actually sometimes a need to keep the old search, despite it being identical.
A typical scenario is during refactoring. Where I rewrite (not just simple replace, but replace with a variety of different code snippets) some code. I.e. I search for "GetMainFormSizeAndPos" and I replace it (and surrounding code) with different new code.
- I do want to keep a list of all the locations that I changed (I.e. the original search result). So I can re-visit any code I already changed.
- I will re-run the search to check if I missed any location
=> I need both results.
So having duplicated tabs is actually a feature that I do not want to remove.
A patch must therefore be an extension to the feature, allowing the user to chose.
See my other post, on how such an option could be done. (And maybe @Juha has some ideas?)
There are a lot of people using the IDE. In my time working on it, I have countless times been surprised how other people may be using a feature that I would have considered unusable.
As for adding an option. My gut feeling is to best add it to Editor > General > Miscellaneous
ide/frames/editor_general_misc_options
You need to look at: Setup, ReadSetting, WriteSettings
In TEditorOptions just add a
published property. That will be saved automatically.
Then you can extend the "search in files" dialog, and hide/show extra controls based on the new setting.
@Juha: Any idea if that could be simplified?