Recent

Author Topic: about #0034416: EPoll_Event struct size  (Read 2866 times)

baldzhang

  • New Member
  • *
  • Posts: 32
about #0034416: EPoll_Event struct size
« on: February 01, 2020, 11:56:10 pm »
Hi, I met this issue yesterday, search the bug tracker and found #0034416
already add a note there.

could any one have a look of it please?

I'm not familiar with mailing list and do not know how to post/reply... sorry about that. %)

baldzhang

  • New Member
  • *
  • Posts: 32
Re: about #0034416: EPoll_Event struct size
« Reply #1 on: February 12, 2020, 01:15:00 am »
Is it possible to merge r43880 and r44093 to 3.2 ?

r43880 (fix #0036528)
and
r44093 (fix #0034416)

hope it is not too late to merge them.


** I try to post this to mailing list, sent success but not shown in list archive, may be my email address is banned**
although my register email received ok....

Thaddy

  • Hero Member
  • *****
  • Posts: 10119
Re: about #0034416: EPoll_Event struct size
« Reply #2 on: February 12, 2020, 08:57:07 am »
Marcov does most of the merges and he reads this, so:
Marco, can you merge them? They are both non-intrusive.
« Last Edit: February 12, 2020, 09:00:32 am by Thaddy »
I am more like donkey than shrek

marcov

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 8388
  • FPC developer.
Re: about #0034416: EPoll_Event struct size
« Reply #3 on: February 12, 2020, 10:02:58 am »
Marcov does most of the merges and he reads this, so:
Marco, can you merge them? They are both non-intrusive.

During the week, depending on time, I only merge easy stuff. I had already looked at the revs, but they didn't seem easy. First, syscall changes are never nonintrusive.

43880:
It has to be checked if 3.2 already contains that newfsstatat call.

And finally, a build has to be done to test for issues, since lstat is used in things like findfirst, which are critical to the compiler.

44093 I already test merged, but had a conflict on the test. Looking into it costs too much time now

So both -> weekend, unless I get feedback from Florian.

baldzhang

  • New Member
  • *
  • Posts: 32
Re: about #0034416: EPoll_Event struct size
« Reply #4 on: February 12, 2020, 04:33:01 pm »
thanks marcov

now I know this is complex than I think.

and the mailing list has my posts, is it update daily?

Thaddy

  • Hero Member
  • *****
  • Posts: 10119
Re: about #0034416: EPoll_Event struct size
« Reply #5 on: February 12, 2020, 05:47:48 pm »
and the mailing list has my posts, is it update daily?
It is updated every time somebody posts ...It is near real time. (except if you are unknown, then it might take some moderation or even refused to post)
« Last Edit: February 12, 2020, 05:49:53 pm by Thaddy »
I am more like donkey than shrek

baldzhang

  • New Member
  • *
  • Posts: 32
Re: about #0034416: EPoll_Event struct size
« Reply #6 on: February 24, 2020, 03:59:45 am »
manually patched branches/fixes_3_2 r44232, compiled and run unit tests, on Raspberry Pi 4, Debian 10 arm64
the digest outputs is same as original codes
hopefully is useful to merge this two revisions

Code: [Select]
make -C utils utils
make[1]: Entering directory '/srv/build/fpc-fixes-3.2/tests/utils'
make[1]: Leaving directory '/srv/build/fpc-fixes-3.2/tests/utils'
utils/digest output/aarch64-linux/log
No run found for "Skipping test because for other target webtbs/tw36544b.pp 2020/02/19 05:39:54"
Total = 7574 (38:7536)
Total number of compilations = 4658 (11:4647)
Successfully compiled = 3522
Successfully failed = 1125
Compilation failures = 8
Compilation that did not fail while they should = 3
Total number of runs = 2916 (27:2889)
Successful runs = 2889
Failed runs = 27
Number units compiled = 152
Number program that should not be run = 450
Number of skipped tests = 627
Number of skipped graph tests = 10
Number of skipped interactive tests = 31
Number of skipped known bug tests = 7
Number of skipped tests for other versions = 4
Number of skipped tests for other cpus = 402
Number of skipped tests for other targets = 173

baldzhang

  • New Member
  • *
  • Posts: 32
Re: about #0034416: EPoll_Event struct size
« Reply #7 on: April 22, 2020, 06:16:48 pm »
@marcov
emmmm.... any news?

Bi0T1N

  • New Member
  • *
  • Posts: 29
Re: about #0034416: EPoll_Event struct size
« Reply #8 on: April 23, 2020, 03:40:08 pm »
Better add it to the wiki page. Maybe with a reference to your post.
According to the log view it seems not merged yet.
« Last Edit: April 23, 2020, 03:44:22 pm by Bi0T1N »

baldzhang

  • New Member
  • *
  • Posts: 32
Re: about #0034416: EPoll_Event struct size
« Reply #9 on: May 12, 2020, 04:30:52 pm »
I saw 3.2 was tagged without this, hope they can be merged next release ...

baldzhang

  • New Member
  • *
  • Posts: 32
Re: about #0034416: EPoll_Event struct size
« Reply #10 on: Today at 04:44:49 pm »
 :D :D saw the merge.

marcov

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 8388
  • FPC developer.
Re: about #0034416: EPoll_Event struct size
« Reply #11 on: Today at 05:54:47 pm »
Better add it to the wiki page. Maybe with a reference to your post.
According to the log view it seems not merged yet.

Note that that is the fixes, not the release branch. The release branch is tags/release_3_2_0

 

TinyPortal © 2005-2018