Forum > General

[SOLVED] FPCUPDELUXE: Failed to build Lazarus fixes using FPC fixes.

<< < (2/4) > >>

bee:

--- Quote from: Thaddy on February 01, 2020, 08:47:29 am ---
--- Code: Pascal  [+][-]window.onload = function(){var x1 = document.getElementById("main_content_section"); if (x1) { var x = document.getElementsByClassName("geshi");for (var i = 0; i < x.length; i++) { x[i].style.maxHeight='none'; x[i].style.height = Math.min(x[i].clientHeight+15,306)+'px'; x[i].style.resize = "vertical";}};} ---// unit DynHashArray// this code at line 173 should be in J+ mode, it is a assignable typed const.const{$push}{J+}  ItemMemManager: TDynHashArrayItemMemManager = nil;{$pop}
--- End quote ---

It should be:

--- Code: Pascal  [+][-]window.onload = function(){var x1 = document.getElementById("main_content_section"); if (x1) { var x = document.getElementsByClassName("geshi");for (var i = 0; i < x.length; i++) { x[i].style.maxHeight='none'; x[i].style.height = Math.min(x[i].clientHeight+15,306)+'px'; x[i].style.resize = "vertical";}};} ---// unit DynHashArrayvar  ItemMemManager: TDynHashArrayItemMemManager = nil;Writable constant doesn’t make any senses. FPC should disable it by default, at least on ObjFPC mode.

bee:

--- Quote from: DonAlfredo on February 01, 2020, 08:47:57 am ---There were some recent changes that went into FPC fixes regarding cocoa.
Some of them did introduce changes that are not (yet) compatible with Lazarus.

--- End quote ---
Yes, this problem prevents me using latest fixes. Thank you.

Thaddy:

--- Quote from: bee on February 01, 2020, 12:38:38 pm ---
Writable constant doesn’t make any senses. FPC should disable it by default, at least on ObjFPC mode.

--- End quote ---
It should be ENabled to achieve proper result. The declaration writes it as nil, afterwards it needs to be assigned......
So it is precisely the other way around. I thought you knew.....

bee:

--- Quote from: Thaddy on February 01, 2020, 01:09:43 pm ---It should be ENabled to achieve proper result. The declaration writes it as nil, afterwards it needs to be assigned......
So it is precisely the other way around. I thought you knew.....

--- End quote ---
That’s why it should be a var, not a const. I thought you knew.

DonAlfredo:
Alright. Here you go.
Two patches included. One for FPC. The other for Lazarus.

If you use latest fpcupdeluxe, just drop the:
FPC patch into "patchfpc" directory.
Lazarus patch into "patchlazarus" directory.

Rebuild FPC and Lazarus.

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version