Recent

Author Topic: TScrollBar - Contributing a patch  (Read 118 times)

BrunoK

  • Full Member
  • ***
  • Posts: 204
  • Retired programmer
TScrollBar - Contributing a patch
« on: January 14, 2020, 12:44:53 pm »
I am a little disheartened it's been nearly 2 months since I contributed a patch to fix an issue on windows and it's just sat there.
I had already submitted a earlier version in July 2018 at the time of the problems with Enable on Win 10 that finally got corrected in January 2019.

Link:

https://bugs.freepascal.org/view.php?id=36429

Did I submit this patch to the wrong place? Is there something wrong with the patch? Is there just no developer with Windows experience and commit access ?

It shouldn't be difficult to patch trunk and revert in case it causes troubles.

Is this component just not used or maintained anymore?
Lazarus trunk r. 62137/27.10.2019 (+/- patches regarding TScrollBar, IntitalSetupDialog, Options.Environment options, SearchResults).  Lazarus 3.0.6 raw from svn.
FPC 3.0.4 32 bits. (+heaptrc with leaked ClassName+Revisited TList) , Windows 10 Pro x64 (v. 1903 / 18362.418)

skalogryz

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2347
    • havefunsoft.com
Re: TScrollBar - Contributing a patch
« Reply #1 on: January 14, 2020, 02:54:45 pm »
are you saying the patch proposed at #36429, is actually intended to fix the issue at #34014?

If yes, I'd recommend to just post the patch at 34014. (and close 36429)
Patron Cocoa Widgetset development https://www.patreon.com/skalogryz