Selecting a date in TDateEdit's popup calendar causes EXC_BAD_ACCESS

[emaijala]

Selecting a date from TDateEdit's calendar popup by double-clicking a date results in an exception:

Project dateedittest raised exception class 'Debugger stopped with reason: EXC_BAD_ACCESS (code=1, address=0x0)'.

 In file 'cocoawscommon.pas' at line 990:
FTarget.ClientToScreen(Point(Msg.XPos, Msg.YPos)),MButton+1,False);

Looks like FTarget is nil. I wasn't sure what the proper action would be in this case, so couldn't provide a fix. This problem affects latest master and at least 115 previous revisions. Tested with Mojave (10.14.6).

Sample application is attached (just a form with a TDateEdit in it). To reproduce, start the program, click the popup button and double-click a date.

[trev]

Confirmed with the macOS Lazarus/FPC versions below.

[skalogryz]

r62452

[trev]

Last Changed Rev: 62452
Last Changed Date: 2019-12-29 17:43:33 +1100 (Sun, 29 Dec 2019)

Code: [Select]

Free Pascal Compiler version 3.3.1 [2019/10/22] for x86_64
Copyright (c) 1993-2019 by Florian Klaempfl and others
Target OS: Darwin for x86_64
Compiling ../lcl.pas
Compiling alllclintfunits.pas
Compiling agl.pp
Assembling (pipe) ../../units/x86_64-darwin/cocoa/agl.s
Compiling cocoa_extra.pas
cocoa_extra.pas(242,1) Fatal: Syntax error, "IMPLEMENTATION" expected but "shl" found
Fatal: Compilation aborted
make[3]: *** [../lcl.ppu] Error 1
make[2]: *** [cocoa_all] Error 2
make[1]: *** [interfaces] Error 2
make: *** [lcl] Error 2

Update: sorted with a fresh svn checkout rather than an svn update. Give me RCS any day

[Cyrax]

Last Changed Rev: 62452
Last Changed Date: 2019-12-29 17:43:33 +1100 (Sun, 29 Dec 2019)

Code: [Select]

Free Pascal Compiler version 3.3.1 [2019/10/22] for x86_64
Copyright (c) 1993-2019 by Florian Klaempfl and others
Target OS: Darwin for x86_64
Compiling ../lcl.pas
Compiling alllclintfunits.pas
Compiling agl.pp
Assembling (pipe) ../../units/x86_64-darwin/cocoa/agl.s
Compiling cocoa_extra.pas
cocoa_extra.pas(242,1) Fatal: Syntax error, "IMPLEMENTATION" expected but "shl" found
Fatal: Compilation aborted
make[3]: *** [../lcl.ppu] Error 1
make[2]: *** [cocoa_all] Error 2
make[1]: *** [interfaces] Error 2
make: *** [lcl] Error 2


You probably need to do some clean ups before compiling Lazarus sources.

make distclean all <insert your usual flags and options here>

[trev]

[You probably need to do some clean ups before compiling Lazarus sources.

make distclean all <insert your usual flags and options here>

I was travelling back in time doing reverse merges and struck "cocoa_extra.pas node conflicted" so it looks like my source had been corrupted at some point after r61775 which was the last time I'd compiled it.

[trev]

Excellent - date picking no longer problematical.

Happy New Year Dmitry

[skalogryz]

Happy New Year!