TextOut: taCenter broken

[winni]

@circular

I just updated BGRAbitmap from 9.9.3 --> 10060400

Suddenly a lot of text printed on BGRAbitmaps was gone.
As sometimes there were little lines at the right border I could find out that error quick:

taCenter as parameter for the TextOut is the reason.

The text is not printed in the center of the bitmap but starts at the right edge - sometimes leaving a little bit "dirt" at the border. The rest is writen into nowhere.

Just test:

Code: Pascal  [Select][+][-]

1. tmp: TBGRABitmap;
2.  
3. tmp.TextOut(tmp.width div 2, y, MyText, color, taCenter);
4.  

You see that you see nothing....

Would be nice if you correct this!

Winni

[winni]

Hi!

Now I made some additional tests:

* If I add a renderer and a shader to the BGRAbitmap then there is no problem with taCenter
* With TextOutAngle there is no  problem with taCenter

So it seems that only the plain textOut without renderer and without an angle has this problem.

Winni

[circular]

Issue added:
https://github.com/bgrabitmap/bgrabitmap/issues/80

[circular]

Hmm I just tested on Linux and see no problem.

Have you tried a clean build of BGRABitmap and your program?

[winni]

Hi!

I was quiet shure but I just did a clean & build - no changes.

I just made a demo - see attachment. This is

Code: Pascal  [Select][+][-]

1. tmp.TextOut (0,12,'Hello World' ,col, taCenter);

My setup:
Linux64 gtk2, Laz 2.06, fpc 3.04, BGRAbitmap 10.6

Winni

[circular]

I don't have the bug on Linux 64 and Lazarus 2.0.2.

Could it be related to version of Lazarus ?

Anyone else on Linux having the bug with center?

[winni]

Hi!

The colorful world of Lazarus and BGRAbitmap:

I started Win7  in VBox.
There is installed:
Laz 2.0, fpc 3.04 and BGRABitmap 9.9.3

I made an online update to BGRABitmap 10.06 (and BGRAcontrol)
Compiled the IDE
Made a build for the project:

The same result as with linux: all moved to the right.

It seems that the text is displayed at

Center.x + TextWidth(string) div 2;

It should be

Center.x - TextWidth(string) div 2;

Winni

[circular]

Hmm, maybe if I try on some Windows computer, I could reproduce the bug.

[winni]

Hi circular!

I've got the "Bad Boy":

It is the Font.renderer !

I had to dive deep in my sources:

Without renderer everything works fine.
When I set the renderer.OutlineColor at once the text dissapears at the right side!

So you can stop the windows testing!

Winni

[circular]

Hmm ok, so do you have any idea where the bug happens? Which line of code?

[winni]

@circular

Debug, debug ...

Made a BGRAbitmap with a renderer and made a BGRA tour:

BGRAtextFX, BGRAvectorize and BGRAtypewriter.

Now i reached

procedure TBGRACustomTypeWriter.DrawText( ....

Here the x coordinate has still the correct value for taCenter:
Bmap.width = 300
center.x = 150

No I loose concentration and will continue later.

Winni

[winni]

Hi circular!

Something is going wrong here:

Code: Pascal  [Select][+][-]

1. procedure TBGRACustomTypeWriter.DrawText(ADest: TBGRACanvas2D; ATextUTF8: string;  X, Y: Single; AAlign: TBGRATypeWriterAlignment);
2.  

X and Y are still correct here, but then I do for tracing:

* fetch from the Canvas2D the points into an ArrayOfFPointF with
MyPoints := TheCanvas2D.currentPath;

* Convert the points to a string and add it to a StringList

* Save the StringList

No it comes to the nitty gritty:
My bitmap has a width of 300.
All points have an x between 300 and 600!!!

I guess the error could be inside the matrix operations for the Path, but I fear I get lost there.

Winni

[winni]

Hi circular!

Didn't get lost in the matrix jungle.

Now I give you two minus signs. As present.

Here is the "evil" one:

Code: Pascal  [Select][+][-]

1. function TBGRACustomTypeWriter.GetTextMatrix(ATextUTF8: string; X, Y: Single;
2.         AAlign: TBGRATypeWriterAlignment): TAffineMatrix;  

You forgot two minus signs. The code sgould be:

Code: Pascal  [Select][+][-]

1. if AAlign in[twaTop,twaMiddle,twaBottom] then tGlyph.X := -size.x/2 else
2.     if AAlign in[twaTopRight, twaRight, twaBottomRight] then tGlyph.X := -size.x;    

Since yesterday I know that textcolor inside pascal code in this editor together does not work so again her:

-size.x/2 
and
-size.x

Now I need a beer.

Winni

[lainz]

I have been there one or two times catching a bug without knowing how to use a debugger 

[circular]

Thank you very much.

That seems indeed wrong. 

That's changed on dev branch.