daemonapp.pp makes assumptions about location of temp directory

[dsiders]

I just noticed after an update on svn that fcl-extra/src/daemonapp uses hard-coded paths for the service debugging log file. For Windows, it assumes C: and writes to the root directory (which is a no-no in my book). For all others, it assumes '/tmp'.

Shouldn't StartLog use GetTempDir (SysUtils is already in the uses clause)?

Like...

Code: Pascal  [Select][+][-]

1. Assign(FL, IncludeTrailingPathDelimiter(GetTempDir) + 'service.log');
2.  

[jamie]

well if it is indeed doing hard coding directly to the root then why not report it?

[PascalDragon]

I just noticed after an update on svn that fcl-extra/src/daemonapp uses hard-coded paths for the service debugging log file. For Windows, it assumes C: and writes to the root directory (which is a no-no in my book). For all others, it assumes '/tmp'.

Shouldn't StartLog use GetTempDir (SysUtils is already in the uses clause)?

Like...

Code: Pascal  [Select][+][-]

1. Assign(FL, IncludeTrailingPathDelimiter(GetTempDir) + 'service.log');
2.  

This log is part of the functionality to debug the daemonapp unit itself. As you can see the functionality is only enabled if svcdebug is defined which is not the case by default. Thus the functionality should only be used when working on daemonapp itself and thus on a development machine anyway.