Recent

Author Topic: Proposing an enhancement  (Read 605 times)

zebu1er

  • New Member
  • *
  • Posts: 12
Proposing an enhancement
« on: September 04, 2019, 05:24:43 pm »
Hi !
I'd like to participate to LAMW. My first goal is to propose an implemenation of GetAccuracy to jLocation.
However I face to problems :
- After pressing Ctrl-F1, in case of error inside the jLocation.java, I don't know where to find the error description thrown by the java compiler !
- Which way my modifications can be reported to the official code repository (patches, via owned SVN account, ...) ?
Thanks.

Handoko

  • Hero Member
  • *****
  • Posts: 3155
  • My goal: build my own game engine using Lazarus
Re: Proposing an enhancement
« Reply #1 on: September 04, 2019, 05:32:36 pm »
LAMW is actively developed and maintained by @jmpessoa, you should contact him:
https://forum.lazarus.freepascal.org/index.php?action=profile;u=47362

If you're familiar with GitHub, then here it is:
https://github.com/jmpessoa/lazandroidmodulewizard

jmpessoa

  • Hero Member
  • *****
  • Posts: 1455
Re: Proposing an enhancement
« Reply #2 on: September 05, 2019, 12:58:04 am »

Quote
I'd like to participate to LAMW.

Welcome!

Quote
I don't know where to find the error description thrown by the java compiler !

Yes, debuging Android not an easy task...

You can try:

1) Adb command line tool...

or
2)Lazarus menu "Tools" --> "[LAMW] ..." --> "Adb Logcat" --> "Dump"

or

3)https://github.com/jmpessoa/lazandroidmodulewizard/blob/master/docs/How_to_open_LAMW_project_with_AndroidStudio.txt

Yes! My java codes are produced using (3)!

Quote
Which way my modifications can be reported to the official code repository...

1) Modified ".java" code need be put in LAMW folder: "......\android_wizard\smartdesigner\java"

2)  After clone LAMW from github your can do a "pull request"  or send here in the forum or email it to me...


Lamw: Lazarus Android Module Wizard
https://github.com/jmpessoa/lazandroidmodulewizard

zebu1er

  • New Member
  • *
  • Posts: 12
Re: Proposing an enhancement
« Reply #3 on: September 05, 2019, 03:30:44 pm »
Ok fine JM,

The 3) sounds good for me as I don't have Eclipse but AndroidStudio, and that actually the jLocation.java visibly doesn't compile anymore since I modified it !

I'm not aware of pull request despite of reading github's doc, so I'll probably give you my work for that first contribution !

Thanks.

zebu1er

  • New Member
  • *
  • Posts: 12
Re: Proposing an enhancement
« Reply #4 on: September 05, 2019, 06:19:47 pm »
Here are the patches.
However I'm not convinced by the result. Should the accuracy be updated alongside the lat/lng/alt ...

jmpessoa

  • Hero Member
  • *****
  • Posts: 1455
Re: Proposing an enhancement
« Reply #5 on: September 16, 2019, 05:30:09 pm »

Hi, zebu1er!

Please,  can you put here your complete code:

"location.pas"

"jLocation.java"

Thank you!
Lamw: Lazarus Android Module Wizard
https://github.com/jmpessoa/lazandroidmodulewizard

jmpessoa

  • Hero Member
  • *****
  • Posts: 1455
Re: Proposing an enhancement
« Reply #6 on: September 18, 2019, 06:14:48 pm »


Ok.

Commited!!!

Thank you!
Lamw: Lazarus Android Module Wizard
https://github.com/jmpessoa/lazandroidmodulewizard