Recent

Author Topic: HMACSHA1Match() function infinite recursion  (Read 2317 times)

zamronypj

  • New Member
  • *
  • Posts: 39
    • Fano Framework, Free Pascal web application framework
HMACSHA1Match() function infinite recursion
« on: September 29, 2019, 07:06:44 am »
If you take a look at

https://github.com/graemeg/freepascal/blob/master/packages/hash/src/hmac.pp

Code: Pascal  [Select]
  1. function HMACSHA1Match(const ADigest1, ADigest2: THMACSHA1Digest): boolean;
  2. begin
  3.   Result := HMACSHA1Match(ADigest1, ADigest2);
  4. end;

HMACSHA1Match() is calling itself. Shouldn't it be calling SHA1Match() instead?
Fano Framework, Free Pascal web application framework https://fanoframework.github.io
Personal Projects https://v3.juhara.com
Github https://github.com/zamronypj

marcov

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 7501
Re: HMACSHA1Match() function infinite recursion
« Reply #1 on: September 29, 2019, 12:15:02 pm »
Seems resolved

43087 michael 2019-09-29 08:18:57 +0200 (Sun, 29 Sep 2019)
* Fix bug 000036113
Commit consists out of 1 line

    M /trunk/packages/hash/src/hmac.pp

zamronypj

  • New Member
  • *
  • Posts: 39
    • Fano Framework, Free Pascal web application framework
Re: HMACSHA1Match() function infinite recursion
« Reply #2 on: September 29, 2019, 01:05:07 pm »
That was quick. Kudos to Michael
Fano Framework, Free Pascal web application framework https://fanoframework.github.io
Personal Projects https://v3.juhara.com
Github https://github.com/zamronypj