Hello, everybody! First of all, please apologies for my bad english.
A week ago i tried to develop a simple helper application, which help to my customer to do some additional tasks into him ERP system.
ERP system is a old development, based on Delphi, BDE and firebird as a database server.
The encoding into database is set to "NONE", because of the BDE (or I dont know why), but string data are coded into WIN1251 encoding. So, if a connect ti DB with a Flame Robin or EMS Firebird manager And I setup a connection encoding to WIN1251, everything looks perfect, it display data with the correct encoding on the screen, both on Ubuntu 18 and/or Windows 10 environment.
But - when I start my development, I was very surprised, that instead of expected Cyrillic symbols, it display a question marks under windows or some other bullshits under ubuntu.
First of all, I set a "WIN1251" encoding on the connection level, but noting happens. Still the same.
I did some research into sources (d.pas, sqldb.pas, ibconnection.pp) and I found what is the problem.
into sqldb.pas - there is originally the following code:
procedure TSQLConnection.DoConnect;
var ConnectionCharSet: string;
begin
inherited;
// map connection CharSet to corresponding local CodePage
// do not set FCodePage to CP_ACP if FCodePage = DefaultSystemCodePage
// aliases listed here are commonly used, but not recognized by CodePageNameToCodePage()
ConnectionCharSet := LowerCase(GetConnectionCharSet);
case ConnectionCharSet of
'utf8','utf-8','utf8mb4':
FCodePage := CP_UTF8;
'win1250','cp1250':
FCodePage := 1250;
'win1252','cp1252','latin1','iso8859_1':
FCodePage := 1252;
else
begin
FCodePage := CodePageNameToCodePage(ConnectionCharSet);
if FCodePage = CP_NONE then
FCodePage := CP_ACP;
end;
end;
end;
Which obviously does not handle "WIN1251" encoding.
I made the following change:
procedure TSQLConnection.DoConnect;
var ConnectionCharSet: string;
begin
inherited;
// map connection CharSet to corresponding local CodePage
// do not set FCodePage to CP_ACP if FCodePage = DefaultSystemCodePage
// aliases listed here are commonly used, but not recognized by CodePageNameToCodePage()
ConnectionCharSet := LowerCase(GetConnectionCharSet);
case ConnectionCharSet of
'utf8','utf-8','utf8mb4':
FCodePage := CP_UTF8;
'win1250','cp1250':
FCodePage := 1250;
[b] 'win1251','cp1251':
FCodePage := 1251;[/b]
'win1252','cp1252','latin1','iso8859_1':
FCodePage := 1252;
else
begin
FCodePage := CodePageNameToCodePage(ConnectionCharSet);
if FCodePage = CP_NONE then
FCodePage := CP_ACP;
end;
end;
end;
and afther recompile the fpc packages and lazaris IDE, now the "FCodepage" of the ibconnection becomes "1251", which was the right way.
BUT - still no fixed the problem, still become question marks and bullshits.
After that, I found that there is FCodepage on the TStringField class, which was still set to CP_NONE, nevertheless of the fix above.
Unfortunately, it is a Pivate declaration and I can not change runtime with a helper class.
I found, that there is a CodePage publisher of that private declaration, but it is a read-only property. So, I changed it into db.pas to
[b]property CodePage : TSystemCodePage read FCodePage write FCodePage; [/b]
And did the following on my AfterOpen event:
procedure TMainForm.qGetCustomersAfterOpen(DataSet: TDataSet);
var i : integer;
begin
qGetCustomers.DisableControls;
try
for i := 0 to qGetCustomers.Fields.Count - 1 do
if qGetCustomers.Fields[ i ].DataType in [ftString, ftMemo] then begin
TStringField( qGetCustomers.Fields[ i ] ).CodePage := 1251;
end;
finally
qGetCustomers.EnableControls;
end;
end;
so, after this fix, all the data on the sceen was OK.
Finally, I discover that the problem is into Ibconnection.pp:
// [var]char or blob column character set NONE or OCTETS overrides connection charset
if ((TransType in [ftString, ftFixedChar]) and (PSQLVar^.sqlsubtype and $FF in [CS_NONE,CS_BINARY])) or
((TransType = ftMemo) and (PSQLVar^.relname_length>0) and (PSQLVar^.sqlname_length>0) and (GetBlobCharset(@PSQLVar^.relname,@PSQLVar^.sqlname) in [CS_NONE,CS_BINARY])) then
[b][i] FieldDefs.Add(PSQLVar^.AliasName, TransType, TransLen, TransPrec, (PSQLVar^.sqltype and 1)=0, False, i+1, CP_NONE)[/i][/b]
else
AddFieldDef(FieldDefs, i+1, PSQLVar^.AliasName, TransType, TransLen, TransPrec, True, (PSQLVar^.sqltype and 1)=0, False);
in that case, it adds a Field def with a CP_NONE Code page, instead of call AddFieldDef method, which will add a fielddef with a rigth 1251 code page from ibConnection.
Is there anybody help me why it add a field def on this way?
What this code means?
if ((TransType in [ftString, ftFixedChar]) and (PSQLVar^.sqlsubtype and $FF in [CS_NONE,CS_BINARY])) or
((TransType = ftMemo) and (PSQLVar^.relname_length>0) and (PSQLVar^.sqlname_length>0) and (GetBlobCharset(@PSQLVar^.relname,@PSQLVar^.sqlname) in [CS_NONE,CS_BINARY]))
I am ready to do all that fixes into a trunk, but I can not login to bug tracker, it does not allow to reset password. If I try to register a new user whit old user name, it report that my user name allready exists.
Recent
