Cross platform DirectoryWatcher

[Wosi]

I hope here is the right place for this:

I've made a cross platform DirectoryWatcher library. It's working on Windows, Mac and Linux.
Feel free to use it.
Please tell me if you find a bug.

https://github.com/Wosi/DirectoryWatcher

[JuhaManninen]

I think this should be placed in FPC's libraries.
I remember such a cross-platform class has been requested and discussed earlier but it did not exist then.
Now it does. Cool!

[hnb]

I think this should be placed in FPC's libraries.

Fully agree . Anyway I see that DirectoryWatcher is licensed under MIT so AFAIK can't be added to FPC libraries.

[Wosi]

I think this should be placed in FPC's libraries.

Fully agree . Anyway I see that DirectoryWatcher is licensed under MIT so AFAIK can't be added to FPC libraries.

Glad, you like it ;-)
What is the license you want? LGPL?
I'm not a lawyer. Is it possible to license the library under both licenses?

[hnb]

What is the license you want? LGPL?
I'm not a lawyer. Is it possible to license the library under both licenses?

I am not lawyer too, but IMO the most perfect licensing model for 3rd library has mORMot:

https://synopse.info/files/html/Synopse%20mORMot%20Framework%20SAD%201.18.html#TITL_34

Any part of mORMot can be integrated with Lazarus or FPC at any time. FPC RTL/FCL is licensed under modified LGPL with static linking exception, see: http://wiki.freepascal.org/modified_LGPL

[ASerge]

Please tell me if you find a bug.

OnGetData is called without synchronization with the main thread. When used in GUI applications, this can cause problems.

[Wosi]

https://synopse.info/files/html/Synopse%20mORMot%20Framework%20SAD%201.18.html#TITL_34

Any part of mORMot can be integrated with Lazarus or FPC at any time. FPC RTL/FCL is licensed under modified LGPL with static linking exception, see: http://wiki.freepascal.org/modified_LGPL

Thanks, I copied the license text from mORMot.

Please tell me if you find a bug.

OnGetData is called without synchronization with the main thread. When used in GUI applications, this can cause problems.

Works as intended. If synchronization is important then the user of the library has to take care of it inside the callback.

[JuhaManninen]

The nested method calls when constructing TDirectoryWatcherBuilder is a nice idea.
However I think the user should have an option to use a more traditional way of setting properties.
For example there should be:

Code: Pascal  [Select][+][-]

1. property Recursive: Boolean read FRecursively write FRecursively;
2. property OnDirectoryChanged: TDirectoryEvent read FCallBack write FCallBack;

Note the naming convention for the event property, they typically start with On...
The event type itself could be TDirectoryChangedEvent, and the event variable could be FOnDirectoryChanged instead of FCallBack.
The event handler in the example is poorly named. It should be DirectoryChanged or maybe FileChanged instead of OnFileEvent.

Is there a need to separate events for directories and files?

@hnb, you are an FPC developer, or at least a semi-developer due to your generics collection work.
Can you influence this DirectoryWatcher going into FPC libs?
We can also ask about it in fpc-dev list.

[hnb]

@hnb, you are an FPC developer, or at least a semi-developer due to your generics collection work.

I have no idea x)

Can you influence this DirectoryWatcher going into FPC libs?
We can also ask about it in fpc-dev list.

No need to ask on fpc-dev list. The library will be added to FCL (rather synchronized with not committed yet similar library).

[hnb]

@Wosi please check PM from me.

[edwinyzh]

checked, worked as expected, and I like the fluent sytle API

[promisetom]

Has anyone created an app using DirectoryWatcher using Forms.
I would like to use it in a graphics based app, not a console.
I tested an issue version using formas and received a "SIGSEGV exception"
Tom

[zamronypj]

I think this should be placed in FPC's libraries.

Fully agree . Anyway I see that DirectoryWatcher is licensed under MIT so AFAIK can't be added to FPC libraries.

According to  https://softwareengineering.stackexchange.com/questions/189633/what-sublicense-actually-means I believe you can sublicense MIT as LGPL but not vice versa as long as you give copyright license and license notice. https://tldrlegal.com/license/mit-license

[af0815]

Has anyone created an app using DirectoryWatcher using Forms.
I would like to use it in a graphics based app, not a console.
I tested an issue version using formas and received a "SIGSEGV exception"
Tom

Have you used synchronize to make a correct thread change as described in post #6 from wosi. You have to use this in the callback. See also
https://wiki.freepascal.org/Multithreaded_Application_Tutorial
https://www.freepascal.org/~michael/articles/lazthread/lazthread.pdf

The reason is, the forms and other grafic stuff is not thread safe. So you have to use synchronize to bring the operation to the main thread, which can deal with the forms and the other graphical elements.

But it is a good idea to show the program or parts, so other people can see your problem. Because you see your code and the community sees nothing and can only stick in fog.