Recent

Author Topic: fpGfx - Update/patch  (Read 3794 times)

jc99

  • Hero Member
  • *****
  • Posts: 539
    • My private Site
fpGfx - Update/patch
« on: March 26, 2016, 01:04:14 am »
Hi everybody,

lately i checked out fpGfx from  http://svn.freepascal.org/svn/fpcprojects/fpgfx

And it didn't compile ...
So I went through the code and got it running again. (at least for win)

If anybody is interested I attached a [compressed] .patch-file
maybe someone could (after some scrubbing/testing) also update the repository.
OS: Win XP x64, Win 7, Win 7 x64, Win 10, Win 10 x64, Suse Linux 13.2
Laz: 1.4 - 1.8.4, 2.0
https://github.com/joecare99/public
'~|    /''
,_|oe \_,are
If you want to do something for the environment: Twitter: #reduceCO2 or
https://www.betterplace.me/klimawandel-stoppen-co-ueber-preis-reduzieren

Graeme

  • Hero Member
  • *****
  • Posts: 1430
    • Graeme on the web
Re: fpGfx - Update/patch
« Reply #1 on: March 26, 2016, 08:17:46 pm »
That code is now part of the greater fpGUI Toolkit [https://sourceforge.net/projects/fpgui/] since mid 2005. The current fpGUI is a total rewrite though, but I still maintain [on occasion] the original fpGUI+fpGFX+fpIMG code in the v0.4_fixes branch of fpGUI, and last time I checked it is still compilable with the latest FPC. So you are welcome to contribute any changes there if you want. See the SourceForge page for details on accessing the code repository.
--
fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal
http://fpgui.sourceforge.net/

jc99

  • Hero Member
  • *****
  • Posts: 539
    • My private Site
Re: fpGfx - Update/patch
« Reply #2 on: March 27, 2016, 01:06:13 pm »
That code is now part of the greater fpGUI Toolkit [https://sourceforge.net/projects/fpgui/] since mid 2005. The current fpGUI is a total rewrite though, but I still maintain [on occasion] the original fpGUI+fpGFX+fpIMG code in the v0.4_fixes branch of fpGUI, and last time I checked it is still compilable with the latest FPC. So you are welcome to contribute any changes there if you want. See the SourceForge page for details on accessing the code repository.
then it would be nice to update the FPCPRojects-repository with your working code.
... And maybe also the fpGUI-path 

OS: Win XP x64, Win 7, Win 7 x64, Win 10, Win 10 x64, Suse Linux 13.2
Laz: 1.4 - 1.8.4, 2.0
https://github.com/joecare99/public
'~|    /''
,_|oe \_,are
If you want to do something for the environment: Twitter: #reduceCO2 or
https://www.betterplace.me/klimawandel-stoppen-co-ueber-preis-reduzieren

Graeme

  • Hero Member
  • *****
  • Posts: 1430
    • Graeme on the web
Re: fpGfx - Update/patch
« Reply #3 on: March 28, 2016, 12:29:02 pm »
then it would be nice to update the FPCPRojects-repository with your working code.
... And maybe also the fpGUI-path
The fpGUI Toolkit project's home is the repository on SourceForge.net. The original FPCProjects repository has not been used since long before 2005 [for fpGFX, fpGUI and fpIMG). They also didn't want to give me write access to that repository at that time (I was very new to FPC then). So I've always been working in my own repository, and later moved it to SourceForge (and a mirror on Github) to be more accessible to the public.
--
fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal
http://fpgui.sourceforge.net/

jc99

  • Hero Member
  • *****
  • Posts: 539
    • My private Site
Re: fpGfx - Update/patch
« Reply #4 on: March 28, 2016, 06:40:18 pm »
The fpGUI Toolkit project's home is the repository on SourceForge.net. The original FPCProjects repository has not been used since long before 2005 [for fpGFX, fpGUI and fpIMG). They also didn't want to give me write access to that repository at that time (I was very new to FPC then). So I've always been working in my own repository, and later moved it to SourceForge (and a mirror on Github) to be more accessible to the public.
The last commit to that directory was actually in the middle of 2005,
The reason I ask, is that there are very alive projects next to very old ones.
And to me it's very convenient, since I use SVN (because freepascal & Lazarus work with svn), and I don't want to mix the repositories.
Is it possible to enable SVN-Read access on your github repo? Or have such a Repo on Sourceforge?
I think there is no need for public write-Access to everything, as long as you can send patches to someone with Write-Access for approval.
If it's OK with you I also could generate such a patch. But Who HAS write access to the FPCProjects ?
 
OS: Win XP x64, Win 7, Win 7 x64, Win 10, Win 10 x64, Suse Linux 13.2
Laz: 1.4 - 1.8.4, 2.0
https://github.com/joecare99/public
'~|    /''
,_|oe \_,are
If you want to do something for the environment: Twitter: #reduceCO2 or
https://www.betterplace.me/klimawandel-stoppen-co-ueber-preis-reduzieren

jc99

  • Hero Member
  • *****
  • Posts: 539
    • My private Site
Re: fpGfx - Update/patch
« Reply #5 on: March 28, 2016, 07:30:48 pm »
BTW: The patch is ready (but untested):
Now, with your approval, it can be patched into fpcprojects.

 
OS: Win XP x64, Win 7, Win 7 x64, Win 10, Win 10 x64, Suse Linux 13.2
Laz: 1.4 - 1.8.4, 2.0
https://github.com/joecare99/public
'~|    /''
,_|oe \_,are
If you want to do something for the environment: Twitter: #reduceCO2 or
https://www.betterplace.me/klimawandel-stoppen-co-ueber-preis-reduzieren

Graeme

  • Hero Member
  • *****
  • Posts: 1430
    • Graeme on the web
Re: fpGfx - Update/patch
« Reply #6 on: March 28, 2016, 08:42:01 pm »
The last commit to that directory was actually in the middle of 2005,
Either way, that code is very old and out of date.

Quote
Is it possible to enable SVN-Read access on your github repo? Or have such a Repo on Sourceforge?
Yes, Github allows SVN read-only access to a Git repository. Simpy check out the repository with the following URL:

https://github.com/graemeg/fpGUI.git

If you want to work on the latest stable fpGUI, look at the maint branch. If you really wanted to work on the old fpGFX, fpGUI and fpGFX code, then look at the v0.4_fixes branch.

Just so you know, I applied a minor fix to the v0.4_fixes branch today to be compatible with FPC 3.0 again, but I highly recommend you use maint instead as it is a massive improvement over the original code, has tons of fixes, improvements and many more widgets.

Quote
If it's OK with you I also could generate such a patch. But Who HAS write access to the FPCProjects ?
 
I don't know. You will have to ask in the fpc-pascal mailing list. Incidently, this was discussed many many years back, but somebody from the FPC team (Florain I think) was supposed to remove the old fpGFX, fpGUI and fpIMG code so as not to cause confusion with the latest fpGUI Toolkit project. I guess that never happened.

Regards,
  Graeme
« Last Edit: March 28, 2016, 09:34:33 pm by Graeme »
--
fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal
http://fpgui.sourceforge.net/

 

TinyPortal © 2005-2018