Forum > Beginners

Possible error in fpcanvas.inc

(1/1)

BlackTemplar:
I don't understand the line 612 in fpcanvas.inc. Why (db or db) and not (db or dp) ? Is it an error ?


--- Code: ---procedure TFPCustomCanvas.Rectangle (const Bounds:TRect);
var np,nb,dp,db,pb : boolean;
begin
  np:= Pen.style <> psClear; // Need pen ?
  nb:= Brush.style <> bsClear;  // Need brush ?
  dp:=(pen is TFPCustomDrawPen); // Pen draws ?
  db:=(brush is TFPCustomDrawBrush); // Brush draws ?
  if (np and nb) and not (db or db) then // line 612
    DoRectangleAndFill (bounds)
--- End code ---

engkin:
Based on the rest of the procedure, yes, you are right that's an error. BUT it is already fixed on the trunk.

BlackTemplar:
Ok. I'll try to use svn in a few days.

Merci (in french in the text^^)

Navigation

[0] Message Index

Go to full version