Recent

Author Topic: Possible error in fpcanvas.inc  (Read 1704 times)

BlackTemplar

  • Newbie
  • Posts: 3
Possible error in fpcanvas.inc
« on: February 24, 2015, 03:09:41 pm »
I don't understand the line 612 in fpcanvas.inc. Why (db or db) and not (db or dp) ? Is it an error ?

Code: [Select]
procedure TFPCustomCanvas.Rectangle (const Bounds:TRect);
var np,nb,dp,db,pb : boolean;
begin
  np:= Pen.style <> psClear; // Need pen ?
  nb:= Brush.style <> bsClear;  // Need brush ?
  dp:=(pen is TFPCustomDrawPen); // Pen draws ?
  db:=(brush is TFPCustomDrawBrush); // Brush draws ?
  if (np and nb) and not (db or db) then // line 612
    DoRectangleAndFill (bounds)

engkin

  • Hero Member
  • *****
  • Posts: 3112
Re: Possible error in fpcanvas.inc
« Reply #1 on: February 24, 2015, 03:34:13 pm »
Based on the rest of the procedure, yes, you are right that's an error. BUT it is already fixed on the trunk.

BlackTemplar

  • Newbie
  • Posts: 3
Re: Possible error in fpcanvas.inc
« Reply #2 on: February 24, 2015, 03:47:53 pm »
Ok. I'll try to use svn in a few days.

Merci (in french in the text^^)

 

TinyPortal © 2005-2018