Recent

Author Topic: New ID attributes on SynEditHighLighter unit.  (Read 46104 times)

Martin_fr

  • Administrator
  • Hero Member
  • *
  • Posts: 5635
    • wiki
Re: New ID attributes on SynEditHighLighter unit.
« Reply #60 on: December 14, 2013, 02:42:32 pm »
Committed in 43540.

You did not add a public wrapper in the patch? If you still need it, please add it to mantis, so it will not be forgotten, since I probably want look at it before the holidays.

Edson

  • Hero Member
  • *****
  • Posts: 1044
Re: New ID attributes on SynEditHighLighter unit.
« Reply #61 on: December 15, 2013, 04:42:10 am »
Thanks Martin. But, what is a "public wrapper". Do you mean to report a bug on Mantis?

 
Lazarus 1.6 - FPC 3.0.0 - x86_64-win64 on  Windows 7

Martin_fr

  • Administrator
  • Hero Member
  • *
  • Posts: 5635
    • wiki
Re: New ID attributes on SynEditHighLighter unit.
« Reply #62 on: December 15, 2013, 12:53:38 pm »
"public wrapper": I thought you needed a public method to access this?
If not then I am mistaken  and all is fine.

Mantis:
*IF* you do need the above and *if* you do have a patch, then subwit the patch on mantis.



Edson

  • Hero Member
  • *****
  • Posts: 1044
Re: New ID attributes on SynEditHighLighter unit.
« Reply #63 on: December 15, 2013, 05:53:13 pm »
Do you refer to something like this:

Code: [Select]
    property NumberAttribute: TSynHighlighterAttributes
      index SYN_ATTR_NUMBER read GetDefaultAttribute;
   ...
Lazarus 1.6 - FPC 3.0.0 - x86_64-win64 on  Windows 7

Martin_fr

  • Administrator
  • Hero Member
  • *
  • Posts: 5635
    • wiki
Re: New ID attributes on SynEditHighLighter unit.
« Reply #64 on: December 15, 2013, 06:46:45 pm »
NO, it was all discussed back on this thread.

Anyway, If the committed is good for what you want to do, then it is all fine, and no need for more.

Edson

  • Hero Member
  • *****
  • Posts: 1044
Re: New ID attributes on SynEditHighLighter unit.
« Reply #65 on: December 15, 2013, 06:59:47 pm »
NO, it was all discussed back on this thread.

Yes, it is what I supposed.

The "committed" is OK for me.  I would have done more changes, but it would break the compatibility.

Lazarus 1.6 - FPC 3.0.0 - x86_64-win64 on  Windows 7