[Solved] How to get TControl.Hint to respect Parent.BiDiMode?

[Avishai]

OK, I forgot that Bart Broersma had given me this tip that takes care of switching based on BiDiMode for each control.  But there was still a problem with the way the HintWindow displayed the text, but only when I used Hebrew text.  Maybe there has been a change in Lazarus code because that problem doesn't seem to exist now:

Bart Broersma's Tip:
=============
In application.inc we find these commented out lines

    // make the hint have the same BiDiMode as the activating control
    //FHintWindow.BiDiMode := FHintControl.BiDiMode;  <== Activate this line

in TApplication.ShowHintWindow

[Avishai]

[Solved - sort of] OK.  I have something that seems to work.

In File 'Application.inc' near line #840 in routine
'TApplication.ShowHintWindow' I activated this line that had been commented out.

Code: [Select]

procedure TApplication.ShowHintWindow(const Info: THintInfoAtMouse);
  ...
  ...
  // make the hint have the same BiDiMode as the activating control
  FHintWindow.BiDiMode := FHintControl.BiDiMode; // <== Activate This Line
  ...
  ...
end;


Then in the File 'HintWindow.inc' I added this as the last line of routine 'THintWindow.CalcHintRect' near line #276.

Code: [Select]

function THintWindow.CalcHintRect(MaxWidth: Integer; const AHint: String; AData: Pointer): TRect;
  ...
  ...
  if BiDiMode<>bdLeftToRight then inc(Result.Right);
end;


[Bart]

@Avishai: I enabled BidiMode.
You are right, it looks wrong RTL. Please answer my questions in bugtracker, and let's contunue the discussion there.

Bart

[Avishai]

Thanks Bart.  I have added a comment to BugTracker.

[Bart]

Fixed THintWindow.CalcHintRec.

Bart

[Avishai]

Bart, I did SVN Update but I don't see any relative code changes and I'm still seeing the same behavior as before.  No BiDi support.  Did I miss something? 

[Bart]

Do you use trunk (1.3)?
You need at least r43367.
See: http://svn.freepascal.org/cgi-bin/viewvc.cgi?view=revision&root=lazarus&revision=43361, http://svn.freepascal.org/cgi-bin/viewvc.cgi?view=revision&root=lazarus&revision=43367 and http://svn.freepascal.org/cgi-bin/viewvc.cgi?view=revision&root=lazarus&revision=43368.

This has not yet been merged to the 1.2 fixes branch.

Bart

[Avishai]

Yes, I have Lazarus 1.3 - 43372.  I don't understand why I'm not seeing the changes.

[Bart]

Well, do you see the changes in the code I made?

Bart

[Avishai]

Yes, I'm looking at it now.  But in Application.inc it still has

//FHintWindow.BiDiMode := FHintControl.BiDiMode;

So I guess that's why I'm seeing the old behavior.

[Avishai]

I just uncommented //FHintWindow.BiDiMode := FHintControl.BiDiMode; and I got the same chopped-off Text as before.  If it's working correctly for you, it must be something I'm doing.  But I tried adding the 'inc(Result.Right)' back into 'HintWindow.inc' and it looks as it should again.

Sorry to be such a bother.

[Bart]

Avishai,

and I got the same chopped-off Text as before.

The fix for that is not in application.inc, but in hintwindow.inc.

You have local changes to LCL which prevent a decent svn up.
Please do a

Code: [Select]

cd \path\to\lazarus
make clean
svn revert -R
svn up

and then rebuild Lazarus.

Bart

[Avishai]

Thanks Bart.

You have local changes to LCL which prevent a decent svn up.

When ever I experiment with Lazarus code, I work on a copy so that I can revert back to the original.

However, the 'Make Cleal All' seems to have cleared up the problem.  I should have thought of that myself.  Anyway I'm now getting proper display.

Thank you so much for your help and your patience.

[Bart]

You're welcome.
Please close the associated bugreport.

Bart