Here are my answers, Paskal. Please tell me if you intend to take care of one of those so that we do not do it twice.
And with the fixes came some bugs :
1. If some of the files added to the main window of LazPaing by drag and drop is not supported an error message is shown that the file is not supported and no files are added. AFAIR I have tested this before sending the patch- an error message used to be shown, but all other files were added.
...
The reason is that if there are 50 files that cannot be opened, this will show 50 message boxes. Otherwise we can agglomerate error messages for the different files and display them in one single message box, and load the image with the files that could be read.
I like the idea of agglomerating error messages. What about a for with a Memo inside and an
Okay button? Next week I will check if I can
talk with the file opening function.
In uimagelist.pas there is a function IsExtensionValid. You might consider to move it to a PAS file with global functions and use it in the main form, too.
Yes, in any case, it would be a good thing to put this in a separate unit as simple procedures/functions. Then, this unit could be moved to any package.
Okay, please tell a name for the unit.
2. You have changed shortcuts for Next and Previous image from the image list to Alt+Left and Alt+Right.
2.1. Now when I press one of the shortcuts an image is skipped, i.e. if file 3 is open, the next open file is 5, instead of 4.
I think the reason is that pressing the arrow key moves the selected row a line up/down, and after that the procedure is called and the line is moved once again.
The problems is that I cannot disable keyboard navigation (auto advance:=false does not help).
One possible solution is to store the current row and increment it upon alt-Left/right.
Could there be another way out?
Edit: I fixed it by disabling stringgrid on Alt, and reenabling it on KeyUp. I will submit a patch, unless you prefer another solution.
That is a way to solve it. That said, Key variable should be set to zero to say it has been processed. This could solve the problem too.
2.2. I have assigned Space and BackSpace because they are active only when the imagelist is active. Maybe with Alt+Left and Alt+Right these shortcuts should become global?
That is why I changed the shortcuts, to make them global shortcuts. Space and Backspace obviously interferes with tools input.
Still they are not global. So if you have no other solution for item 2,1 I will submit a patch for mine. I will check if I can make shortcuts global.
3. When files are added to the image list the first one is opened automatically. I am not sure that this is a good idea, maybe some settings checkbox should be used? I would ask other users (if any) opinions.
Yeah I don't know. I thought that it would be quicker. Also the problem is that when we click the Next arrow, it opens the second file when in my opinion if the first one has not been opened, it should be opened at this moment.
The last one is a point, indeed. So I will leave autoopening, only if there are no other files in the filelist. If there are files, already, a new file will not be open. Does it sound okay?
4. I wonder- maybe the imagelist shall show automatically, after files are dragged and dropped in the image list? What do you think?
I suppose you mean when files are dropped in LazPaint, and that we choose to open in image list? Yes that is a good idea.
I will do it.
5. On Line 307 WidthMinimal:=300 shall become WidthMinimal:=340, because of the increased number of buttons.
Ok.
I'll fix that.
6. I saw some Paskal added in the About info. If you insist that my name should be added there, I'd rather prefer to be quoted under Contributors, or if that is not okay- as СМ630.
So to add a line under Author? If you like, yes.
I mean that I do not like the idea to be listed as "
Paskal". I am okay being named as
Contributors .