Lazarus
Home
Help
TinyPortal
Search
Login
Register
Lazarus
»
Forum
»
Free Pascal
»
General
(Moderators:
FPK
,
Tomas Hajny
) »
Optimize TDeque.IncreaseCapacity
Free Pascal
Website
Downloads
Wiki
Documentation
Bugtracker
Mailing List
Lazarus
Website
Downloads (Laz+FPC)
Packages (OPM)
FAQ
Wiki
Documentation (RTL/FCL/LCL)
Bugtracker
CCR Bugs
IRC channel
GIT
Mailing List
Other languages
Foundation
Website
Useful Wiki Links
Project Roadmap
Getting the Source
Screenshots
How to use the forum
About donations (wiki)
Bookstore
Computer Math and Games in Pascal
(preview)
Lazarus Handbook
Search
Advanced search
Recent
Poll: Watches and Display...
by
440bx
[
Today
at 07:13:51 pm]
Lazarus for Windows on aa...
by
msintle
[
Today
at 06:42:18 pm]
InstallAware Using Lazaru...
by
marcov
[
Today
at 04:46:46 pm]
Who is Indy mattias?
by
paweld
[
Today
at 04:17:53 pm]
[solved] how to get class...
by
Joanna
[
Today
at 03:53:05 pm]
I just released a commerc...
by
BrassGear
[
Today
at 03:17:28 pm]
Does anyone know why thes...
by
Laksen
[
Today
at 03:04:14 pm]
Database standards OR Am ...
by
gidesa
[
Today
at 02:37:56 pm]
How to: create DLL file f...
by
TRon
[
Today
at 02:26:53 pm]
A fairly simple sound sol...
by
paweld
[
Today
at 01:46:11 pm]
Demoscene The Champs Crac...
by
KodeZwerg
[
Today
at 01:45:18 pm]
Access violation when ope...
by
Чебурашка
[
Today
at 12:27:34 pm]
Step-into the field sette...
by
Martin_fr
[
Today
at 11:31:48 am]
Access violation when re-...
by
Chris Osborne
[
Today
at 11:31:25 am]
AI, NLP and CAI: Text Gen...
by
Dzandaa
[
Today
at 11:03:26 am]
dwindows for Android
by
PierceNg
[
Today
at 10:54:44 am]
create system unit from s...
by
Laksen
[
Today
at 10:53:57 am]
[Solved] Find child contr...
by
Joanna
[
Today
at 09:53:43 am]
FpDebug unexpected Assemb...
by
Marc
[
Today
at 08:46:38 am]
Offical launch of the 1 B...
by
Handoko
[
Today
at 07:59:07 am]
Big Numbers Math
by
iLya2IK
[
Today
at 07:13:20 am]
BUG REPORT: Unable to gen...
by
dbannon
[
Today
at 06:29:49 am]
what to do if my target M...
by
Laksen
[
Today
at 12:49:12 am]
For-in loop over constant...
by
ASerge
[
Today
at 12:36:09 am]
Converting a string/index...
by
TRon
[April 18, 2024, 11:56:37 pm]
« previous
next »
Print
Pages:
1
[
2
]
Author
Topic: Optimize TDeque.IncreaseCapacity (Read 7760 times)
Thaddy
Hero Member
Posts: 14373
Sensorship about opinions does not belong here.
Re: Optimize TDeque.IncreaseCapacity
«
Reply #15 on:
October 14, 2018, 08:06:38 pm »
Quote from: Alextp on October 14, 2018, 07:53:17 pm
What about my change?
The many branches in that code would make it slower than the current implementation.
Either use a look-up or stick to your original plan and increase the initial size to say, 4 or 5.
You have to devise some tests...
Logged
Object Pascal programmers should get rid of their "component fetish" especially with the non-visuals.
Artem3213212
New member
Posts: 7
Re: Optimize TDeque.IncreaseCapacity
«
Reply #16 on:
October 14, 2018, 08:45:12 pm »
Quote from: Alextp on October 14, 2018, 07:53:17 pm
What about my change?
Ok, but it make some bad work with memory pages. Correct version:
Code: Pascal
[Select]
[+]
[-]
procedure
TDeque
.
IncreaseCapacity
;
const
// if size is small, multiply by 2;
// if size bigger but <256M, inc by 1/8*size;
// otherwise inc by 1/16*size
cSizeSmall
=
1
*
1024
*
1024
;
cSizeBig
=
256
*
1024
*
1024
;
var
i
,
OldEnd
:
SizeUInt
;
DataSize
:
SizeUInt
;
begin
OldEnd
:
=
FCapacity
;
DataSize
:
=
FCapacity
*
SizeOf
(
T
)
;
if
FCapacity
=
0
then
FCapacity
:
=
4
else
if
DataSize<cSizeSmall
then
FCapacity
*=
2
else
if
DataSize<cSizeBig
then
FCapacity
+=
FCapacity
div
8
and
$FFFFF000
else
FCapacity
+=
FCapacity
div
16
and
$FFFFF000
;
SetLength
(
FData
,
FCapacity
)
;
if
(
FStart>
0
)
then
for
i
:
=
0
to
FStart
-
1
do
FData
[
OldEnd
+
i
]
:
=
FData
[
i
]
;
end
;
«
Last Edit: October 14, 2018, 08:55:41 pm by Artem3213212
»
Logged
AlexTP
Hero Member
Posts: 2402
Re: Optimize TDeque.IncreaseCapacity
«
Reply #17 on:
October 14, 2018, 08:48:59 pm »
Thaddy,
branches are needed here, to check: n in one of ranges:
[0..1M] [1M..256M] [256M..inf]
Logged
CudaText editor
-
ATSynEdit
-
More from me
ASerge
Hero Member
Posts: 2242
Re: Optimize TDeque.IncreaseCapacity
«
Reply #18 on:
October 17, 2018, 09:29:25 pm »
I like TFPList.Expand
Logged
Bart
Hero Member
Posts: 5290
Re: Optimize TDeque.IncreaseCapacity
«
Reply #19 on:
January 06, 2021, 12:57:17 pm »
These changes to TDeque have broken it.
If the array isn't doubled (in IncreaseCapacity) then it is not circular anymore (the calculation of the positions wehre to put/get values doesn't match anymore.
See
Issue #38306
.
Bart
Logged
Print
Pages:
1
[
2
]
« previous
next »
Lazarus
»
Forum
»
Free Pascal
»
General
(Moderators:
FPK
,
Tomas Hajny
) »
Optimize TDeque.IncreaseCapacity
TinyPortal
© 2005-2018