Recent

Author Topic: Issues publishing a project (No subdirectories incl., no non-Pas. files incl.?)  (Read 6887 times)

JuhaManninen

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3548
  • I like bugs.
Please try one more thing, add the following two line just below Result := mrOk(TPublisher.CopyAFile).
Pos() works and AnsiStartsStr(), but the right place is method DoFileFound. You already had a test there but it was wrong.
I fixed it in r58878. I also removed the now obsolete define. (So no pause for me ...)

GetMem and howardpc, how come you were not able to reproduce the recursion problem?
Did you not test with projects having many directory levels, some of them above the project main dir? GetMem did such tests earlier I guess.
Can't you reproduce the problem even with my test project?
Many directory levels has been the challenge all the time. The old original code already was able to include all files from a flat project directory.

Quote
Hopefully the publish project feature will become bug free soon.
Now it is bug free, at least for projects!  8)
Must test packages more later.
« Last Edit: September 05, 2018, 11:47:27 pm by JuhaManninen »

GetMem

  • Hero Member
  • *****
  • Posts: 3252
Quote
GetMem and howardpc, how come you were not able to reproduce the recursion problem?
Did you not test with projects having many directory levels, some of them above the project main dir? GetMem did such tests earlier I guess.
Can't you reproduce the problem even with my test project?
I did test your project, I saw no recursion issues.  Most likely the Pos function was already in place, preventing infinite loops. The bottom line is: programming all days long does not help in spotting bugs.  :)

Quote
Pos() works and AnsiStartsStr(), but the right place is method DoFileFound. You already had a test there but it was wrong.
I fixed it in r58878. I also removed the now obsolete define.
OK. Thanks.

Quote
Now it is bug free, at least for projects!  8)
Well I'm not so sure about this. Let's wait for a few days...I would say is stable enough for testing. :)

JuhaManninen

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3548
  • I like bugs.
@BrainChemistry, @tudi_x and others, how does the publish feature work?
Please test. I plan to remove debug output from it soon.
Please test also publishing packages.
This feature is now part of the fresh Lazarus 2.0 branch and RC1.

JuhaManninen

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3548
  • I like bugs.
I have removed most DebugLn() calls now.