Lazarus
Home
Help
TinyPortal
Search
Login
Register
Lazarus
»
Forum
»
Programming
»
Databases
»
Operation cannot be performed on an active dataset
Free Pascal
Website
Downloads
Wiki
Documentation
Bugtracker
Mailing List
Lazarus
Website
Downloads (Laz+FPC)
Packages (OPM)
FAQ
Wiki
Documentation (RTL/FCL/LCL)
Bugtracker
CCR Bugs
IRC channel
GIT
Mailing List
Other languages
Foundation
Website
Useful Wiki Links
Project Roadmap
Getting the Source
Screenshots
How to use the forum
About donations (wiki)
Bookstore
Computer Math and Games in Pascal
(preview)
Lazarus Handbook
Search
Advanced search
Recent
FpDebug questions
by
440bx
[
Today
at 03:43:41 am]
Lazarus for Windows on aa...
by
Wallaby
[April 23, 2024, 11:46:56 pm]
Parameter passing odditie...
by
KodeZwerg
[April 23, 2024, 11:04:39 pm]
Can function be used for ...
by
jamie
[April 23, 2024, 10:53:10 pm]
(Solved) TIndexedAVLTree ...
by
lainz
[April 23, 2024, 10:49:03 pm]
Demo Scene Picture sinwav...
by
KodeZwerg
[April 23, 2024, 10:26:21 pm]
fkInternalCalc
by
zraja
[April 23, 2024, 09:31:07 pm]
A fairly simple sound sol...
by
KodeZwerg
[April 23, 2024, 09:23:37 pm]
add new targets to make
by
marcov
[April 23, 2024, 08:38:42 pm]
how to tweek fpmake to co...
by
marcov
[April 23, 2024, 08:29:16 pm]
Quirky windows
by
ASerge
[April 23, 2024, 07:07:16 pm]
[Request] Demo Scene Sub ...
by
Gigatron
[April 23, 2024, 06:29:39 pm]
Unlocking Files
by
KodeZwerg
[April 23, 2024, 06:03:08 pm]
[SOLVED] trunk bug for mi...
by
Key-Real
[April 23, 2024, 05:56:32 pm]
Demo Scene Bitmap Font Sc...
by
Gigatron
[April 23, 2024, 05:56:27 pm]
Compile/Convert Delphi pr...
by
Martin_fr
[April 23, 2024, 05:43:11 pm]
Generics - correct syntax
by
Thaddy
[April 23, 2024, 05:40:59 pm]
InstallAware Using Lazaru...
by
msintle
[April 23, 2024, 05:26:36 pm]
Xcode Command Line Tools ...
by
Joseph
[April 23, 2024, 05:16:39 pm]
Offical launch of the 1 B...
by
Hartmut
[April 23, 2024, 04:49:29 pm]
what to do if my target M...
by
nickysn
[April 23, 2024, 04:16:02 pm]
compiler error in unit
by
paule32
[April 23, 2024, 03:49:50 pm]
Multithreading - synchron...
by
mika
[April 23, 2024, 01:48:51 pm]
May be useful to somebody
by
KodeZwerg
[April 23, 2024, 12:38:22 pm]
match automatic highlight...
by
Чебурашка
[April 23, 2024, 11:35:14 am]
« previous
next »
Print
Pages: [
1
]
Author
Topic: Operation cannot be performed on an active dataset (Read 2892 times)
martinrame
Full Member
Posts: 119
Operation cannot be performed on an active dataset
«
on:
June 22, 2018, 12:29:59 am »
Hi, I'm trying to do a Select, loop through its records, then call a procedure to update each record, but I'm getting "Operation cannot be performed on an active dataset".
I wonder why this error, since my "UpdateRecords" procedure creates a new TSqlQuery instance.
Here's my code:
Code: Pascal
[Select]
[+]
[-]
Procedure
ListRecords
;
var
lSql
:
TSqlQuery
;
id
:
Integer
;
begin
lSql
:
=
TSqlQuery
.
Create
(
nil
)
;
try
lSql
.
DataBase
:
=
DataModule1
.
PQConnection1
;
lSql
.
SQL
.
Text
:
=
'select * from table'
;
lSql
.
Open
;
while
not
lSql
.
Eof
do
begin
id
:
=
lSql
.
FieldByName
(
'id'
)
.
AsInteger
;
UpdateRecord
(
id
)
;
lSql
.
Next
;
end
;
finally
lSql
.
Free
;
end
;
end
;
Procedure
UpdateRecords
(
Id
:
Integer
)
;
var
lSql
:
TSqlQuery
;
begin
lSql
:
=
TSqlQuery
.
Create
(
nil
)
;
try
lSql
.
DataBase
:
=
DataModule1
.
PQConnection1
;
lSql
.
Transaction
:
=
DataModule1
.
SqlTransaction1
;
lSql
.
SQL
.
Text
:
=
'update table set read=true where id=:id'
;
lSql
.
ParamByName
(
'id'
)
.
AsInteger
:
=
id
;
lSql
.
ExecSql
;
DataModule1
.
SqlTransaction1
.
Commit
;
finally
lSql
.
Free
;
end
;
end
;
«
Last Edit: June 22, 2018, 02:06:15 pm by martinrame
»
Logged
valdir.marcos
Hero Member
Posts: 1106
Re: Operation cannI t be performed on an active dataset
«
Reply #1 on:
June 22, 2018, 05:16:10 am »
Why are you slowly updating all that on the client side instead of using the faster server side?
Code: SQL
[Select]
[+]
[-]
UPDATE
TABLE
SET
READ
=
TRUE
WHERE
id
IN
(
SELECT
id
FROM
TABLE
WHERE
condition
=
:condition
)
;
«
Last Edit: June 22, 2018, 05:34:23 am by valdir.marcos
»
Logged
martinrame
Full Member
Posts: 119
Re: Operation cannI t be performed on an active dataset
«
Reply #2 on:
June 22, 2018, 02:01:43 pm »
This is an example, not real code.
Inside my ListRecords function I do many more operations (that cannot be done in the database) than just updating records from the same table.
Logged
martinrame
Full Member
Posts: 119
Re: Operation cannot be performed on an active dataset
«
Reply #3 on:
June 22, 2018, 02:11:03 pm »
Sorry, the error does not comes from this code, but from a nested query I'm doing against an SQLServer Database.
I'll try to isolate it, then come bak.
Logged
martinrame
Full Member
Posts: 119
[SOLVED] Re: Operation cannot be performed on an active dataset
«
Reply #4 on:
June 22, 2018, 02:18:12 pm »
The solution was NOT commiting inside the nested procedure (the one tha does .ExecSQL), but commiting when the main loop ends.
Logged
rvk
Hero Member
Posts: 6169
Re: Operation cannot be performed on an active dataset
«
Reply #5 on:
June 22, 2018, 02:19:59 pm »
My guess is that DataModule1.SqlTransaction1 is also connected to the query in ListRecords (via the database connection in DataModule1). Committing that transaction will also close the query in ListRecords.
You need to re-think the flow or set the correct parameter for the transaction that it will not close the queries automatically. Rethinking the flow is the better choice. Maybe use a separate transaction in UpdateRecords().
Edit: Ah, you already found it
Logged
Print
Pages: [
1
]
« previous
next »
Lazarus
»
Forum
»
Programming
»
Databases
»
Operation cannot be performed on an active dataset
TinyPortal
© 2005-2018