* * *

Author Topic: [SOLVED] TInetSocket connect timeout patch.  (Read 1213 times)

Dimitrios Chr. Ioannidis

  • Jr. Member
  • **
  • Posts: 56
    • Nephelae
[SOLVED] TInetSocket connect timeout patch.
« on: May 16, 2018, 05:49:36 pm »
Hi,

  I created a patch against fpc trunk for the TInetSocket which is used from TFPHTTTPClient to add support for timeout during connect. Also there is a patch for the TFPHTTPClient to use this functionality.

  The patches are in the bug tracker issue 33745 TInetSocket connect timeout .

  Tested in Windows 10 and Debian 9 both x86_64.

  As I didn't do any testing with 32 bit Windows/Linux or at all in FreeBSD, I'll appreciate any help to see if there is any problem or side effects on those platforms and inform me here.

Best regards,
« Last Edit: June 09, 2018, 09:20:22 pm by Dimitrios Chr. Ioannidis »
Dimitrios Chr. Ioannidis
http://www.nephelae.eu

Dimitrios Chr. Ioannidis

  • Jr. Member
  • **
  • Posts: 56
    • Nephelae
Re: TInetSocket connect timeout patch.
« Reply #1 on: June 09, 2018, 09:19:51 pm »
Hi all,

  FYI, the patch is accepted in trunk rev: 39199.
Dimitrios Chr. Ioannidis
http://www.nephelae.eu

engkin

  • Hero Member
  • *****
  • Posts: 2115
Re: [SOLVED] TInetSocket connect timeout patch.
« Reply #2 on: June 09, 2018, 09:37:25 pm »
Thank you for the patch and the bug report.

It seems that Michael forgot to remove unit math from the uses section. I can not write a note regarding that as he marked it "resolved", I believe you should be able to change the status and/or leave a note.

Thank you again.

Dimitrios Chr. Ioannidis

  • Jr. Member
  • **
  • Posts: 56
    • Nephelae
Re: [SOLVED] TInetSocket connect timeout patch.
« Reply #3 on: June 09, 2018, 09:48:27 pm »
Hi,

It seems that Michael forgot to remove unit math from the uses section. I can not write a note regarding that as he marked it "resolved", I believe you should be able to change the status and/or leave a note.

I already send him an email. I hadn't thought to use the tracker ....  :(

[EDIT]: I updated the tracker also ...

regards,
« Last Edit: June 09, 2018, 10:00:50 pm by Dimitrios Chr. Ioannidis »
Dimitrios Chr. Ioannidis
http://www.nephelae.eu

engkin

  • Hero Member
  • *****
  • Posts: 2115
Re: [SOLVED] TInetSocket connect timeout patch.
« Reply #4 on: June 09, 2018, 10:21:36 pm »
And it got fixed.  :D

Thaddy

  • Hero Member
  • *****
  • Posts: 7107
Re: [SOLVED] TInetSocket connect timeout patch.
« Reply #5 on: June 09, 2018, 10:26:47 pm »
Yup! :)
inline variables like in D10.3 are a bit like Brexit: if you are given the wrong information it sounds like a good idea. Every kid loves candy, but it makes you fat and your teeth will disappear.

 

Recent

Get Lazarus at SourceForge.net. Fast, secure and Free Open Source software downloads Open Hub project report for Lazarus