Passing strings

[nugax]

I have a function to write a logfile setup as such:

Code: Pascal  [Select][+][-]

1. function write_bot_killer_log(var sDataToWrite : String): boolean;

When I call the function such as this:

Code: Pascal  [Select][+][-]

1. logging.write_bot_killer_log('Invalid BotKiller key pressed');

It is wanting a variable. Is there a way I can pass just text instead? it is set as string, so I am not sure what I'm missing!
 

[nugax]

Sorry I posted this in wrong place -> tried to move but i couldnt!

[howardpc]

Just remove the "var" from your function's parameter specification.

[taazz]

Defining the parameter sDataToWrite as var instructs the compiler that you intent to change the data passed in that parameter and you want that changes to persist when you exit the function (aka return the changes to the caller).  if you have intention to change the data passed then define it as const or if you do not have any intention to return the changes then simple remove the var definition.

[mangakissa]

use procedure instead of function

Code: Pascal  [Select][+][-]

1.     procedure write_bot_killer_log(const sDataToWrite : String);
2.  

[Thaddy]

No the function is a boolean: can be used to test write success or fail. Much better than procedure, actually...

[mangakissa]

Why? If it will giving a result back, it's usefull. Otherwise you use memory without purposes.
In his case it write something to a log and nothing more.   

[Thaddy]

Why? If it will giving a result back, it's usefull. Otherwise you use memory without purposes.
In his case it write something to a log and nothing more.

All the more reason to check if you actually succeeded. Otherwise your log becomes unusable...  It is simply good practice.

[mangakissa]

Check for what. Hello, I wrote somehing in a log. I gonna tell you that with true.

Code: Pascal  [Select][+][-]

1. if not log('hello') then
2.   showmessage('log isn't working')
3.  
4. function log(const aValue : string) : boolean;
5. begin
6.  if lines.add(aValue) = -1 then
7.     result := true
8.  else
9.   result := false;
10. end;  
11.  

This is inefficient.

[mangakissa]

Check for what. Hello, I wrote somehing in a log. I gonna tell you that with true.

Code: Pascal  [Select][+][-]

1. if not log('hello') then
2.   showmessage('log is not  working');
3.  
4. function log(const aValue : string) : boolean;
5. begin
6.   if lines.add(aValue) = -1 then
7.      result := true
8.   else
9.    result := false;
10. end;  
11.  

This is inefficient.

[nugax]

No the function is a boolean: can be used to test write success or fail. Much better than procedure, actually...

I wanted to know if it wrote succesfully -> if it didnt, maybe the file has issues, etc.
Thats why its a func

[nugax]

I used rwrite(log); for opening the file -> I assume this creates a new file. What should I be looking at for appending, etc.