Recent

Author Topic: I've created a TJSONPropStorage, dunno where to announce...  (Read 10434 times)

Gustavo 'Gus' Carreno

  • Hero Member
  • *****
  • Posts: 1120
  • Professional amateur ;-P
I've created a TJSONPropStorage, dunno where to announce...
« on: February 12, 2017, 01:51:19 am »
Hi there,

I've created a package with a TJSONPropStorage here.

Don't really know where to announce, or if , by any chance, it could included on the main Lazarus dist?

Any help, suggestions or being shouted at, will be appreciated.

Thanks,
Gus
Lazarus 3.99(main) FPC 3.3.1(main) Ubuntu 23.10 64b Dark Theme
Lazarus 3.0.0(stable) FPC 3.2.2(stable) Ubuntu 23.10 64b Dark Theme
http://github.com/gcarreno

Leledumbo

  • Hero Member
  • *****
  • Posts: 8757
  • Programming + Glam Metal + Tae Kwon Do = Me
Re: I've created a TJSONPropStorage, dunno where to announce...
« Reply #1 on: February 12, 2017, 06:23:35 am »
Read this first, then report an issue to the bugtracker with category "Patch" attaching the patch you created from the first step.

Gustavo 'Gus' Carreno

  • Hero Member
  • *****
  • Posts: 1120
  • Professional amateur ;-P
Re: I've created a TJSONPropStorage, dunno where to announce...
« Reply #2 on: February 12, 2017, 07:07:57 pm »
Read this first, then report an issue to the bugtracker with category "Patch" attaching the patch you created from the first step.

Well, it's not really a patch as it's a whole new component that is not present in the main distribution.

Should I still go through the patch hoops?

Thanks,
Gus
Lazarus 3.99(main) FPC 3.3.1(main) Ubuntu 23.10 64b Dark Theme
Lazarus 3.0.0(stable) FPC 3.2.2(stable) Ubuntu 23.10 64b Dark Theme
http://github.com/gcarreno

Leledumbo

  • Hero Member
  • *****
  • Posts: 8757
  • Programming + Glam Metal + Tae Kwon Do = Me
Re: I've created a TJSONPropStorage, dunno where to announce...
« Reply #3 on: February 12, 2017, 08:45:07 pm »
Well, it's not really a patch as it's a whole new component that is not present in the main distribution.

Should I still go through the patch hoops?
Yes, you're patching the components folder with your component. That's how it gets into the repository as you want it. Otherwise, you could just host it somewhere like github.

jmpessoa

  • Hero Member
  • *****
  • Posts: 2301
Re: I've created a TJSONPropStorage, dunno where to announce...
« Reply #4 on: February 12, 2017, 10:34:48 pm »
Hi gcarreno!

First: Thank you!

Suggestion for Android compatibility:

1. Drop LCL package dependency ["fcl-json" is a FCL package!]
   [yes, add FCL dependency!]   

2. Put the "register" procedure in another file...
   [yes, add LCLBase dependency, if you will provide a custom component icon!]

ex:
Code: Pascal  [Select][+][-]
  1. unit register_tjsonpropstorage;
  2.  
  3. {$mode objfpc}{$H+}
  4.  
  5. interface
  6. uses
  7.   Classes,
  8.   SysUtils,
  9.   LResources,    // [optional] need if you will provide a custom  component icon
  10.   JSONPropStorage;
  11.  
  12. Procedure Register;
  13.  
  14. implementation
  15.  
  16. Procedure Register;
  17. begin
  18.   {$I tjsonpropstorage_icon.lrs}   // [optional] if you have a custom component icon [as generate by "lazres.exe"]
  19.   RegisterComponents('Misc', [TJSONPropStorage]);
  20. end;
  21.  
  22. end.
  23.  

3. Include  "register_tjsonpropstorage.pas" file in your package.

Good Work!
« Last Edit: February 12, 2017, 10:59:43 pm by jmpessoa »
Lamw: Lazarus Android Module Wizard
https://github.com/jmpessoa/lazandroidmodulewizard

minesadorada

  • Sr. Member
  • ****
  • Posts: 452
  • Retired
Re: I've created a TJSONPropStorage, dunno where to announce...
« Reply #5 on: February 13, 2017, 12:38:13 pm »
Hi there,

I've created a package with a TJSONPropStorage here.

Don't really know where to announce, or if , by any chance, it could included on the main Lazarus dist?

Any help, suggestions or being shouted at, will be appreciated.

Thanks,
Gus
User @GetMem is in charge of OnlinePackageManager which will be in the next version of Lazarus.  Send him your component, and I expect he will include it.
GPL Apps: Health MonitorRetro Ski Run
OnlinePackageManager Components: LazAutoUpdate, LongTimer, PoweredBy, ScrollText, PlaySound, CryptINI

Gustavo 'Gus' Carreno

  • Hero Member
  • *****
  • Posts: 1120
  • Professional amateur ;-P
Re: I've created a TJSONPropStorage, dunno where to announce...
« Reply #6 on: February 13, 2017, 04:42:42 pm »
First: Thank you!

You're quite welcome!!

1. Drop LCL package dependency ["fcl-json" is a FCL package!]
   [yes, add FCL dependency!]   

2. Put the "register" procedure in another file...
   [yes, add LCLBase dependency, if you will provide a custom component icon!]

I'll have a gander at it.

I'm not sure I can drop the LCL completely since this component uses JSONConf and LazUTF8.

3. Include  "register_tjsonpropstorage.pas" file in your package.

Okydokes, I'll do this if it's current "correct" way of doing things.

Cheers,
Gus
Lazarus 3.99(main) FPC 3.3.1(main) Ubuntu 23.10 64b Dark Theme
Lazarus 3.0.0(stable) FPC 3.2.2(stable) Ubuntu 23.10 64b Dark Theme
http://github.com/gcarreno

Gustavo 'Gus' Carreno

  • Hero Member
  • *****
  • Posts: 1120
  • Professional amateur ;-P
Re: I've created a TJSONPropStorage, dunno where to announce...
« Reply #7 on: February 13, 2017, 04:45:41 pm »
User @GetMem is in charge of OnlinePackageManager which will be in the next version of Lazarus.  Send him your component, and I expect he will include it.

Many thanks for this, but...

I'm sorry for being such a newb with insistence, but when you say "Send him your component...", could you be more specific in terms of channels?

Use this forum's private messages?

Or some other way?

Many, many thanks,
Gus
Lazarus 3.99(main) FPC 3.3.1(main) Ubuntu 23.10 64b Dark Theme
Lazarus 3.0.0(stable) FPC 3.2.2(stable) Ubuntu 23.10 64b Dark Theme
http://github.com/gcarreno

Gustavo 'Gus' Carreno

  • Hero Member
  • *****
  • Posts: 1120
  • Professional amateur ;-P
Re: I've created a TJSONPropStorage, dunno where to announce...
« Reply #8 on: February 13, 2017, 05:00:59 pm »
Suggestion for Android compatibility:

All that you suggested has now been committed to GitHub's HEAD.

I still don't have an icon and I'm struggling a bit with it since I really suck at Graphic Applications (GIMP, Photoshop, etc...)

I'll tag it and do a proper release once I get the icon done.

AGAIN: Many thanks all of you for the help and welcoming messages!!

Cheers,
Gus
Lazarus 3.99(main) FPC 3.3.1(main) Ubuntu 23.10 64b Dark Theme
Lazarus 3.0.0(stable) FPC 3.2.2(stable) Ubuntu 23.10 64b Dark Theme
http://github.com/gcarreno

minesadorada

  • Sr. Member
  • ****
  • Posts: 452
  • Retired
Re: I've created a TJSONPropStorage, dunno where to announce...
« Reply #9 on: February 13, 2017, 05:19:35 pm »
User @GetMem is in charge of OnlinePackageManager which will be in the next version of Lazarus.  Send him your component, and I expect he will include it.

Many thanks for this, but...

I'm sorry for being such a newb with insistence, but when you say "Send him your component...", could you be more specific in terms of channels?

Use this forum's private messages?

Or some other way?

Many, many thanks,
Gus
Use the private messaging facility in this forum.
GPL Apps: Health MonitorRetro Ski Run
OnlinePackageManager Components: LazAutoUpdate, LongTimer, PoweredBy, ScrollText, PlaySound, CryptINI

Gustavo 'Gus' Carreno

  • Hero Member
  • *****
  • Posts: 1120
  • Professional amateur ;-P
Re: I've created a TJSONPropStorage, dunno where to announce...
« Reply #10 on: February 13, 2017, 05:38:53 pm »
Use the private messaging facility in this forum.

Done!

Thanks, so very much!!

Cheers,
Gus
Lazarus 3.99(main) FPC 3.3.1(main) Ubuntu 23.10 64b Dark Theme
Lazarus 3.0.0(stable) FPC 3.2.2(stable) Ubuntu 23.10 64b Dark Theme
http://github.com/gcarreno

avra

  • Hero Member
  • *****
  • Posts: 2514
    • Additional info
Re: I've created a TJSONPropStorage, dunno where to announce...
« Reply #11 on: February 14, 2017, 10:20:28 am »
I hate to spoil work already done, but I really do not think that TJSONPropStorage should be downloaded with OnlinePackageManager. I think it belongs to Lazarus in directory where TINIPropStorage and TXMLPropStorage are already placed. That would avoid any confusion. So, a patch for Lazarus would be more prefered by me.

Btw. nice work  ;D
ct2laz - Conversion between Lazarus and CodeTyphon
bithelpers - Bit manipulation for standard types
pasettimino - Siemens S7 PLC lib

balazsszekely

  • Guest
Re: I've created a TJSONPropStorage, dunno where to announce...
« Reply #12 on: February 14, 2017, 10:58:19 am »
Quote
@avra
I hate to spoil work already done, but I really do not think that TJSONPropStorage should be downloaded with OnlinePackageManager. I think it belongs to Lazarus in directory where TINIPropStorage and TXMLPropStorage are already placed. That would avoid any confusion. So, a patch for Lazarus would be more prefered by me.
For now it can be downloaded/installed through OPM. Consider it as an extra possibility. After it's added to Lazarus SVN, I will remove it from the central repository.

Gustavo 'Gus' Carreno

  • Hero Member
  • *****
  • Posts: 1120
  • Professional amateur ;-P
Re: I've created a TJSONPropStorage, dunno where to announce...
« Reply #13 on: February 14, 2017, 06:18:51 pm »
I hate to spoil work already done, but I really do not think that TJSONPropStorage should be downloaded with OnlinePackageManager. I think it belongs to Lazarus in directory where TINIPropStorage and TXMLPropStorage are already placed. That would avoid any confusion. So, a patch for Lazarus would be more prefered by me.

I also agree with you. I'll initiate the process of trying to get it unto the main SVN with a patch request once I have an icon.

And it seems that @GetMem is willing to remove it from the OPM once it gets integrated into the main tree, so we're all good ;)

Btw. nice work  ;D

Thanks!!!

Cheers,
GUs
Lazarus 3.99(main) FPC 3.3.1(main) Ubuntu 23.10 64b Dark Theme
Lazarus 3.0.0(stable) FPC 3.2.2(stable) Ubuntu 23.10 64b Dark Theme
http://github.com/gcarreno

Gustavo 'Gus' Carreno

  • Hero Member
  • *****
  • Posts: 1120
  • Professional amateur ;-P
Re: I've created a TJSONPropStorage, dunno where to announce...
« Reply #14 on: February 14, 2017, 06:19:44 pm »
For now it can be downloaded/installed through OPM. Consider it as an extra possibility. After it's added to Lazarus SVN, I will remove it from the central repository.

Thanks mate, you ARE a star :D

Cheers,
Gus
Lazarus 3.99(main) FPC 3.3.1(main) Ubuntu 23.10 64b Dark Theme
Lazarus 3.0.0(stable) FPC 3.2.2(stable) Ubuntu 23.10 64b Dark Theme
http://github.com/gcarreno

 

TinyPortal © 2005-2018