Setting Tfilelistbox.filetype programatically

[liewald]

Lazarus 1.6.2 r53363 FPC 3.0.0 x86_64-linux-gtk 2

Hi all

having a slight problem setting the Tfilelistbox ftype to ftdirectory programatically. BAsically I want to toggle whether files or directories are shown in the filelistbox. settin the filetype to ftnormal works fine but setting it to ftdirectory results in both directories and files being shown.

here's the code

begin
   if typetoggle.ItemIndex = 0 then
  begin
    filelist.mask := '*';
    filelist.FileType :=[ftdirectory];
  end
  else
  begin
  filelist.Mask := filter.Text; // from a tedit
  filelist.filetype := [ftnormal];
  end;
  filelist.Refresh;
end; 

any Ideas?

Dave

[howardpc]

If I drop a fileListBox and a button on a form and add the following it performs flawlessly. So there must be some other problem with your code. Perhaps the code to do with typetoggle...

Code: Pascal  [Select][+][-]

1. const
2.   isDirectory: boolean=True;
3.  
4. procedure TForm1.Button1Click(Sender: TObject);
5. begin
6.   if isDirectory then
7.     FileListBox1.FileType:=[ftDirectory]
8.   else
9.     FileListBox1.FileType:=[ftNormal];
10.   isDirectory:=not isDirectory;
11. end;

[liewald]

Sorry Tested your code same problem must be a version bug

Also looks as if same is happening by setting ftdirectory true in the object inspector

Dave

[rvk]

I see the same problem in Lazarus 1.7 trunk 32 bit on Windows.

With only ftDirectory in FileType the normal files are ALSO visible.

[balazsszekely]

This is a bug. Tested with delphi and works well.

[howardpc]

Ok, it's a LCL Windows bug.
I only tried on Linux where the FileType property behaves as expected (Laz 1.6, FPC 3.0.0).

[liewald]

Sorry but I'm using 64 bit Linux!

[balazsszekely]

@howardpc

I only tried on Linux where the FileType property behaves as expected.

See OPs first post: "Lazarus 1.6.2 r53363 FPC 3.0.0 x86_64-linux-gtk 2"

[balazsszekely]

@liewald

Please do the following:
1. Open filectrl.pp, it's located in: $(LazarusDir)/LCL/
2. Go to the bottom part of procedure UpdateFileList(Line: 342)
3. Add the following line:

Code: Pascal  [Select][+][-]

1. //....
2. begin
3.   if [csloading, csdestroying] * ComponentState <> [] then
4.     Exit;
5.   Clear;
6.   if FileType <> [] then
7.   begin
8.     if FindFirstUTF8(
9.       IncludeTrailingPathDelimiter(FDirectory)+AllDirectoryEntriesMask,
10.       FileTypeToFileAttribute(FileType), Info) = 0
11.     then
12.       repeat
13.         if MatchesMaskList(Info.Name,Mask) then
14.         begin
15.           if (ftNormal in FileType) or ((Info.Attr and AttrNotNormal) > 0) then
16.           begin
17.             if (Info.Attr and faDirectory) > 0 then
18.               Items.Add('['+Info.Name+']')
19.             else
20.               if FileType <> [ftDirectory] then  //<--add this line(meaning: only add files to list, if the set strictly differs from ftDirectory, empty sets are checked above)
21.                 Items.Add(Info.Name);                  
22.           end;
23.         end;
24.       until FindNextUTF8(Info) <> 0;
25.     FindCloseUTF8(Info);
26.   end;
27.  
28.   UpdateSelectedFileName;
29. end;

4. Rebuild the IDE

PS: This is just a quick fix, I did not test all the possible scenarios. You should fill in a bugreport.

[liewald]

Yyp that fixed it thanks will raise bug report now

thanks

Dave