grids.pas and horz scroll

[bytebites]

Code: Pascal  [Select][+][-]

1. procedure TCustomGrid.WMHScroll(var message: TLMHScroll);
2. var
3.   SP: TPoint;
4. begin
5.   SP := GetPxTopLeft;
6.  
7.   case message.ScrollCode of
8.     SB_THUMBPOSITION,
9.     SB_THUMBTRACK: begin
10.       if (message.ScrollCode=SB_THUMBPOSITION) or (goThumbTracking in Options) then
11.         TrySmoothScrollBy(message.Pos-SP.x, 0);
12.       message.Result := 0;
13.     end;
14.     SB_PAGEUP: TrySmoothScrollBy(-(ClientHeight-FGCache.FixedHeight), 0);
15.     SB_PAGEDOWN: TrySmoothScrollBy(ClientHeight-FGCache.FixedHeight, 0);
16.     SB_LINEUP: TrySmoothScrollBy(-DefaultRowHeight, 0);
17.     SB_LINEDOWN: TrySmoothScrollBy(DefaultRowHeight, 0);
18.   end;
19.  
20.   if EditorMode then
21.     EditorPos;
22. end;
23.  

Am I missed something but shouldn't horizontal scroll use width and not height, ClientWidth and FixedWidth etc. This is from trunk version of grids.pas.

[tk]

Shortly looked into the source and it has substantially changed since stable 1.6.
At first look it seems to me a bug.
If something does not work it clearly is (I use trunk as well but not this grid).

[wp]

I also wonder why horizontal scrolling should occur with PgUp, PgDown, LineUp and LineDown keys. Probably a copy and paste error.

[Ondrej Pokorny]

Fixed in r53476.