@Phil
Thanks for testing. Before I start, I would like to mention that until next week I don't have access to macOS 10.12 Sierra, so I did my testing with OSX 10.8 "Mountain Lion"(Lazarus trunk/FPC 3.0.2). I did test OPM in the past with Sierra, there is no difference as far as I can tell(regarding OPM).
Issues that I was abble to reproduce and fix:
- Clicking Help button does nothing.
- The bug with the Help button is probably because you're using OpenDocument. Use OpenURL instead. The help link is not a "document". Check other uses of OpenDocument.
True. Replaced OpenDocument with OpenURL in r. 55648. Thanks.
- Don't exclude .json files by default. That's like excluding .xml. I couldn't figure out why the contents of the OPM .zip differed in size from my .zip so I went down the list file by file and discovered that .json files were left out.
- Do exclude by default .so, .dll, .dylib. See .gitignore for other examples of oddball files that sometimes creep into folders. And some packages uses "units" instead of "lib" so exclude that by default too.
Fixed in r. 55648. In order for the changes to take effect you have to click the "Restore Defaults" button(OPM-->Options).
- Clicking on a package's URL does nothing. But double-clicking does. This is a non-standard way of handling an underlined link that looks like an HTML link.
Fixed in r. 55649. Thanks.
Issues that I was unable to reproduce:
- The initial order of the packages appears to be alphabetic, but then I see CodesigningHelper between LazBarcodes and LazRichView.
See attachment1(PackageOrder.png).
- Only the packages and rating columns are non-blank (and all ratings are 5 stars). Shouldn't there be something in the Repository and Status columns, or am I reading that wrong?
- Shouldn't the author and license info be listed when a package is expanded? I don't see this anywhere.
In order to see detailed info about the package, you have to expand the tree(nodes). The ratings are disabled(grayed) be default. When you rate a package the stars change color. See attachment2(Rating_Authors.png).
- Another odd UI bug: At first I thought the folder button on the "Create repository package" dialog was broken, because you have to click it twice. Something wrong there.
It works fine at my side with a single click. It's a standard TDirectoryEdit component. Can you please test if TDirectoryEdit works on your computer? In a separate project.
The wiki screenshot of "Create repository package" dialog looks nothing like what I see. I don't see any place to edit widgetsets supported, etc. So I guess changes need to be made in the resulting .json file manually. But then how to get back into the dialog to click Submit? And how to test the .json short of submitting it first?
You have to select a package folder first, to be more precise the root directory of the package. After that all available *.lpk's are listed, with all the information available. See attachment3(CreatePackage.png)
Issues that I cannot test.
- Scrolling the main list doesn't work right. On a MacBook, scrolling is normally done via the trackpad. This is much faster than moving the mouse over to the scroll bar. But in the OPM control, scrolling with the trackpad just makes it jiggle.
Unfortunately I don't have a trackpad just a regular mouse so I cannot test(IMac). OPM uses VirtualStringTree(VST) to display the list of packages so it's probably a VST bug. I would like to mention that in my experience many components are broken under carbon. For example listview is basically unusable(please see the following thread:
http://forum.lazarus.freepascal.org/index.php/topic,37581.msg252965.html#msg252965 ). VST works exceptionally well under win32/win64, gtk2 but apparently it has some minor issues under carbon. I will try to fix this issue as soon as possible(I need a trackpad first).
PS: I created a small video with OPM under OSX(please watch it in 720p):
https://youtu.be/X1gD1aFhmowPS1: It just occurred to me that maybe you don't see the + sign before each node. This issue might be caused by the latest changes in trunk related to high DPI. Especially true if you have retina display.