Online Package Manager

[balazsszekely]

@avra
To avoid duplicate work please send me ifdefed version to avra at writeme dot com.

It's already in the central repository. Just open OPM, check WST then click the download button. Apparently I only solved just part of the issues. It works on windows with FPC trunk, but not on the other platforms.   

[avra]

@avra
To avoid duplicate work please send me ifdefed version to avra at writeme dot com.

It's already in the central repository. Just open OPM, check WST then click the download button.

Of course, silly me!     

Apparently I only solved just part of the issues. It works on windows with FPC trunk, but not on the other platforms.

Can anyone confirm that WST works on non-windows platforms with FPC 3.0.2 or older?

[JuhaManninen]

CCR is in Mantis, so maybe I should go that path? If not for any reason, then it is not a problem for me to send you patches.

Both ways suit me.

@Juha: It is not clear to me if you have these errors trying to install CT version on FPC trunk only on non Windows OS, or you have it also on Windows? It works for me on Windows. Haven't tested elsewhere.

I tested only on Linux. By looking at code in semaphore.pas I guessed it works on Windows but not elsewhere:

Code: Pascal  [Select][+][-]

1. {$IFDEF FPC}
2.   {$IFDEF WINDOWS}
3.     TSemaphoreHandle = THandle;
4.   {$ELSE}
5.     {$DEFINE FPC_TM}
6.     TSemaphoreHandle = Pointer;
7.   {$ENDIF}
8. {$ENDIF}

Then see how FPC_TM is used.

I remember WST trunk worked well with FPC 3.0 on Linux at late last year. I believe it works with FPC 3.0.2, too.
I can test more sometime in near future.

This brings a question in my mind. Why WST needs such a FPC_TM define? FPC libs are cross-platform and lots of effort was used to make them so.
WST should be able to use TThreadManager on every platform, or then the alternative code on every platform, without IFDEFs.
semaphore.pas should not need this:

Code: Pascal  [Select][+][-]

1. uses
2. ...
3. {$IFDEF FPC}
4.   {$IFDEF WINDOWS}
5.     ,Windows
6.   {$ENDIF}
7. {$ENDIF};

Anyway, any bigger changes should be consulted with Inoussa when he is available.

[avra]

Can anyone confirm that WST works on non-windows platforms with FPC 3.0.2 or older?

Well, trunk WST will work only with FPC from Sep 5 2016 or newer because it uses at least TPasSourcePos introduced in this patch:
https://github.com/graemeg/freepascal/commit/37aa4c79e1ab81558cdfac05090309c2e2e1dc25
Does anyone have an idea how to at least aproximatelly detect FPC version for a compile message suggestion to install older WST?

[JuhaManninen]

Well, trunk WST will work only with FPC from Sep 5 2016 or newer because it uses at least TPasSourcePos introduced in this patch:
https://github.com/graemeg/freepascal/commit/37aa4c79e1ab81558cdfac05090309c2e2e1dc25

No it doesn't. I just searched WST trunk sources and it was not there.
TPasSourcePos is part of Pascal parser fcl-passrc. WST does not parse Pascal code.

Does anyone have an idea how to at least aproximatelly detect FPC version for a compile message suggestion to install older WST?

Detecting FPC trunk / FPC 3.02 / FPC 3.0 should be enough. It is reasonable if the WST found in OPM supports them.

I can test WST trunk with FPC 3.0.2 on Linux later today if needed.

[balazsszekely]

@avra
Does anyone have an idea how to at least aproximatelly detect FPC version?

I don't think it's possible to detect specific revision numbers, like the one from  Sep 5 2016(r. 34429), however a close approximation can be done like this(you can refine it more to detect 3.0.0, etc...):

Code: Pascal  [Select][+][-]

1. {$IF FPC_VERSION = 3}
2.   {$IF FPC_RELEASE = 0}
3.     {$IF FPC_PATCH >= 1}
4.       {$DEFINE FPC302}
5.     {$ENDIF}
6.   {$ELSE}
7.     {$IF FPC_PATCH > 0}
8.       {$DEFINE FPC311}
9.     {$ENDIF}
10.   {$ENDIF}
11. {$ENDIF}

Currently trunk is 3.1.1, but that will change in the future.

[JuhaManninen]

I don't think it's possible to detect specific revision numbers

And it is not needed either. Supporting trunk always means the latest revision of trunk. Trying to support all intermediate revisions would be a mess.
Right version checks now work also in future because the version numbers are sequential.
3.0.2 < 3.1.1 < 3.2.0.

[avra]

Well, trunk WST will work only with FPC from Sep 5 2016 or newer because it uses at least TPasSourcePos introduced in this patch:
https://github.com/graemeg/freepascal/commit/37aa4c79e1ab81558cdfac05090309c2e2e1dc25

No it doesn't. I just searched WST trunk sources and it was not there.
TPasSourcePos is part of Pascal parser fcl-passrc. WST does not parse Pascal code.

Check again. I was just a little ahead of time. 
https://sourceforge.net/p/lazarus-ccr/svn/HEAD/tree/wst/trunk/ws_helper/wsdl_parser.pas#l855

[JuhaManninen]

Check again. I was just a little ahead of time. 
https://sourceforge.net/p/lazarus-ccr/svn/HEAD/tree/wst/trunk/ws_helper/wsdl_parser.pas#l855

Ok, right. Inoussa has committed it.
Why does a Web Service code parse Pascal sources? I am puzzled. I understand it parses XML-based SOAP and WSDL.

Anyway, I have now tested WST trunk with FPC 3.0.2 + Lazarus fixes_1_8 branch and it compiles well.
I guess an OPM package should be made of WST trunk because there is no recent release.

[avra]

Anyway, I have now tested WST trunk with FPC 3.0.2 + Lazarus fixes_1_8 branch and it compiles well.

I tested on 1.6.4 + 3.0.2 from Manjaro 64bit repo and as expected it doesn't work because of that 9 months old patch. So newer Lazarus is needed, like yours. This is why I would like to show compile message to old Lazarus users that they need to use older WST. Otherwise they might be puzzled why it doesn't work.

I have also tested on Win10x64 TrunkAll (both trunks) and it didn't work initially, so I had to backport from CT. Patch attached. 
Any feedback is welcome before asking author to examine the patch.

I will now see how this patched WST in TrunkAll behaves on Linux...

UPDATE: I forgot to say that wst_ics.lpk is not used in CT so it could not be backported. It can't be compiled in TrunkAll, but since wst_indy.lpk and wst_synapse.lpk compile fine it does not matter much to me. Maybe someone else will be motivated enough to take a look...

[avra]

I will now see how this patched WST in TrunkAll behaves on Linux...

Well, there were semaphore problems on Linux as Juha has already reported, so I have backported CT fix (which I don't like that much but in lack of a better one it will have to do for now). This is the only problem on TrunkAll in Manjaro64 which is now fixed with this CT backport, so I checked when this breaking change was introduced:
https://github.com/graemeg/freepascal/commit/b338b3d12d657890b1f7ed2bdc49edfd1eb47c17
and IFDEF-ed changes so it can still compile on 3.0.2. Compilation fixed.

Patch allows WST trunk to compile fine with:
TrunkAll (32) on Win10 (64)
TrunkAll (64) on Manjaro Linux (64)
1.6.4+3.0.2 (64) on Manjaro Linux (64)

Any feedback is welcome before asking author to examine the patch.

Enjoy 

[balazsszekely]

Thanks avra for fixing WST. I will wait until Inoussa applies the patch, then I will add the package to the main repository.

[avra]

I will wait until Inoussa applies the patch, then I will add the package to the main repository.

Yes, I also think that would be the way to go.

[avra]

I will wait until Inoussa applies the patch, then I will add the package to the main repository.

Inoussa has just told me that he applied the patch. Can't wait to test it. 

[balazsszekely]

Inoussa has just told me that he applied the patch. Can't wait to test it. 

Done. Added to the main repository. Please test!