Length function not working?

[TheOddOne]

Code: [Select]


  Procedure GetPlayerNames;
    Begin
    Repeat
     Write('Enter player one name: ');
     Readln(FirstPlayer);
     If Length(FirstPlayer) = 0 Then
       Writeln('No, the player name must be more than l character')
     Else
       Begin
     Write('Enter player two name: ');
     Readln(SecondPlayer);
     If Length(SecondPlayer) = 0 Then
       Writeln('No, the player name must be more than l character')
     End;
    Until (Length(FirstPlayer > 0)) And (Length(SecondPlayer > 0));
   End;   

I want to ensure that the player enters a name that is obviously more than one character to ensure that the program does not crash. For some strange reason, this isn't working.

[rvk]

If you want to check that the length of a Player is MORE than 1 character you should use

Code: [Select]

If Length(FirstPlayer) < 2 Then
//...
If Length(SecondPlayer) < 2 Then
Later on

Code: [Select]

Until (Length(FirstPlayer > 1)) And (Length(SecondPlayer > 1));

(and not "= 0" and "> 0", as you have now)

[TheOddOne]

Code: [Select]


  Procedure GetPlayerNames;
    Begin
    Repeat
     Write('Enter player one name: ');
     Readln(FirstPlayer);
     If Length(FirstPlayer) = 0 Then
       Writeln('No, the player name must be more than l character')
     Else
       Begin
     Write('Enter player two name: ');
     Readln(SecondPlayer);
     If Length(SecondPlayer) = 0 Then
       Writeln('No, the player name must be more than l character')
     End;
    Until (Length(FirstPlayer > 0)) And (Length(SecondPlayer > 0));
   End;   

I want to ensure that the player enters a name that is obviously more than one character to ensure that the program does not crash. For some strange reason, this isn't working.

Thanks, that actually made sense, however regardless, I'm retrieving this compilation error:

COMP1.lpr(43,33) Error: Incompatible types: got "ShortInt" expected "AnsiString"

[rvk]

I can't see how you defined your variables.

A string is not the same as an integer (or shortint).

What line is line 43?

(Maybe you defined FirstPlayer as Shortint and then you can't use Length(FirstPlayer); )

For some strange reason, this isn't working.

Always make sure to describe the exact problem you're having.

"It's not working" is not exactly a clear problem-description.

[TheOddOne]

Code: [Select]


  Procedure GetPlayerNames;
    Begin
    Repeat
     Write('Enter player one name: ');
     Readln(FirstPlayer);
     If Length(FirstPlayer) = 0 Then
       Writeln('No, the player name must be more than l character')
     Else
       Begin
     Write('Enter player two name: ');
     Readln(SecondPlayer);
     If Length(SecondPlayer) = 0 Then
       Writeln('No, the player name must be more than l character')
     End;
    Until (Length(FirstPlayer > 0)) And (Length(SecondPlayer > 0));
   End;   

I want to ensure that the player enters a name that is obviously more than one character to ensure that the program does not crash. For some strange reason, this isn't working.

Thanks, that actually made sense, however regardless, I'm retrieving this compilation error:

COMP1.lpr(43,33) Error: Incompatible types: got "ShortInt" expected "AnsiString"

Hmm:

Code: [Select]

    FirstPlayer , SecondPlayer : String;

They're both strings.

[rvk]

What line is line 43?

For some strange reason, this isn't working.

Always make sure to describe the exact problem you're having.

"It's not working" is not exactly a clear problem-description.

If you get an compile error, please point to the exact line.
(I can't locate it in the code you gave because you didn't give the complete code)

[wp]

Until (Length(FirstPlayer > 0)) And (Length(SecondPlayer > 0));

You are using the closing bracket at the wrong place:

Until (Length(FirstPlayer) > 0) And (Length(SecondPlayer) > 0);

[TheOddOne]

Until (Length(FirstPlayer > 0)) And (Length(SecondPlayer > 0));

You are using the closing bracket at the wrong place:

Until (Length(FirstPlayer) > 0) And (Length(SecondPlayer) > 0);

Oh I just assumed it needed to go to the end. I was thinking what else could possibly be wrong with it. Thank you!

[wp]

"Length" is a function and "FirstPlayer" is its argument. Therefore, it must be "Length(FirstPlayer)".

[marcio2003]

Code: [Select]

COMP1.lpr(43,33) Error: Incompatible types: got "ShortInt" expected "AnsiString"
Please check the line 43 in column 33. it is in that place the error.