UTF8 filename

[totya]

Why do you use UnicodeString? The default String is now encoded with UTF-8. UnicodeString is UTF-16 and indeed triggers a conversion at every assignment. The warning is valid.
Just use String everywhere and this problem is solved.

Thanks, but I just use string everywhere...

[JuhaManninen]

Thanks, but I just use string everywhere...

Are the warnings from a dependent package?

[totya]

Hi!

Dependent package? What do you mean?

[JuhaManninen]

Dependent package? What do you mean?

A project can depend on packages which are also recompiled when needed.
Typical dependencies are LazUtils and LCL but you may have others.
The option -FcUTF8 for const strings does not affect units in those packages now, it should be moved to Additions and Overrides.

If the warnings come from units belonging to your project, then I have no idea what causes them.

[totya]

A project can depend on packages which are also recompiled when needed. (...)

Hi!

Okay, thank you for this information (I thought similar of this).


Environment:
Fpc+lazarus is latest trunk, I comiled these about one hour ago, with fpcup.
I open my actual project (about 2000 lines).
"UTF8 in RTL" setting is ON.
Rescan fpc directories
Rebuild ide
Run/Clean up and build

Error messages only from Dependent package, see attached file. Few ansi/wide errors visible in this log.

Greetings!

[JuhaManninen]

Error messages only from Dependent package, see attached file. Few ansi/wide errors visible in this log.

Ok, can you please add -FcUTF8 to the "Additions and Overrides" in Compiler Options, as a new custom option right next to the -dEnableUTF8RTL.
Then do a clean build again.

[totya]

Error messages only from Dependent package, see attached file. Few ansi/wide errors visible in this log.

Ok, can you please add -FcUTF8 to the "Additions and Overrides" in Compiler Options, as a new custom option right next to the -dEnableUTF8RTL.
Then do a clean build again.

Hi!

After I did this, only the compile times changed in the messages.

New options, see atached file.
New compiler messages, see attached file.

[JuhaManninen]

After I did this, only the compile times changed in the messages.

The UnicodeString warnings all come from RichMemo. It explicitly uses UnicodeString as I initially assumed.
For example :

C:\development\components\svn\richmemo\richmemoutils.pas(133,52) Warning: (4105) Implicit string type conversion with potential data loss from "UnicodeString" to "AnsiString"

Line 133 says :
  fs:= TFileStream.Create( UTF8Decode(FileNameUTF8), fmShareDenyNone or fmOpenRead);

You see, it calls this RTL function :
  function UTF8Decode(const s : RawByteString): UnicodeString;

The code works but it does 2 useless conversions between UTF-8 and UTF-16. If you check the other warnings carefully, they also turn out to be valid. You can ask Dmitry 'skalogryz' Boyarintsev if he wants to add support for the "better" UTF-8 system into RichMemo.

[totya]

Hi!

Thanks for answers!

But as I wrote, I get many warnings from my app, and I dont't like this. I use only simple strings, and only one place where I use conversion between UTF-8 and UTF-16.
I will create sample code for you, to see this problem.

[totya]

Error messages only from Dependent package, see attached file. Few ansi/wide errors visible in this log.

Ok, can you please add -FcUTF8 to the "Additions and Overrides" in Compiler Options, as a new custom option right next to the -dEnableUTF8RTL.
Then do a clean build again.

Hi!

Svn versions are terribe, so I install the latest stable version with fcpup "default" parameter. Laz: 1.4.0 /  FP: 3.0.1
Set UTF-8 in RLT button is missing, but UTF8 is working in RLT, for example Memo1.Lines.LoadfromFile('xx') xx: unicode chars (!). I didn't set any extra options for example -FcUTF8 or any... Is it normal? With old Lazarus, I get file open error with this simple project certainly.