UTF8 filename

[totya]

Hi!

It's a great component, but It seems to me, this component support only ANSI filenames. My request is UTF8 filenames support, if possible.

Thanks to developers!

[JuhaManninen]

It's a great component, ...

Which component?

[typo]

Juha, simply take a look at the title of the subforum (LOL).

I do not understand why you ask questions like this ...(LOL)

[totya]

It's a great component, ...

Which component?

Hi!

Yes, see subforum name: fpspreadsheet see http://wiki.freepascal.org/FPSpreadsheet


for example:

Code: [Select]

MyWorkbook.ReadFromFile(UTF8ToSys(FileName));
UTF8toSys conversion needed, but if filename(and/or path) is UTF8, then ReadFromFile doesn't work with this code:

Code: [Select]

MyWorkbook.ReadFromFile(FileName);
First problem is in fpspreadsheet unit:

Code: [Select]

procedure TsWorkbook.ReadFromFile(AFileName: string); overload;
var
  SheetType: TsSpreadsheetFormat;
  valid: Boolean;
  lException: Exception = nil;
begin
  if not FileExists(AFileName) then
    raise Exception.CreateFmt(rsFileNotFound, [AFileName]);   
See, this unit use FileExists function, and not FileExistsUTF8.

I hope you understand this problem now.

[JuhaManninen]

Juha, simply take a look at the title of the subforum (LOL).
I do not understand why you ask questions like this ...(LOL)

Oops ...
My bad.

Anyway, our improved Unicode support very likely solves this problem :
  http://wiki.freepascal.org/Better_Unicode_Support_in_Lazarus

[Bart]

I would think that the core of fpspreadsheet does not depend on anything form Lazarus, just fpc.
It would be possible to add a dependency on LazUtils and use TFileStreamUtf8, but that would make the component unusable for non-Lazarus (as in: pure fpc) developers.

Bart

[wp]

The main spreadsheet functionality (package laz_fpspreadsheet) depends on FCL and the LazUtils. The visual components (laz_fpspreadsheet_visual) depend also on LCL and TAChart.

simply take a look at the title of the subforum (LOL).
I do not understand why you ask questions like this ...(LOL)

And I do not understand why you expect me to take my time to answer your question which you did not take your time to formulate (LOL)

[rvk]

simply take a look at the title of the subforum (LOL).
I do not understand why you ask questions like this ...(LOL)

And I do not understand why you expect me to take my time to answer your question which you did not take your time to formulate (LOL)

Mmmm, I think the quoting is wrong here  That was a quote from typo, not totya, and was aimed at the response of JuhaManninen.

[typo]

Just a joke, sorry.

[wp]

Mmmm, I think the quoting is wrong here  (http://forum.lazarus.freepascal.org/Smileys/ExcellentSmileys1/wacko.gif) That was a quote from typo, not totya, and was aimed at the response of JuhaManninen.

Sorry - did not read carefully enough (as usual...). But the message remains: if users want somebody else to take their time for answering their questions they should take at least enough of their own time to formulate their questions in an understandable way.

[felipemdc]

Hi!

It's a great component, but It seems to me, this component support only ANSI filenames. My request is UTF8 filenames support, if possible.

Thanks to developers!

Try a search and replace in the main fpspreadsheet file:

Search for: TFileStream
Replace with: TFileStreamUtf8

And check if it fixes your problem.

[rvk]

Search for: TFileStream
Replace with: TFileStreamUtf8

That wouldn't solve the "not FileExists(AFileName)" in the source of fpspreadsheet, which isn't UTF-8 compatible as long as UTF-8 isn't enabled in RTL.

The suggestion from JuhaManninen seems much more promising:
http://wiki.freepascal.org/Better_Unicode_Support_in_Lazarus#Testing_with_Lazarus
(i.e. "Set UTF-8 in RTL)

File functions in RTL now take care of file name encoding. All (?) file name related ...UTF8() functions can be replaced with the Delphi compatible function without UTF8 suffix. For example FileExistsUTF8 can be replaced with FileExists.

But that would only work with the latest version (FPC 2.7.1).

[wp]

But this would make the basic spreadsheet functionality depend on LCL. It the worth the little convenience of not calling AnsiToUTF8/TUF8ToAnsi? Beyond that, there are other TFileStreams spread throughout the package: fpolebasic.pas, fpolestorage.pas, xlsooxml.pas, fpcsvdocument.pas, fpsopendocument.pas, fpsreaderwriter.pas, fpsstreams.pas, fpszipper.pas, fpsxmlcommon.pas

[wp]

That wouldn't solve the "not FileExists(AFileName)" in the source of fpspreadsheet, which isn't UTF-8 compatible as long as UTF-8 isn't enabled in RTL.

Why is this an issue? All strings passed to any fpspreadsheet filename are expected to be ansi, just like for any fpc file procedure. So, for reading a spreadsheet file from Lazarus, call "workbook.ReadFromFile(UTF8ToAnsi(filename))", and the "FileExists" is handled correctly.

[rvk]

"workbook.ReadFromFile(UTF8Filename);" would work too if the option is set to "Set UTF-8 in RTL" in the project-options (I think).

I don't think this is a fpspreadsheet issue at all and fpspreadsheet wouldn't even have to know what kind of encoding it's handling. It passes the strings to RTL (i.e. FileExists() ) and if the project-options are set correctly it would work correctly if the RTL can handle these UTF-8 strings (via that option).