Recent

Author Topic: Bug Busters  (Read 65618 times)

marcov

  • Administrator
  • Hero Member
  • *
  • Posts: 11453
  • FPC developer.
Re: Bug Busters
« Reply #60 on: September 24, 2014, 06:34:44 pm »
(Blush). Searching for a "save layout" and saving it makes it at least go away.

No multimonitor setup, just fresh installs on fullhd screens.

Mike.Cornflake

  • Hero Member
  • *****
  • Posts: 1260
Re: Bug Busters
« Reply #61 on: September 26, 2014, 01:34:28 pm »
This week is apparently a learning week.

Just discovered that if you raise an issue in Mantis and the developers subsequently set it to resolved, you then have the ability to Close the issue (if you're happy with, and have tested, the solution).

Sigh - which means I've just closed a slew of issues. 

Sharing this as looking at the number of issues marked "resolved" I suspect I'm not the only one who didn't know about that last step...
Lazarus Trunk/FPC Trunk on Windows [7, 10]
  Have you tried searching this forum or the wiki?:   http://wiki.lazarus.freepascal.org/Alternative_Main_Page
  BOOKS! (Free and otherwise): http://wiki.lazarus.freepascal.org/Pascal_and_Lazarus_Books_and_Magazines

nightrider

  • Full Member
  • ***
  • Posts: 139
Re: Bug Busters
« Reply #62 on: October 10, 2014, 02:46:58 pm »
Did you solve the problem with Windows Mobile/CE screen cleaning management?

Greetings from Sao Paulo - Brazil

Ricardo

JuhaManninen

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 4468
  • I like bugs.
Re: Bug Busters
« Reply #63 on: October 10, 2014, 03:46:37 pm »
Did you solve the problem with Windows Mobile/CE screen cleaning management?

Who are you asking from? Some sections of Lazarus code are not very actively maintained which is a problem.
We must find a way to get patched in those areas committed, too.
Mostly Lazarus trunk and FPC 3.2 on Manjaro Linux 64-bit.

Basile B.

  • Guest
Re: Bug Busters
« Reply #64 on: October 10, 2014, 04:07:11 pm »
Is it possible to fork on GitHub, to modify locally, to push the fork and then to propose a pull request ? or Laz and Fpc are purely svn and git only for visibility across the www ?
« Last Edit: October 10, 2014, 04:08:48 pm by Basile B. »

JuhaManninen

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 4468
  • I like bugs.
Re: Bug Busters
« Reply #65 on: October 10, 2014, 04:55:46 pm »
Is it possible to fork on GitHub, to modify locally, to push the fork and then to propose a pull request ? or Laz and Fpc are purely svn and git only for visibility across the www ?

To whom would you send the pull request?
There is no difference between Git or SVN in this case. You can send a "pull request" by e-mail to anybody you want to make sure your patch is notified. However it will not help if the maintainer is busy with other things. The maintainer is finally responsible for the commit and he must check and test the patch before committing it. This is the essential part of the process, the revision control system in use is irrelevant.

I know there are patches waiting for WinCE. The maintainer Felipe is busy (which is OK naturally) and I was thinking of a system where I would commit a patch without testing it (!) after I get confirmation from 2+ WinCE users that the patch works. Those people would then be "semi-developers" in Lazarus project, partly responsible of the quality.
Surely it would be better than ignoring the patches. The worst case scenario is that a bug is found later and the commit must be reverted which is not so awful either.

About Git support in Lazarus development: It is fully supported! Either create patches from your local branch:
  http://wiki.freepascal.org/Creating_A_Patch#Creating_a_patch_using_Git
or develop in a distributed manner:
  http://wiki.freepascal.org/Creating_A_Patch#Using_a_forked_Git_repository_directly
Nobody has yet used the distributed way, and I am rather happy for that. It would make things more difficult for me and for other people, compared to patches uploaded to bug tracker.
The diff format and the "patch" command are very good tools, and the bug tracker is very good for managing all the various issues and discussions about them.
« Last Edit: October 10, 2014, 04:57:44 pm by JuhaManninen »
Mostly Lazarus trunk and FPC 3.2 on Manjaro Linux 64-bit.

Basile B.

  • Guest
Re: Bug Busters
« Reply #66 on: October 10, 2014, 05:15:00 pm »
Is it possible to fork on GitHub, to modify locally, to push the fork and then to propose a pull request ? or Laz and Fpc are purely svn and git only for visibility across the www ?

To whom would you send the pull request?
bah...It's quite obvious that's the PR will be made to the repository I'd initially forked.
« Last Edit: October 10, 2014, 05:18:45 pm by Basile B. »

JuhaManninen

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 4468
  • I like bugs.
Re: Bug Busters
« Reply #67 on: October 10, 2014, 06:08:39 pm »
bah...It's quite obvious that's the PR will be made to the repository I'd initially forked.

I don't know how it would work when the project has many subsystem maintainers.
Maybe the pull request can be assigned to a specific person in GitHub.

BTW, I personally use Git, not because of its distributed aspects but because:
1. Local branches let me maintain experimental code and new features easily without hassle.
2. Local history and a tool, Gitk, to view it. There are also features like "git bisect" made possible by the local history.

Many companies at least in here have started to use Git but they also configure a server into their system. No distributed development there either.

P.S.
Returning to the first post of this thread, we have resolved some 150 reports since then. It is a big amount. Some reports were closed because trunk already had a fix for them or because they were not valid issues, but we also got many patches and developers fixed other issues by themselves.
I think this was a success.
In future I try to make sure patches are not ignored. It gives a bad impression of the project for those few people who actually take the effort and create code for it.
« Last Edit: October 11, 2014, 12:40:31 am by JuhaManninen »
Mostly Lazarus trunk and FPC 3.2 on Manjaro Linux 64-bit.

Basile B.

  • Guest
Re: Bug Busters
« Reply #68 on: October 10, 2014, 06:34:38 pm »
bah...It's quite obvious that's the PR will be made to the repository I'd initially forked.

I don't know how it would work when the project has many subsystem maintainers.
Maybe the pull request can be assigned to a specific person in GitHub.

BTW, I personally use Git, not because of its distributed aspects but because:
1. Local branches let me maintain experimental code and new features easily without hassle.
2. Local history and a tool, Gitk, to view it. There are also features like "git bisect" made possible by the local history.

Many companies at least in here have started to use Git but they also configure a server into their system. No distributed development there either.

P.S.
Returning to the first post of this thread, we have resolved some 150 reports since then. It is a big amount. Some reports were closed because trunk already had a fix for them or because they were not valid issues, but we also got many patches and developers fixed other issues by themselves.
I think this was a success.
In future I try to make sure patches are not ignored. It gives a bad impression of the project for those few people who actually take the effort and create code for it.

It's almost that. So let say, for a reason or another, I preafer GH. So
- I fork https://github.com/graemeg/lazarus (which seems to be the offical stuff)
- I modify some stuffs
- I make a PR

Is it working or not ? is this repository has a kind of credit, a kind of interest ? Can I contribute, as a "noboby", using this way ? (fork-myownthings-pull request) ?

JuhaManninen

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 4468
  • I like bugs.
Re: Bug Busters
« Reply #69 on: October 10, 2014, 07:58:44 pm »
Is it working or not ? is this repository has a kind of credit, a kind of interest ? Can I contribute, as a "noboby", using this way ? (fork-myownthings-pull request) ?

No it does not work.
Please again read this:
  http://wiki.freepascal.org/Creating_A_Patch#Creating_a_patch_using_Git
and then upload your patches to a bug report.

[Edit] and more...
> - I fork https://github.com/graemeg/lazarus (which seems to be the offical stuff)

Graeme has kindly put up a mirror repository but it is not really "official".
Still, I have promised to support a Lazarus fork in GitHub directly (see the wiki). Then you must communicate with me by e-mails, personal messages, whatever, but not by pull requests.
I made this promise when there was a group of whiners complaining about the "poor development tools" used by Lazarus project. According to them Git especially would make a big difference for everything. Well, Git is supported now but I don't see any big difference except that those whiners are gone. Good.
So, you can use the GitHub fork in any case but IMO creating patches from it is the easier way for both of us.
« Last Edit: October 11, 2014, 12:40:07 am by JuhaManninen »
Mostly Lazarus trunk and FPC 3.2 on Manjaro Linux 64-bit.

wp

  • Hero Member
  • *****
  • Posts: 11916
Re: Bug Busters
« Reply #70 on: October 10, 2014, 09:33:17 pm »
Quote
I think this was a success.
Absolutely. Amazing!

Quote
In future I try to make sure patches are not ignored.
I am concerned also about ccr where many projects are in a desolate state. Maintainers have left their activities, but things have changed, fpc has changed, Lazarus has changed, and lot of the material is no longer working. I almost gave up posting patches for ccr because nobody takes care of them. I have a couple of patches hanging around, but there are also patches provided by others to which I added a confirming note that they are working. But of course, since the maintainer left the project, nothing happens.

Mike.Cornflake

  • Hero Member
  • *****
  • Posts: 1260
Re: Bug Busters
« Reply #71 on: October 10, 2014, 09:45:11 pm »
Quote
I think this was a success.
Absolutely. Amazing!

+1
Lazarus Trunk/FPC Trunk on Windows [7, 10]
  Have you tried searching this forum or the wiki?:   http://wiki.lazarus.freepascal.org/Alternative_Main_Page
  BOOKS! (Free and otherwise): http://wiki.lazarus.freepascal.org/Pascal_and_Lazarus_Books_and_Magazines

JuhaManninen

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 4468
  • I like bugs.
Re: Bug Busters
« Reply #72 on: October 11, 2014, 10:19:29 am »
I am concerned also about ccr where many projects are in a desolate state. Maintainers have left their activities, but things have changed, fpc has changed, Lazarus has changed, and lot of the material is no longer working. I almost gave up posting patches for ccr because nobody takes care of them. I have a couple of patches hanging around, but there are also patches provided by others to which I added a confirming note that they are working. But of course, since the maintainer left the project, nothing happens.

Yes, this is a problem.
Are there patches for CCR in the bug tracker? Which issue numbers?
Mostly Lazarus trunk and FPC 3.2 on Manjaro Linux 64-bit.

wp

  • Hero Member
  • *****
  • Posts: 11916
Re: Bug Busters
« Reply #73 on: October 11, 2014, 02:49:26 pm »
Quote
Are there patches for CCR in the bug tracker? Which issue numbers?
I added a tag "patch" to ccr items back to 2013. Not sure if all these patches are working, but the following ones definitely are:

0026037: Checkbox and radiobuttons in spkToolbar pixelated at 120 ppi
0025732: Memory Leak when use Actions on Buttons in SpkToolbar
0026590: Cannot click tree items if tree is scrolled down

I know that ccr developers do have access to the entire svn tree, but should modify only code in "their" own project. How about giving each ccr developer the permission to apply a patch in someone else's project, maybe after a grace-period of, say, 3 months?

JuhaManninen

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 4468
  • I like bugs.
Re: Bug Busters
« Reply #74 on: October 12, 2014, 02:35:33 pm »
I know that ccr developers do have access to the entire svn tree, but should modify only code in "their" own project. How about giving each ccr developer the permission to apply a patch in someone else's project, maybe after a grace-period of, say, 3 months?

Yes, I don't believe anybody has objections for that. Feel free to commit code there.

I had missed the patches because I have Mantis project "Lazarus" selected most of the time.
I assigned SpkToolbar issues now for myself and marked myself as maintainer in wiki. Luiz Americo told already long ago he has too many things to maintain.
Apparently I don't have commit access to the repo. I will commit those patches when I get it.

Most CCR components have neither a wiki page nor a maintainer. It is bad.
I updated the wiki page so that all comps are at least listed. I will write another message about the situation.

Mostly Lazarus trunk and FPC 3.2 on Manjaro Linux 64-bit.

 

TinyPortal © 2005-2018