TComboBoxEx and TCheckComboBox

[engkin]

I think I found the culprit. Commenting two lines got rid of the problem:

Code: [Select]

procedure TCustomCheckCombo.DropDown;
var aCursorPos: TPoint;
    aRect: TRect;
begin
  //aCursorPos:=ScreenToControl(Mouse.CursorPos);
  aRect:=Rect(FHiLiteLeft, 0, FHiLiteRight, Height);
  //FRejectDropDown:= PtInRect(aRect, aCursorPos);  //<----
  if not FRejectDropDown then
    begin
      inherited DropDown;
      FRejectToggleOnSelect:=False;
    end else
    if ItemEnabled[ItemIndex] then Toggle(ItemIndex);
end;


[Blaazen]

Thanks for investigation! These lines are necessary for Qt4 and GTk2 only.
I guess I can hide them to directive:

Code: [Select]

{$IFNDEF WINDOWS}
  aCursorPos:=ScreenToControl(Mouse.CursorPos);
  aRect:=Rect(FHiLiteLeft, 0, FHiLiteRight, Height);
  FRejectDropDown:= PtInRect(aRect, aCursorPos);  //<----
{$ELSE}
  FRejectDropDown:=False;
{$ENDIF}


[BigChimp]

Maybe* I'm naive but you can run Qt and Gtk on Windows, too, can't you? So that define would then be too restrictive?

http://wiki.lazarus.freepascal.org/Code_Conversion_Guide
Perhaps something like
{$IfDef LCLGtk}
{$IfDef LCLQt}
is better?

*Edit: I'm certainly naive when it comes to components.... There

[Blaazen]

I think you are right. The condition should be like this:

Code: [Select]

{$IF DEFINED(LCLWin32) or DEFINED(LCLWin64)}

[Never]

combo6 test on win7 64bit
=======================
o got a [SIGSEGV] on mouse down and key down

Code: [Select]

on [DrawItem]
file [comboex.inc]line[598]

also there is not focus indication

[JuhaManninen]

These components are now part of LCL. Thanks a lot Blaazen for this contribution!

I did only simple testing.
Everybody, please report any possible bugs in the bug tracker. I will mark them as related to the original issue :
 http://bugs.freepascal.org/view.php?id=26515